[Macro] Incorrect report: macro_not_allowed_declaration.

[microtears]

The following example will report a macro_not_allowed_declaration error. Nevertheless, in the code, the factory constructor is augmented during the definition phase. The expected behavior is to have no error reported.

Macro Example

@Macro1()
class A {
  external factory A();
}


macro class Macro1 implements ClassDefinitionMacro {
  const Macro1();

  @override
  FutureOr<void> buildDefinitionForClass(
      ClassDeclaration clazz, TypeDefinitionBuilder builder) async {
    final constructors = await builder.constructorsOf(clazz);
    final factoryConstructor = constructors.single;
    final constructorBuilder =
        await builder.buildConstructor(factoryConstructor.identifier);
    constructorBuilder.augment(body: FunctionBodyCode.fromParts([
      '=> throw UnimplementedError();',
    ]));
  }
}

Error Message

The macro attempted to add declaration(s) not allowed during the definitions phase.
Locations: (129, 42)
---
part of 'file:///Users/anya/workspace/workspace/dart/pkgs/common/example/macro_issue_example.dart';

augment class A {
  augment factory A() => throw UnimplementedError();
}
---
Try adding these declaration during an earlier phase.dart(macro_not_allowed_declaration)

Dart info

#### General info

- Dart 3.6.0-238.0.dev (dev) (Tue Sep 10 17:07:55 2024 -0700) on "macos_arm64"
- on macos / Version 14.1 (Build 23B74)

[dart-github-bot]

Summary: The issue reports a false positive error "macro_not_allowed_declaration" when augmenting a factory constructor within a macro. The error occurs despite the augmentation happening during the definition phase, where it should be allowed.

[microtears]

I guess it might be the problem caused here, but I'm not sure.

sdk/pkg/analyzer/lib/src/summary2/macro_not_allowed_declaration.dart

Line 47 in 44e79f5

if (node.augmentKeyword == null) {