Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Augmentations] No error in the analyzer if augmentation declares a different return type #56291

Open
sgrekhov opened this issue Jul 19, 2024 · 2 comments
Labels
analyzer-spec Issues with the analyzer's implementation of the language spec area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-augmentations Implementation of the augmentations feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

/==================================================================================================================================\
| co19/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01 is new and failed (MissingCompileTimeError, expected Pass) |
\==================================================================================================================================/

--- Command "dart2analyzer" (took 40ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart out/ReleaseX64/gen/dartanalyzer.dart.snapshot -Dtest_runner.configuration=analyzer-asserts-linux --enable-experiment=macros --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json --format=json /b/s/w/ir/cache/builder/sdk/tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01.dart

static error failures:
- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 25, column 9, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 29, column 9, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 35, column 18, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 39, column 18, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 43, column 11, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 47, column 11, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 54, column 18, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 58, column 18, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 62, column 11, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 66, column 11, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 74, column 18, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 78, column 18, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 82, column 11, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 86, column 11, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 93, column 18, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 97, column 18, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 101, column 11, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 105, column 11, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 112, column 18, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 116, column 18, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 120, column 11, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 124, column 11, length 6.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 128, column 11, length 3.

- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01_lib.dart line 132, column 11, length 6.

--- Re-run this test:
python3 tools/test.py -n analyzer-asserts-linux co19/LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01
@sgrekhov sgrekhov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-augmentations Implementation of the augmentations feature labels Jul 19, 2024
@sgrekhov
Copy link
Contributor Author

@sgrekhov
Copy link
Contributor Author

@srawlins srawlins added type-enhancement A request for a change that isn't a bug P2 A bug or feature request we're likely to work on analyzer-spec Issues with the analyzer's implementation of the language spec labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-spec Issues with the analyzer's implementation of the language spec area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. feature-augmentations Implementation of the augmentations feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants