Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE tooling (analysis server) implementation for enhanced enums #47865

Closed
17 of 25 tasks
Tracked by #47849
devoncarew opened this issue Dec 6, 2021 · 5 comments
Closed
17 of 25 tasks
Tracked by #47849

IDE tooling (analysis server) implementation for enhanced enums #47865

devoncarew opened this issue Dec 6, 2021 · 5 comments
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@devoncarew
Copy link
Member

devoncarew commented Dec 6, 2021

This is the analysis server work for the enhanced enums feature.

For addition information, see

The following is a list of the individual features that need to be considered.

  • Quick Assists
  • Closing Labels
  • Code Completion (scheglov)
  • documentSymbol
  • Quick Fixes (support for new features in existing fixes)
  • Quick Fixes (new fixes)
  • Flutter Outline (scheglov)
  • Code Folding
  • Hovers (scheglov)
  • Implemented Markers (scheglov)
  • Navigation (scheglov)
  • Occurrences (scheglov)
  • Organize Imports (brianwilkerson, NA)
  • Outline (scheglov)
  • Overrides Markers (scheglov)
  • Refactorings (scheglov)
  • Search - Find References (scheglov)
  • Search - Member Declarations (scheglov)
  • Search - Member References (scheglov)
  • Search - Top-level Declarations (scheglov, NA)
  • selectionRange
  • Semantic Highlights (scheglov)
  • signatureHelp
  • Sort Members (scheglov)
  • Type Hierarchy (scheglov)
@devoncarew devoncarew added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Dec 6, 2021
@scheglov scheglov added the P2 A bug or feature request we're likely to work on label Dec 7, 2021
@stereotype441
Copy link
Member

Note: in particular, code completion will have to be modified so that:

  • In an enum declaration, after the name of an enum constant, optional type arguments, and then a ., completion suggests the names of the enum's constructors
  • In an enum declaration, after a ;, completion suggests everything that it would suggest inside a class declaration

@jacob314
Copy link
Member

Fyi @pq for a prefer enums lint and quick fix that rewrites code that now could be an enum to enum.

@pq
Copy link
Member

pq commented Jan 24, 2022

See also: dart-lang/linter#3173.

@devoncarew devoncarew assigned bwilkerson and unassigned jacob314 Jan 27, 2022
@itsjustkevin
Copy link
Contributor

@bwilkerson is this feature work complete?

@bwilkerson
Copy link
Member

Yes. If there is any further work that needs to be done I'd consider it a bug and I'd want a separate issue for it. In general, I think it's reasonable to close issues like this one after a feature has shipped. We probably need to be better about keeping these issues up-to-date, because they're really only useful if they help us understand what work might be gating a release, but once the feature has shipped I don't think they have any ongoing value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

7 participants