Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web debugging support for enhanced enums #47863

Closed
Tracked by #47849
devoncarew opened this issue Dec 6, 2021 · 5 comments
Closed
Tracked by #47849

web debugging support for enhanced enums #47863

devoncarew opened this issue Dec 6, 2021 · 5 comments
Assignees
@Markzipan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. type-enhancement A request for a change that isn't a bug web-eval evaluation support on the web

Comments

@devoncarew
Copy link
Member

See #47849 for the main tracking issue.
@devoncarew devoncarew added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Dec 6, 2021
@devoncarew devoncarew mentioned this issue Dec 6, 2021
Closed
23 tasks
@srujzs srujzs added web-eval evaluation support on the web type-enhancement A request for a change that isn't a bug labels Dec 6, 2021
@devoncarew
Copy link
Member Author

cc @annagrin

@sigmundch
Copy link
Member

This is likely simply require adding a few tests for the debugger and expression evaluation. We expect the implementation to be entirely handled by the CFE lowering, though.

@annagrin
Copy link
Contributor

annagrin commented Jan 10, 2022 •
edited
Loading

The work required:

  • adding tests for new expressions in expression evaluation tests,
  • validating that completion of enums works in devtools

@Markzipan
Copy link
Contributor

Update: tests added in e68c3e8

@sigmundch
Copy link
Member

@Markzipan - I'm closing this assuming there is nothing more to do, but please reopen if I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Markzipan Markzipan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. type-enhancement A request for a change that isn't a bug web-eval evaluation support on the web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@devoncarew @sigmundch @Markzipan @annagrin @srujzs