Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js-interop check: warn that instance methods cannot be renamed #44210

Open
sigmundch opened this issue Nov 14, 2020 · 0 comments
Open

js-interop check: warn that instance methods cannot be renamed #44210

sigmundch opened this issue Nov 14, 2020 · 0 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-js-interop Issues that impact all js interop

Comments

@sigmundch
Copy link
Member

(creating a separate bug for checks mentioned in #32929 (comment))

We can warn that renaming instance methods is not supported. Today this means that instance method @JS declarations are unnecessary, so we can also warn about any use of them, but we can be a bit more lenient with benign annotations and only warn when there the rename is clearly the intent.
@sigmundch sigmundch added web-js-interop Issues that impact all js interop P2 A bug or feature request we're likely to work on area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-js-interop Issues that impact all js interop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sigmundch