Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for invalid library name is unclear #36270

Open
leonsenft opened this issue Mar 20, 2019 · 0 comments
Open

Error message for invalid library name is unclear #36270

leonsenft opened this issue Mar 20, 2019 · 0 comments
Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@leonsenft
Copy link

If a library name in a library directive contains an identifier that begins with a number, the resulting error message is unclear:

library foo.bar.123_baz.qux;
                ^^^^^^^^^^^

Expected to find ';'. [expected_token]

An error message that explains that a library identifier can't begin with a number would be more clear.

An AngularDart client encountered this issue due to their project being hosted under a directory whose name began with a number (which led to the AngularDart compiler emitting this library directive).

@kevmoo kevmoo added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Apr 3, 2019
@srawlins srawlins added the P3 A lower priority bug or feature request label Nov 25, 2020
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Nov 16, 2021
@srawlins srawlins added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants