Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis is too slow or infinite #24690

Closed
4 of 5 tasks
scheglov opened this issue Oct 22, 2015 · 5 comments
Closed
4 of 5 tasks

Analysis is too slow or infinite #24690

scheglov opened this issue Oct 22, 2015 · 5 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@scheglov
Copy link
Contributor

Our users report that there are lots of instances where the analyzer can't keep up with editing in order to provide error feedback, auto-complete, auto-imports, etc.

Sometimes restart helps, but often it falls into continuing analysis again.

Related issues:

@scheglov scheglov added P1 A high priority bug; for example, a single project is unusable or has many test failures area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Oct 22, 2015
@scheglov scheglov added this to the 1.13 milestone Oct 22, 2015
@pq
Copy link
Member

pq commented Oct 22, 2015

@pq is this something you observe too?

Yep. And eventually, after a bit of use, DPI seems to basically die altogether. The following exception is pretty reliably spewed in the logs.

NoSuchMethodError: method not found: 'getState'
Receiver: null
Arguments: [Instance of 'ResultDescriptorImpl']
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
#2      AnalysisContextImpl.computeResolvedCompilationUnitAsync. (package:analyzer/src/context/context.dart:657)
#3      PendingFuture.evaluate (package:analyzer/src/context/context.dart:2026)
#4      AnalysisContextImpl._evaluatePendingFutures (package:analyzer/src/context/context.dart:1520)
#5      AnalysisContextImpl.performAnalysisTask. (package:analyzer/src/context/context.dart:1101)
#6      _PerformanceTagImpl.makeCurrentWhile (package:analyzer/src/generated/utilities_general.dart:149)
#7      AnalysisContextImpl.performAnalysis... (show balloon)

@bwilkerson
Copy link
Member

Do you know whether the version of server you were running included this change (https://codereview.chromium.org/1408393007/)?

@pq
Copy link
Member

pq commented Oct 22, 2015

I don't think so. Looking at the version id:

1.13.0-edge.6c85fe785a85b1a907ce05f440dd08b2fd0fd994

I think my SDK is an earlier commit.

Rebuilding now and I'll keep you posted.

@sethladd
Copy link
Contributor

I've noticed Atom's Dart experience fails to keep up as well. I often need to backspace back to a previous . and then try code completion again. Or, I get a "this import is unknown" for a package that I've installed... but a re-analyze sources fixes it.

How do I tell if this is because "too slow or infinite", in order to help diagnose?

cc @devoncarew

@kevmoo kevmoo added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Oct 22, 2015
@bwilkerson
Copy link
Member

Given that everything required for 1.13 is complete, I'm closing this tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

5 participants