Skip to content

Commit ef8baa8

Browse files
rmacnak-googlermacnak-google
committed
Add test harness option for app snapshots with unoptimized code.
 ./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs Rename 'dart_product' runtime to 'dart_app'. Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation. Remove out-of-date scripts in tools/precompilation. R=fschneider@google.com Review URL: https://codereview.chromium.org/1992703005 .
1 parent 0a5ecc5 commit ef8baa8

22 files changed

+205
-141
lines changed

‎pkg/pkg.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ analyzer/test/src/task/strong/inferred_type_test: Crash # Issue 24485
267267
analyzer/test/src/task/strong_mode_test: Crash # Issue 24485
268268
analyzer/test/src/task/yaml_test: Crash # Issue 24485
269269

270-
[ $noopt || $runtime == dart_precompiled || $runtime == dart_product ]
270+
[ $noopt || $runtime == dart_precompiled || $runtime == dart_app ]
271271
*: SkipByDesign # The pkg test framework imports dart:mirrors.
272272

273273
[ $compiler == dart2js && $cps_ir && $checked ]

‎runtime/bin/main.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1232,7 +1232,7 @@ static void GeneratePrecompiledJITSnapshot() {
12321232
intptr_t instructions_blob_size = 0;
12331233
uint8_t* rodata_blob_buffer = NULL;
12341234
intptr_t rodata_blob_size = 0;
1235-
Dart_Handle result = Dart_CreatePrecompiledJITSnapshotBlob(
1235+
Dart_Handle result = Dart_CreateAppJITSnapshot(
12361236
&vm_isolate_buffer,
12371237
&vm_isolate_size,
12381238
&isolate_buffer,

‎runtime/include/dart_api.h

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2960,7 +2960,6 @@ DART_EXPORT Dart_Handle Dart_Precompile(
29602960

29612961
/**
29622962
* Creates a precompiled snapshot.
2963-
* - The VM must not have been started from a snapshot.
29642963
* - A root library must have been loaded.
29652964
* - Dart_Precompile must have been called.
29662965
*
@@ -2972,6 +2971,11 @@ DART_EXPORT Dart_Handle Dart_Precompile(
29722971
* The vm isolate snapshot, kInstructionsSnapshot and kDataSnapshot should be
29732972
* passed as arguments to Dart_Initialize. The isolate snapshot should be
29742973
* passed to Dart_CreateIsolate.
2974+
*
2975+
* The buffers are scope allocated and are only valid until the next call to
2976+
* Dart_ExitScope.
2977+
*
2978+
* \return A valid handle if no error occurs during the operation.
29752979
*/
29762980
DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotAssembly(
29772981
uint8_t** vm_isolate_snapshot_buffer,
@@ -3002,7 +3006,30 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotBlob(
30023006
DART_EXPORT Dart_Handle Dart_PrecompileJIT();
30033007

30043008

3005-
DART_EXPORT Dart_Handle Dart_CreatePrecompiledJITSnapshotBlob(
3009+
/**
3010+
* Creates a snapshot that caches unoptimized code and type feedback for faster
3011+
* startup and quicker warmup in a subsequent process.
3012+
*
3013+
* Outputs a snapshot in four pieces. The vm isolate snapshot,
3014+
* instructions_blob and rodata_blob should be passed as arguments to
3015+
* Dart_Initialize. The isolate snapshot should be passed to
3016+
* Dart_CreateIsolate. The instructions piece must be loaded with execute
3017+
* permissions; the other pieces may loaded as read-only.
3018+
*
3019+
* - Requires the VM to have been started with --load-deferred-eagerly.
3020+
* - Requires the VM to have not been started with --precompilation.
3021+
* - Not supported when targeting IA32.
3022+
* - The VM writing the snapshot and the VM reading the snapshot must be the
3023+
* same version, must be built in the same DEBUG/RELEASE/PRODUCT mode, must
3024+
* be targeting the same architecture, and must both be in checked mode or
3025+
* both in unchecked mode.
3026+
*
3027+
* The buffers are scope allocated and are only valid until the next call to
3028+
* Dart_ExitScope.
3029+
*
3030+
* \return A valid handle if no error occurs during the operation.
3031+
*/
3032+
DART_EXPORT Dart_Handle Dart_CreateAppJITSnapshot(
30063033
uint8_t** vm_isolate_snapshot_buffer,
30073034
intptr_t* vm_isolate_snapshot_size,
30083035
uint8_t** isolate_snapshot_buffer,

‎runtime/observatory/tests/service/service.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ coverage_test: Pass, Slow
4444
*: SkipByDesign
4545

4646
# Service protocol is not supported when running a full application snapshot.
47-
[ $runtime == dart_product ]
47+
[ $runtime == dart_app ]
4848
*: SkipByDesign
4949

5050
[ $compiler == dart2analyzer ]

‎runtime/tests/vm/vm.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ cc/StandaloneSnapshotSize: SkipByDesign # Imports dart:mirrors
103103
dart/inline_stack_frame_test: Pass, RuntimeError
104104
dart/optimized_stacktrace_test: Pass, RuntimeError
105105

106-
[ $runtime == dart_product || $runtime == dart_precompiled ]
106+
[ $runtime == dart_app || $runtime == dart_precompiled ]
107107
dart/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri
108108
dart/optimized_stacktrace_test: SkipByDesign # Requires line numbers
109109

‎runtime/vm/dart_api_impl.cc

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1463,7 +1463,7 @@ DART_EXPORT Dart_Handle Dart_CreateSnapshot(
14631463
API_TIMELINE_DURATION;
14641464
Isolate* I = T->isolate();
14651465
if (!FLAG_load_deferred_eagerly) {
1466-
return Dart_NewApiError(
1466+
return Api::NewError(
14671467
"Creating full snapshots requires --load_deferred_eagerly");
14681468
}
14691469
if (vm_isolate_snapshot_buffer != NULL &&
@@ -6131,10 +6131,13 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotBlob(
61316131
DART_EXPORT Dart_Handle Dart_Precompile(
61326132
Dart_QualifiedFunctionName entry_points[],
61336133
bool reset_fields) {
6134+
#if defined(TARGET_ARCH_IA32)
6135+
return Api::NewError("Precompilation is not supported on IA32.");
6136+
#else
61346137
API_TIMELINE_BEGIN_END;
61356138
DARTSCOPE(Thread::Current());
61366139
if (!FLAG_precompiled_mode) {
6137-
return Dart_NewApiError("Flag --precompilation was not specified.");
6140+
return Api::NewError("Flag --precompilation was not specified.");
61386141
}
61396142
Dart_Handle result = Api::CheckAndFinalizePendingClasses(T);
61406143
if (::Dart_IsError(result)) {
@@ -6147,6 +6150,7 @@ DART_EXPORT Dart_Handle Dart_Precompile(
61476150
return Api::NewHandle(T, error.raw());
61486151
}
61496152
return Api::Success();
6153+
#endif
61506154
}
61516155

61526156

@@ -6157,12 +6161,15 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotAssembly(
61576161
intptr_t* isolate_snapshot_size,
61586162
uint8_t** assembly_buffer,
61596163
intptr_t* assembly_size) {
6164+
#if defined(TARGET_ARCH_IA32)
6165+
return Api::NewError("Snapshots with code are not supported on IA32.");
6166+
#else
61606167
API_TIMELINE_DURATION;
61616168
DARTSCOPE(Thread::Current());
61626169
Isolate* I = T->isolate();
61636170
if (I->compilation_allowed()) {
6164-
return Dart_NewApiError("Isolate is not precompiled. "
6165-
"Did you forget to call Dart_Precompile?");
6171+
return Api::NewError("Isolate is not precompiled. "
6172+
"Did you forget to call Dart_Precompile?");
61666173
}
61676174
ASSERT(FLAG_load_deferred_eagerly);
61686175
if (vm_isolate_snapshot_buffer == NULL) {
@@ -6201,6 +6208,7 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotAssembly(
62016208
*assembly_size = instructions_writer.AssemblySize();
62026209

62036210
return Api::Success();
6211+
#endif
62046212
}
62056213

62066214

@@ -6213,12 +6221,15 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotBlob(
62136221
intptr_t* instructions_blob_size,
62146222
uint8_t** rodata_blob_buffer,
62156223
intptr_t* rodata_blob_size) {
6224+
#if defined(TARGET_ARCH_IA32)
6225+
return Api::NewError("Snapshots with code are not supported on IA32.");
6226+
#else
62166227
API_TIMELINE_DURATION;
62176228
DARTSCOPE(Thread::Current());
62186229
Isolate* I = T->isolate();
62196230
if (I->compilation_allowed()) {
6220-
return Dart_NewApiError("Isolate is not precompiled. "
6221-
"Did you forget to call Dart_Precompile?");
6231+
return Api::NewError("Isolate is not precompiled. "
6232+
"Did you forget to call Dart_Precompile?");
62226233
}
62236234
ASSERT(FLAG_load_deferred_eagerly);
62246235
if (vm_isolate_snapshot_buffer == NULL) {
@@ -6265,6 +6276,7 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledSnapshotBlob(
62656276
*rodata_blob_size = instructions_writer.RodataBlobSize();
62666277

62676278
return Api::Success();
6279+
#endif
62686280
}
62696281
#endif // DART_PRECOMPILER
62706282

@@ -6301,7 +6313,7 @@ DART_EXPORT Dart_Handle Dart_PrecompileJIT() {
63016313
}
63026314

63036315

6304-
DART_EXPORT Dart_Handle Dart_CreatePrecompiledJITSnapshotBlob(
6316+
DART_EXPORT Dart_Handle Dart_CreateAppJITSnapshot(
63056317
uint8_t** vm_isolate_snapshot_buffer,
63066318
intptr_t* vm_isolate_snapshot_size,
63076319
uint8_t** isolate_snapshot_buffer,
@@ -6310,11 +6322,14 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledJITSnapshotBlob(
63106322
intptr_t* instructions_blob_size,
63116323
uint8_t** rodata_blob_buffer,
63126324
intptr_t* rodata_blob_size) {
6325+
#if defined(TARGET_ARCH_IA32)
6326+
return Api::NewError("Snapshots with code are not supported on IA32.");
6327+
#else
63136328
API_TIMELINE_DURATION;
63146329
DARTSCOPE(Thread::Current());
63156330
Isolate* I = T->isolate();
63166331
if (!FLAG_load_deferred_eagerly) {
6317-
return Dart_NewApiError(
6332+
return Api::NewError(
63186333
"Creating full snapshots requires --load_deferred_eagerly");
63196334
}
63206335
if (vm_isolate_snapshot_buffer == NULL) {
@@ -6366,6 +6381,7 @@ DART_EXPORT Dart_Handle Dart_CreatePrecompiledJITSnapshotBlob(
63666381
*rodata_blob_size = instructions_writer.RodataBlobSize();
63676382

63686383
return Api::Success();
6384+
#endif
63696385
}
63706386

63716387

‎samples/samples.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,5 @@ sample_extension/test/sample_extension_test: Skip # Issue 14705
2828
[ $arch == simarm64 ]
2929
*: Skip
3030

31-
[ $noopt || $runtime == dart_precompiled || $runtime == dart_product ]
31+
[ $noopt || $runtime == dart_precompiled || $runtime == dart_app ]
3232
sample_extension: Skip # Platform.executable

‎tests/benchmark_smoke/benchmark_smoke.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
44

5-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
5+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) ]
66
*: Skip
77

88
[ $compiler == dart2js && $runtime == none ]

‎tests/co19/co19-runtime.status

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# BSD-style license that can be found in the LICENSE file.
44

55

6-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
6+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) ]
77

88
# Failures ok in tests below. VM moves super initializer to end of list.
99
Language/Classes/Constructors/Generative_Constructors/execution_t03: Fail, OK
@@ -43,7 +43,7 @@ LibTest/isolate/Isolate/spawn_A02_t02: RuntimeError # Dart issue 15617
4343
LibTest/core/Symbol/Symbol_A01_t03: RuntimeError # Issue 13596
4444
LibTest/core/Symbol/Symbol_A01_t05: RuntimeError # Issue 13596
4545

46-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
46+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) ]
4747
LibTest/typed_data/Float32x4/reciprocalSqrt_A01_t01: Pass, Fail # co19 issue 599
4848
LibTest/typed_data/Float32x4/reciprocal_A01_t01: Pass, Fail # co19 issue 599
4949
Language/Expressions/Instance_Creation/Const/abstract_class_t01: MissingCompileTimeError # Issue 22007
@@ -53,10 +53,10 @@ Language/Libraries_and_Scripts/Imports/invalid_uri_t02: Fail
5353
Language/Libraries_and_Scripts/Exports/invalid_uri_t02: Fail
5454
Language/Libraries_and_Scripts/Parts/syntax_t06: Fail
5555

56-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $mode == debug ]
56+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) && $mode == debug ]
5757
LibTest/core/List/List_class_A01_t02: Pass, Slow
5858

59-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && ($arch != x64 && $arch != simarm64 && $arch != arm64) ]
59+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) && ($arch != x64 && $arch != simarm64 && $arch != arm64) ]
6060
LibTest/core/int/operator_left_shift_A01_t02: Fail # co19 issue 129
6161

6262
[ ($compiler == none || $compiler == precompiler) && ($runtime == vm || $runtime == dart_precompiled) && ($arch == mips || $arch == arm64) ]
@@ -66,7 +66,7 @@ LibTest/core/List/List_class_A01_t02: Skip # co19 issue 673
6666
LibTest/collection/ListMixin/ListMixin_class_A01_t02: Skip # co19 issue 673
6767
LibTest/collection/ListBase/ListBase_class_A01_t02: Skip # co19 issue 673
6868

69-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && ($arch == simarm || $arch == simarmv6 || $arch == simarmv5te || $arch == simmips || $arch == simarm64) ]
69+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) && ($arch == simarm || $arch == simarmv6 || $arch == simarmv5te || $arch == simmips || $arch == simarm64) ]
7070
LibTest/core/Uri/Uri_A06_t03: Skip # Timeout
7171
LibTest/collection/ListMixin/ListMixin_class_A01_t01: Skip # Timeout
7272
LibTest/collection/ListBase/ListBase_class_A01_t01: Skip # Timeout
@@ -77,19 +77,19 @@ LibTest/collection/ListBase/ListBase_class_A01_t02: Skip # Timeout
7777
LibTest/collection/ListMixin/ListMixin_class_A01_t02: Pass, Slow
7878
LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Slow
7979

80-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
80+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) ]
8181
LibTest/isolate/Isolate/spawn_A02_t01: Skip # co19 issue 667
8282
LibTest/html/*: SkipByDesign # dart:html not supported on VM.
8383
LayoutTests/fast/*: SkipByDesign # DOM not supported on VM.
8484
WebPlatformTest/*: SkipByDesign # dart:html not supported on VM.
8585

86-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $mode == debug && $builder_tag == asan ]
86+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) && $mode == debug && $builder_tag == asan ]
8787
Language/Types/Interface_Types/subtype_t27: Skip # Issue 21174.
8888

89-
[ ($runtime == vm || $runtime == dart_product) && $arch == arm ]
89+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) && $arch == arm ]
9090
LibTest/typed_data/Float32x4/operator_multiplication_A01_t01: Fail # Dart issue 24416
9191

92-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
92+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) ]
9393
# co19 update Sep 29, 2015 (3ed795ea02e022ef19c77cf1b6095b7c8f5584d0)
9494
Language/Classes/Getters/type_object_t01: RuntimeError # Issue 23721
9595
Language/Classes/Getters/type_object_t02: RuntimeError # Issue 23721
@@ -127,7 +127,7 @@ Language/Mixins/declaring_constructor_t01: MissingCompileTimeError # co19 issue
127127
Language/Mixins/not_object_superclass_t01: MissingCompileTimeError # co19 issue 43 and 44
128128
Language/Mixins/reference_to_super_t01: MissingCompileTimeError # co19 issue 43 and 44
129129

130-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $checked ]
130+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) && $checked ]
131131
Language/Errors_and_Warnings/static_warning_t01: RuntimeError # co19 issue 45
132132
Language/Errors_and_Warnings/static_warning_t02: RuntimeError # co19 issue 45
133133
Language/Errors_and_Warnings/static_warning_t03: RuntimeError # co19 issue 45
@@ -138,14 +138,16 @@ Language/Errors_and_Warnings/static_warning_t06: RuntimeError # co19 issue 45
138138
[ $noopt || $compiler == precompiler || $mode == product ]
139139
Language/Metadata/*: SkipByDesign # Uses dart:mirrors
140140

141-
[ $runtime == dart_precompiled || $runtime == dart_product ]
141+
[ $runtime == dart_precompiled || $runtime == dart_app ]
142142
LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
143143

144144
[ $noopt || $compiler == precompiler ]
145145
LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout
146146
LibTest/collection/ListMixin/ListMixin_class_A01_t02: Pass, Timeout
147147
LibTest/core/Map/Map_class_A01_t04: Pass, Timeout
148148
LibTest/core/Uri/encodeQueryComponent_A01_t02: Pass, Timeout
149+
150+
[ $noopt || $compiler == precompiler || $compiler == dart2appjit ]
149151
Language/Mixins/Mixin_Application/error_t01: Pass
150152
Language/Mixins/Mixin_Application/error_t02: Pass
151153
Language/Mixins/declaring_constructor_t01: Pass

‎tests/corelib/corelib.status

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ string_from_environment2_test: Skip
1414
string_from_environment3_test: Skip
1515
string_from_environment_test: Skip
1616

17-
[ ($compiler == none || $compiler == precompiler || $compiler == dart2app) ]
17+
[ ($compiler == none || $compiler == precompiler || $compiler == dart2app || $compiler == dart2appjit) ]
1818
unicode_test: Fail # Bug 6706
1919
compare_to2_test: Fail # Bug 4018
2020

@@ -30,7 +30,7 @@ symbol_operator_test/03: Fail # bug 11669
3030
string_case_test/01: Fail # Bug 18061
3131

3232
# #void should be a valid symbol.
33-
[ $compiler == none || $compiler == precompiler || $compiler == dart2app || $compiler == dart2js ]
33+
[ $compiler == none || $compiler == precompiler || $compiler == dart2app || $compiler == dart2appjit || $compiler == dart2js ]
3434
symbol_reserved_word_test/02: CompileTimeError # bug 20191
3535
symbol_reserved_word_test/05: CompileTimeError # bug 20191
3636

@@ -57,7 +57,7 @@ integer_to_radix_string_test: RuntimeError # issue 22045
5757
int_modulo_arith_test/bignum: RuntimeError # No bigints.
5858
int_modulo_arith_test/modPow: RuntimeError # No bigints.
5959

60-
[ ($compiler == none || $compiler == precompiler || $compiler == dart2app) && $runtime != dartium && $runtime != drt ]
60+
[ ($compiler == none || $compiler == precompiler || $compiler == dart2app || $compiler == dart2appjit) && $runtime != dartium && $runtime != drt ]
6161
symbol_test/02: MissingCompileTimeError # bug 11669
6262
symbol_test/03: MissingCompileTimeError # bug 11669
6363

@@ -154,10 +154,10 @@ stopwatch_test: Skip # Flaky test due to expected performance behaviour.
154154
# The regexp tests are not verified to work on non d8/vm platforms yet.
155155
regexp/*: Skip
156156

157-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
157+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) ]
158158
regexp/global_test: Skip # Timeout. Issue 21709 and 21708
159159

160-
[ $runtime != vm && $runtime != dart_precompiled && $runtime != dart_product && $compiler != dart2analyzer]
160+
[ $runtime != vm && $runtime != dart_precompiled && $runtime != dart_app && $compiler != dart2analyzer]
161161
data_resource_test: RuntimeError # Issue 23825 (not implemented yet).
162162
file_resource_test: Skip, OK # VM specific test, uses dart:io.
163163
http_resource_test: Skip, OK # VM specific test, uses dart:io.
@@ -168,7 +168,7 @@ package_resource_test: RuntimeError # Issue 23825 (not implemented yet).
168168
[ $mode == debug ]
169169
regexp/pcre_test: Pass, Slow # Timeout. Issue 22008
170170

171-
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $arch == simarmv5te ]
171+
[ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_app) && $arch == simarmv5te ]
172172
int_parse_radix_test/*: Pass, Slow
173173
big_integer_parsed_mul_div_vm_test: Pass, Slow
174174

@@ -201,7 +201,7 @@ big_integer_huge_mul_vm_test: Pass, Timeout # --no_intrinsify
201201
big_integer_parsed_mul_div_vm_test: Pass, Timeout # --no_intrinsify
202202
int_parse_radix_test: Pass, Timeout # --no_intrinsify
203203

204-
[ $compiler == precompiler || $runtime == dart_product ]
204+
[ $compiler == precompiler || $runtime == dart_app ]
205205
data_resource_test: Skip # Resolve URI not supported yet in product mode.
206206
package_resource_test: Skip # Resolve URI not supported yet in product mode.
207207
file_resource_test: Skip # Resolve URI not supported yet in product mode.

‎tests/html/html.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ websql_test/supported: Fail
364364

365365
# 'html' tests import the HTML library, so they only make sense in
366366
# a browser environment.
367-
[ $runtime == vm || $runtime == dart_precompiled || $runtime == dart_product ]
367+
[ $runtime == vm || $runtime == dart_precompiled || $runtime == dart_app ]
368368
*: Skip
369369

370370
[ $compiler == dart2js && ($runtime == drt || $runtime == ff) ]

0 commit comments

Comments
 (0)