Fix prefer_equal_for_default_values in analyzer.

Change-Id: Ia72a2ac31d6cf6329c78baad6954ac9595a6c45a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/analyzer/analysis_options.yaml

@@ -13,9 +13,6 @@ analyzer:
     avoid_return_types_on_setters: ignore
     empty_catches: ignore
     prefer_iterable_wheretype: ignore
-    # TODO(srawlins): At the time of writing, 230 violations in lib/. The fix
-    # is mechanical, via `dartfmt --fix-named-default-separator`.
-    prefer_equal_for_default_values: ignore
     # TODO(srawlins): At the time of writing, 2600 violations in lib/. The fix
     # is mechanical, via `dartfmt --fix-doc-comments`, but not worth the churn
     # today.

pkg/analyzer/lib/analyzer.dart

@@ -49,8 +49,8 @@ export 'package:analyzer/src/generated/utilities_dart.dart';
 @Deprecated('Please use parseString instead')
 CompilationUnit parseCompilationUnit(String contents,
     {String name,
-    bool suppressErrors: false,
-    bool parseFunctionBodies: true,
+    bool suppressErrors = false,
+    bool parseFunctionBodies = true,
     FeatureSet featureSet}) {
   // TODO(paulberry): make featureSet a required parameter
   featureSet ??= FeatureSet.fromEnableFlags([]);
@@ -74,8 +74,8 @@ CompilationUnit parseCompilationUnit(String contents,
 /// callers that don't require function bodies should simply ignore them.
 @Deprecated('Please use parseFile2 instead')
 CompilationUnit parseDartFile(String path,
-    {bool suppressErrors: false,
-    bool parseFunctionBodies: true,
+    {bool suppressErrors = false,
+    bool parseFunctionBodies = true,
     FeatureSet featureSet}) {
   // TODO(paulberry): Make featureSet a required parameter
   featureSet ??= FeatureSet.fromEnableFlags([]);
@@ -115,7 +115,7 @@ CompilationUnit parseDartFile(String path,
 /// directives should simply ignore the rest of the parse result.
 @Deprecated('Please use parseString instead')
 CompilationUnit parseDirectives(String contents,
-    {String name, bool suppressErrors: false, FeatureSet featureSet}) {
+    {String name, bool suppressErrors = false, FeatureSet featureSet}) {
   // TODO(paulberry): make featureSet a required parameter.
   featureSet ??= FeatureSet.fromEnableFlags([]);
   var source = new StringSource(contents, name);
@@ -141,7 +141,7 @@ String stringLiteralToString(StringLiteral literal) {
 
 CompilationUnit _parseSource(
     String contents, Source source, FeatureSet featureSet,
-    {bool suppressErrors: false, bool parseFunctionBodies: true}) {
+    {bool suppressErrors = false, bool parseFunctionBodies = true}) {
   var reader = new CharSequenceReader(contents);
   var errorCollector = new _ErrorCollector();
   var scanner = new Scanner(source, reader, errorCollector)

pkg/analyzer/lib/dart/analysis/context_locator.dart

@@ -38,7 +38,7 @@ abstract class ContextLocator {
   @deprecated
   List<AnalysisContext> locateContexts(
       {@required List<String> includedPaths,
-      List<String> excludedPaths: const <String>[],
+      List<String> excludedPaths = const <String>[],
       String optionsFile,
       String packagesFile,
       String sdkPath});

pkg/analyzer/lib/dart/analysis/utilities.dart

@@ -43,7 +43,7 @@ ParseStringResult parseFile(
     {@required String path,
     ResourceProvider resourceProvider,
     @required FeatureSet featureSet,
-    bool throwIfDiagnostics: true}) {
+    bool throwIfDiagnostics = true}) {
   if (featureSet == null) {
     throw ArgumentError('A non-null feature set must be provided.');
   }
@@ -81,7 +81,7 @@ ParseStringResult parseFile2(
     {@required String path,
     ResourceProvider resourceProvider,
     @required FeatureSet featureSet,
-    bool throwIfDiagnostics: true}) {
+    bool throwIfDiagnostics = true}) {
   return parseFile(
       path: path,
       resourceProvider: resourceProvider,
@@ -110,7 +110,7 @@ ParseStringResult parseString(
     {@required String content,
     FeatureSet featureSet,
     String path,
-    bool throwIfDiagnostics: true}) {
+    bool throwIfDiagnostics = true}) {
   featureSet ??= FeatureSet.fromEnableFlags([]);
   var source = StringSource(content, path);
   var reader = CharSequenceReader(content);

pkg/analyzer/lib/dart/ast/ast_factory.dart

@@ -826,7 +826,7 @@ abstract class AstFactory {
       @required SimpleIdentifier identifier});
 
   /// Returns a newly created identifier.
-  SimpleIdentifier simpleIdentifier(Token token, {bool isDeclaration: false});
+  SimpleIdentifier simpleIdentifier(Token token, {bool isDeclaration = false});
 
   /// Returns a newly created simple string literal.
   SimpleStringLiteral simpleStringLiteral(Token literal, String value);

pkg/analyzer/lib/dart/element/type.dart

@@ -353,7 +353,7 @@ abstract class InterfaceType implements ParameterizedType {
   /// The [library] determines if a private member name is visible, and does not
   /// need to be supplied for public names.
   PropertyAccessorElement lookUpInheritedGetter(String name,
-      {LibraryElement library, bool thisType: true});
+      {LibraryElement library, bool thisType = true});
 
   /// Look up the member with the given [name] in this type and all extended
   /// and mixed in classes, starting from this type. If the search fails,
@@ -377,7 +377,7 @@ abstract class InterfaceType implements ParameterizedType {
   /// The [library] determines if a private member name is visible, and does not
   /// need to be supplied for public names.
   MethodElement lookUpInheritedMethod(String name,
-      {LibraryElement library, bool thisType: true});
+      {LibraryElement library, bool thisType = true});
 
   /// Look up the member with the given [name] in this type and all extended
   /// and mixed in classes, and by default including [thisType]. If the search
@@ -389,7 +389,7 @@ abstract class InterfaceType implements ParameterizedType {
   /// The [library] determines if a private member name is visible, and does not
   /// need to be supplied for public names.
   PropertyAccessorElement lookUpInheritedSetter(String name,
-      {LibraryElement library, bool thisType: true});
+      {LibraryElement library, bool thisType = true});
 
   /// Return the element representing the method that results from looking up
   /// the method with the given [name] in this class with respect to the given

pkg/analyzer/lib/file_system/memory_file_system.dart

@@ -29,7 +29,7 @@ class MemoryResourceProvider implements ResourceProvider {
   final pathos.Context _pathContext;
 
   MemoryResourceProvider(
-      {pathos.Context context, @deprecated bool isWindows: false})
+      {pathos.Context context, @deprecated bool isWindows = false})
       : _pathContext = (context ??= pathos.style == pathos.Style.windows
             // On Windows, ensure that the current drive matches
             // the drive inserted by MemoryResourceProvider.convertPath

pkg/analyzer/lib/src/analysis_options/analysis_options_provider.dart

@@ -27,7 +27,7 @@ class AnalysisOptionsProvider {
   /// Recursively merge options referenced by an include directive
   /// and remove the include directive from the resulting options map.
   /// Return an empty options map if the file does not exist.
-  YamlMap getOptions(Folder root, {bool crawlUp: false}) {
+  YamlMap getOptions(Folder root, {bool crawlUp = false}) {
     File optionsFile = getOptionsFile(root, crawlUp: crawlUp);
     if (optionsFile == null) {
       return new YamlMap();
@@ -40,7 +40,7 @@ class AnalysisOptionsProvider {
   ///
   /// The given [root] directory will be searched first. If no file is found and
   /// if [crawlUp] is `true`, then enclosing directories will be searched.
-  File getOptionsFile(Folder root, {bool crawlUp: false}) {
+  File getOptionsFile(Folder root, {bool crawlUp = false}) {
     Resource resource;
     for (Folder folder = root; folder != null; folder = folder.parent) {
       resource = folder.getChild(AnalysisEngine.ANALYSIS_OPTIONS_FILE);

pkg/analyzer/lib/src/analysis_options/error/option_codes.dart

@@ -60,7 +60,7 @@ class AnalysisOptionsHintCode extends ErrorCode {
       const AnalysisOptionsHintCode(
           'DEPRECATED_ANALYSIS_OPTIONS_FILE_NAME',
           "The name of the analysis options file {0} is deprecated;"
-          " consider renaming it to analysis_options.yaml.");
+              " consider renaming it to analysis_options.yaml.");
 
   /**
    * An error code indicating that the enablePreviewDart2 setting is deprecated.
@@ -192,7 +192,7 @@ class AnalysisOptionsWarningCode extends ErrorCode {
       const AnalysisOptionsWarningCode(
           'UNSUPPORTED_OPTION_WITH_LEGAL_VALUE',
           "The option '{1}' isn't supported by '{0}'. "
-          "Try using the only supported option: '{2}'.");
+              "Try using the only supported option: '{2}'.");
 
   /**
    * An error code indicating that a plugin is being configured with an

pkg/analyzer/lib/src/command_line/arguments.dart

@@ -140,7 +140,8 @@ DartSdkManager createDartSdkManager(
  * TODO(danrubel) Update DDC to support all the options defined in this method
  * then remove the [ddc] named argument from this method.
  */
-void defineAnalysisArguments(ArgParser parser, {bool hide: true, ddc: false}) {
+void defineAnalysisArguments(ArgParser parser,
+    {bool hide = true, ddc = false}) {
   parser.addOption(sdkPathOption,
       help: 'The path to the Dart SDK.', hide: ddc && hide);
   parser.addOption(analysisOptionsFileOption,