[vm/kernel] Preserve strong mode types in async transformation

Async transformation uses dynamic variables in few places (e.g.
for temporaries and for incomming arguments) - which creates
not strongly typed AST with method invocations having dynamic
receivers and non-null interface targets at the same time.

To maintain strong typedness of the AST we insert unsafeCast
when accessing the temporaries.

Bug: #34463
Change-Id: I11e38c128645ebc8acb0c982a80fe4c5c4036673
Reviewed-on: https://dart-review.googlesource.com/75000
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

Author: mraleph

pkg/front_end/testcases/async_function.dart.direct.transformed.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:async" as asy;
 import "dart:core" as core;
+import "dart:_internal" as _in;
 
 static field core::List<core::String> stringList = <dynamic>["bar"];
 static method asyncString() → asy::Future<core::String> /* originally async */ {
@@ -118,7 +119,7 @@ static method asyncStarString() → asy::Stream<core::String> /* originally asyn
           else
             [yield] null;
           [yield] let dynamic #t1 = asy::_awaitHelper(self::asyncString(), :async_op_then, :async_op_error, :async_op) in null;
-          if(:controller.{asy::_AsyncStarStreamController::add}(:result))
+          if(:controller.{asy::_AsyncStarStreamController::add}(_in::unsafeCast<core::String>(:result)))
             return null;
           else
             [yield] null;
@@ -187,7 +188,7 @@ static method main() → dynamic /* originally async */ {
       #L5:
       {
         [yield] let dynamic #t2 = asy::_awaitHelper(self::asyncString(), :async_op_then, :async_op_error, :async_op) in null;
-        core::String str = :result;
+        core::String str = _in::unsafeCast<core::String>(:result);
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;

pkg/front_end/testcases/async_nested.dart.direct.transformed.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:core" as core;
 import "dart:async" as asy;
+import "dart:_internal" as _in;
 
 class Node extends core::Object {
   final field core::List<self::Node> nested;
@@ -43,7 +44,7 @@ static method main() → void /* originally async */ {
         [yield] let dynamic #t9 = asy::_awaitHelper(asy::Future::value<dynamic>(new self::Node::•("3", <dynamic>[:result])), :async_op_then, :async_op_error, :async_op) in null;
         :async_temporary_0 = :result;
         [yield] let dynamic #t10 = asy::_awaitHelper(asy::Future::value<dynamic>(new self::Node::•("10", <dynamic>[])), :async_op_then, :async_op_error, :async_op) in null;
-        self::Node node = new self::Node::•("1", <dynamic>[:async_temporary_2, :async_temporary_0, :result]);
+        self::Node node = new self::Node::•("1", <dynamic>[_in::unsafeCast<self::Node>(:async_temporary_2), :async_temporary_0, :result]);
         core::String actual = node.toSimpleString();
         core::print(actual);
         if(!actual.==(expected)) {

pkg/front_end/testcases/async_nested.dart.strong.transformed.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:core" as core;
 import "dart:async" as asy;
+import "dart:_internal" as _in;
 
 class Node extends core::Object {
   final field core::List<self::Node> nested;
@@ -34,16 +35,16 @@ static method main() → void /* originally async */ {
         core::String expected = "1 2 3 4 5 6 7 8 9 10";
         :async_temporary_2 = new self::Node::•("2", <self::Node>[]);
         [yield] let dynamic #t4 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("7", <self::Node>[])), :async_op_then, :async_op_error, :async_op) in null;
-        [yield] let dynamic #t5 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("6", <self::Node>[:result])), :async_op_then, :async_op_error, :async_op) in null;
+        [yield] let dynamic #t5 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("6", <self::Node>[_in::unsafeCast<self::Node>(:result)])), :async_op_then, :async_op_error, :async_op) in null;
         :async_temporary_1 = :result;
         [yield] let dynamic #t6 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("8", <self::Node>[])), :async_op_then, :async_op_error, :async_op) in null;
         :async_temporary_0 = :result;
         [yield] let dynamic #t7 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("9", <self::Node>[])), :async_op_then, :async_op_error, :async_op) in null;
-        [yield] let dynamic #t8 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("4", <self::Node>[new self::Node::•("5", <self::Node>[:async_temporary_1, :async_temporary_0, :result])])), :async_op_then, :async_op_error, :async_op) in null;
-        [yield] let dynamic #t9 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("3", <self::Node>[:result])), :async_op_then, :async_op_error, :async_op) in null;
+        [yield] let dynamic #t8 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("4", <self::Node>[new self::Node::•("5", <self::Node>[_in::unsafeCast<self::Node>(:async_temporary_1), _in::unsafeCast<self::Node>(:async_temporary_0), _in::unsafeCast<self::Node>(:result)])])), :async_op_then, :async_op_error, :async_op) in null;
+        [yield] let dynamic #t9 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("3", <self::Node>[_in::unsafeCast<self::Node>(:result)])), :async_op_then, :async_op_error, :async_op) in null;
         :async_temporary_0 = :result;
         [yield] let dynamic #t10 = asy::_awaitHelper(asy::Future::value<self::Node>(new self::Node::•("10", <self::Node>[])), :async_op_then, :async_op_error, :async_op) in null;
-        self::Node node = new self::Node::•("1", <self::Node>[:async_temporary_2, :async_temporary_0, :result]);
+        self::Node node = new self::Node::•("1", <self::Node>[_in::unsafeCast<self::Node>(:async_temporary_2), _in::unsafeCast<self::Node>(:async_temporary_0), _in::unsafeCast<self::Node>(:result)]);
         core::String actual = node.{self::Node::toSimpleString}() as{TypeError} core::String;
         core::print(actual);
         if(!actual.{core::String::==}(expected)) {

pkg/front_end/testcases/await.dart.direct.transformed.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:async" as asy;
 import "dart:core" as core;
+import "dart:_internal" as _in;
 
 static method main() → dynamic /* originally async */ {
   final asy::Completer<dynamic> :async_completer = asy::Completer::sync<dynamic>();
@@ -17,7 +18,7 @@ static method main() → dynamic /* originally async */ {
       #L1:
       {
         [yield] let dynamic #t1 = asy::_awaitHelper("Hello, World!", :async_op_then, :async_op_error, :async_op) in null;
-        core::print(:result);
+        core::print(_in::unsafeCast<core::String>(:result));
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;

pkg/front_end/testcases/bug33206.dart.direct.transformed.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:core" as core;
 import "dart:async" as asy;
+import "dart:_internal" as _in;
 
 class X extends core::Object {
   final field dynamic x;
@@ -89,10 +90,10 @@ static method foo() → asy::Future<self::X> /* originally async */ {
       {
         final dynamic #t1 = new self::Y::•();
         [yield] let dynamic #t2 = asy::_awaitHelper(self::f1(), :async_op_then, :async_op_error, :async_op) in null;
-        final dynamic #t3 = #t1.f(:result);
+        final dynamic #t3 = #t1.f(_in::unsafeCast<core::List<core::Object>>(:result));
         final dynamic #t4 = #t1.f(self::f2());
         [yield] let dynamic #t5 = asy::_awaitHelper(self::f3(), :async_op_then, :async_op_error, :async_op) in null;
-        :return_value = new self::X::•(#t1, :result);
+        :return_value = new self::X::•(#t1, _in::unsafeCast<core::Object>(:result));
         break #L3;
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
@@ -121,7 +122,7 @@ static method main() → asy::Future<void> /* originally async */ {
       #L4:
       {
         [yield] let dynamic #t6 = asy::_awaitHelper(self::foo(), :async_op_then, :async_op_error, :async_op) in null;
-        core::print(:result);
+        core::print(_in::unsafeCast<self::X>(:result));
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;

pkg/front_end/testcases/bug33206.dart.strong.transformed.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:core" as core;
 import "dart:async" as asy;
+import "dart:_internal" as _in;
 
 class X extends core::Object {
   final field dynamic x;
@@ -89,10 +90,10 @@ static method foo() → asy::Future<self::X> /* originally async */ {
       {
         final self::Y #t1 = new self::Y::•();
         [yield] let dynamic #t2 = asy::_awaitHelper(self::f1(), :async_op_then, :async_op_error, :async_op) in null;
-        final dynamic #t3 = #t1.{self::Y::f}(:result);
+        final dynamic #t3 = #t1.{self::Y::f}(_in::unsafeCast<core::List<core::Object>>(:result));
         final dynamic #t4 = #t1.{self::Y::f}(self::f2());
         [yield] let dynamic #t5 = asy::_awaitHelper(self::f3(), :async_op_then, :async_op_error, :async_op) in null;
-        :return_value = new self::X::•(#t1, :result);
+        :return_value = new self::X::•(#t1, _in::unsafeCast<core::Object>(:result));
         break #L3;
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
@@ -121,7 +122,7 @@ static method main() → asy::Future<void> /* originally async */ {
       #L4:
       {
         [yield] let dynamic #t6 = asy::_awaitHelper(self::foo(), :async_op_then, :async_op_error, :async_op) in null;
-        core::print(:result);
+        core::print(_in::unsafeCast<self::X>(:result));
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;

pkg/front_end/testcases/inference/async_await.dart.direct.transformed.expect

@@ -2,6 +2,7 @@ library test;
 import self as self;
 import "dart:core" as core;
 import "dart:async" as asy;
+import "dart:_internal" as _in;
 
 abstract class MyFuture extends core::Object implements asy::Future<core::int> {
   synthetic constructor •() → void
@@ -302,25 +303,25 @@ static method test() → void /* originally async */ {
           return :async_completer.{asy::Completer::future};
         }
         [yield] let dynamic #t1 = asy::_awaitHelper(x0, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y0 = :result;
+        dynamic y0 = _in::unsafeCast<core::int>(:result);
         [yield] let dynamic #t2 = asy::_awaitHelper(x1, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y1 = :result;
+        dynamic y1 = _in::unsafeCast<core::int>(:result);
         [yield] let dynamic #t3 = asy::_awaitHelper(x2, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y2 = :result;
+        dynamic y2 = _in::unsafeCast<asy::Future<core::int>>(:result);
         [yield] let dynamic #t4 = asy::_awaitHelper(x3, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y3 = :result;
+        dynamic y3 = _in::unsafeCast<asy::FutureOr<core::int>>(:result);
         [yield] let dynamic #t5 = asy::_awaitHelper(x4, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y4 = :result;
+        dynamic y4 = _in::unsafeCast<self::MyFuture>(:result);
         [yield] let dynamic #t6 = asy::_awaitHelper(x5, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y5 = :result;
+        dynamic y5 = _in::unsafeCast<core::int>(:result);
         [yield] let dynamic #t7 = asy::_awaitHelper(x6, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y6 = :result;
+        dynamic y6 = _in::unsafeCast<asy::Future<core::int>>(:result);
         [yield] let dynamic #t8 = asy::_awaitHelper(x7, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y7 = :result;
+        dynamic y7 = _in::unsafeCast<asy::FutureOr<core::int>>(:result);
         [yield] let dynamic #t9 = asy::_awaitHelper(x8, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y8 = :result;
+        dynamic y8 = _in::unsafeCast<self::MyFuture>(:result);
         [yield] let dynamic #t10 = asy::_awaitHelper(x9, :async_op_then, :async_op_error, :async_op) in null;
-        dynamic y9 = :result;
+        dynamic y9 = _in::unsafeCast<core::int>(:result);
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;

pkg/front_end/testcases/inference/async_await.dart.strong.transformed.expect

@@ -2,6 +2,7 @@ library test;
 import self as self;
 import "dart:core" as core;
 import "dart:async" as asy;
+import "dart:_internal" as _in;
 
 abstract class MyFuture extends core::Object implements asy::Future<core::int> {
   synthetic constructor •() → void
@@ -302,25 +303,25 @@ static method test() → void /* originally async */ {
           return :async_completer.{asy::Completer::future};
         }
         [yield] let dynamic #t1 = asy::_awaitHelper(x0, :async_op_then, :async_op_error, :async_op) in null;
-        core::int y0 = :result;
+        core::int y0 = _in::unsafeCast<core::int>(:result);
         [yield] let dynamic #t2 = asy::_awaitHelper(x1, :async_op_then, :async_op_error, :async_op) in null;
-        core::int y1 = :result;
+        core::int y1 = _in::unsafeCast<core::int>(:result);
         [yield] let dynamic #t3 = asy::_awaitHelper(x2, :async_op_then, :async_op_error, :async_op) in null;
-        asy::Future<core::int> y2 = :result;
+        asy::Future<core::int> y2 = _in::unsafeCast<asy::Future<core::int>>(:result);
         [yield] let dynamic #t4 = asy::_awaitHelper(x3, :async_op_then, :async_op_error, :async_op) in null;
-        asy::FutureOr<core::int> y3 = :result;
+        asy::FutureOr<core::int> y3 = _in::unsafeCast<asy::FutureOr<core::int>>(:result);
         [yield] let dynamic #t5 = asy::_awaitHelper(x4, :async_op_then, :async_op_error, :async_op) in null;
-        self::MyFuture y4 = :result;
+        self::MyFuture y4 = _in::unsafeCast<self::MyFuture>(:result);
         [yield] let dynamic #t6 = asy::_awaitHelper(x5, :async_op_then, :async_op_error, :async_op) in null;
-        core::int y5 = :result;
+        core::int y5 = _in::unsafeCast<core::int>(:result);
         [yield] let dynamic #t7 = asy::_awaitHelper(x6, :async_op_then, :async_op_error, :async_op) in null;
-        asy::Future<core::int> y6 = :result;
+        asy::Future<core::int> y6 = _in::unsafeCast<asy::Future<core::int>>(:result);
         [yield] let dynamic #t8 = asy::_awaitHelper(x7, :async_op_then, :async_op_error, :async_op) in null;
-        asy::FutureOr<core::int> y7 = :result;
+        asy::FutureOr<core::int> y7 = _in::unsafeCast<asy::FutureOr<core::int>>(:result);
         [yield] let dynamic #t9 = asy::_awaitHelper(x8, :async_op_then, :async_op_error, :async_op) in null;
-        self::MyFuture y8 = :result;
+        self::MyFuture y8 = _in::unsafeCast<self::MyFuture>(:result);
         [yield] let dynamic #t10 = asy::_awaitHelper(x9, :async_op_then, :async_op_error, :async_op) in null;
-        core::int y9 = :result;
+        core::int y9 = _in::unsafeCast<core::int>(:result);
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;

pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async.dart.strong.transformed.expect

@@ -2,6 +2,7 @@ library test;
 import self as self;
 import "dart:async" as asy;
 import "dart:core" as core;
+import "dart:_internal" as _in;
 
 static method main() → dynamic /* originally async */ {
   final asy::Completer<dynamic> :async_completer = asy::Completer::sync<dynamic>();
@@ -46,7 +47,7 @@ static method main() → dynamic /* originally async */ {
         asy::Future<dynamic> y = f.call();
         asy::Future<core::String> z = f.call();
         [yield] let dynamic #t1 = asy::_awaitHelper(f.call(), :async_op_then, :async_op_error, :async_op) in null;
-        core::String s = :result;
+        core::String s = _in::unsafeCast<core::Null>(:result);
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;

pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async_star.dart.strong.transformed.expect

@@ -2,6 +2,7 @@ library test;
 import self as self;
 import "dart:async" as asy;
 import "dart:core" as core;
+import "dart:_internal" as _in;
 
 static method main() → dynamic /* originally async */ {
   final asy::Completer<dynamic> :async_completer = asy::Completer::sync<dynamic>();
@@ -54,7 +55,7 @@ static method main() → dynamic /* originally async */ {
         asy::Stream<dynamic> y = f.call();
         asy::Stream<core::String> z = f.call();
         [yield] let dynamic #t1 = asy::_awaitHelper(f.call().{asy::Stream::first}, :async_op_then, :async_op_error, :async_op) in null;
-        core::String s = :result;
+        core::String s = _in::unsafeCast<core::Null>(:result);
       }
       asy::_completeOnAsyncReturn(:async_completer, :return_value);
       return;