Skip to content

Commit ec519c3

Browse files
alexmarkovcommit-bot@chromium.org
authored andcommitted
[vm/aot] Disable bytecode in AOT compilation pipeline
This is needed for the next D27 release. Change-Id: I199ac701cb140dc84bb723d232c1b408088b1fe2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124469 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
1 parent f4780a6 commit ec519c3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/frontend_server/lib/frontend_server.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ ArgParser argParser = ArgParser(allowTrailingOptions: true)
133133
..addFlag('track-widget-creation',
134134
help: 'Run a kernel transformer to track creation locations for widgets.',
135135
defaultsTo: false)
136-
..addFlag('gen-bytecode', help: 'Generate bytecode', defaultsTo: null)
136+
..addFlag('gen-bytecode', help: 'Generate bytecode', defaultsTo: false)
137137
..addMultiOption('bytecode-options',
138138
help: 'Specify options for bytecode generation:',
139139
valueHelp: 'opt1,opt2,...',
@@ -380,7 +380,7 @@ class FrontendCompiler implements CompilerInterface {
380380
}
381381
}
382382

383-
compilerOptions.bytecode = options['gen-bytecode'] ?? options['aot'];
383+
compilerOptions.bytecode = options['gen-bytecode'];
384384
final BytecodeOptions bytecodeOptions = BytecodeOptions(
385385
enableAsserts: options['enable-asserts'],
386386
emitSourceFiles: options['embed-source-text'],

pkg/vm/lib/kernel_front_end.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ void declareCompilerOptions(ArgParser args) {
106106
help:
107107
'Split resulting kernel file into multiple files (one per package).',
108108
defaultsTo: false);
109-
args.addFlag('gen-bytecode', help: 'Generate bytecode', defaultsTo: null);
109+
args.addFlag('gen-bytecode', help: 'Generate bytecode', defaultsTo: false);
110110
args.addMultiOption('bytecode-options',
111111
help: 'Specify options for bytecode generation:',
112112
valueHelp: 'opt1,opt2,...',
@@ -157,7 +157,7 @@ Future<int> runCompiler(ArgResults options, String usage) async {
157157
final bool tfa = options['tfa'];
158158
final bool linkPlatform = options['link-platform'];
159159
final bool embedSources = options['embed-sources'];
160-
final bool genBytecode = options['gen-bytecode'] ?? aot;
160+
final bool genBytecode = options['gen-bytecode'];
161161
final bool dropAST = options['drop-ast'];
162162
final bool enableAsserts = options['enable-asserts'];
163163
final bool useProtobufTreeShaker = options['protobuf-tree-shaker'];

0 commit comments

Comments
 (0)