linter: Remove deprecated traverseNodesInDFS method

Fixes https://github.com/dart-lang/linter/issues/3745

Change-Id: Icf92f66be7b3e86b731316c2a7702da842f3f9ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354660
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>

Author: srawlins

pkg/linter/lib/src/extensions.dart

@@ -61,34 +61,6 @@ extension AstNodeExtension on AstNode {
     var element = parent.declaredElement;
     return element != null && element.hasInternal;
   }
-
-  /// Builds the list resulting from traversing the node in DFS and does not
-  /// include the node itself.
-  ///
-  /// It excludes the nodes for which the [excludeCriteria] returns true. If
-  /// [excludeCriteria] is not provided, all nodes are included.
-  @Deprecated(
-      'This approach is slow and slated for removal. Traversal via a standard visitor is preferred.')
-  Iterable<AstNode> traverseNodesInDFS({AstNodePredicate? excludeCriteria}) {
-    var nodes = <AstNode>{};
-    var nodesToVisit = List.of(childNodes);
-    if (excludeCriteria == null) {
-      while (nodesToVisit.isNotEmpty) {
-        var node = nodesToVisit.removeAt(0);
-        nodes.add(node);
-        nodesToVisit.insertAll(0, node.childNodes);
-      }
-    } else {
-      while (nodesToVisit.isNotEmpty) {
-        var node = nodesToVisit.removeAt(0);
-        if (excludeCriteria(node)) continue;
-        nodes.add(node);
-        nodesToVisit.insertAll(0, node.childNodes);
-      }
-    }
-
-    return nodes;
-  }
 }
 
 extension AstNodeNullableExtension on AstNode? {

pkg/linter/lib/src/util/dart_type_utilities.dart

@@ -237,11 +237,6 @@ class DartTypeUtilities {
   static bool matchesArgumentsWithParameters(NodeList<Expression> arguments,
           NodeList<FormalParameter> parameters) =>
       argumentsMatchParameters(arguments, parameters);
-
-  @Deprecated('Replace with `node.traverseNodesInDFS`')
-  static Iterable<AstNode> traverseNodesInDFS(AstNode node,
-          {AstNodePredicate? excludeCriteria}) =>
-      node.traverseNodesInDFS(excludeCriteria: excludeCriteria);
 }
 
 class InterfaceTypeDefinition {