Skip to content

Commit cf2a474

Browse files
jensjohacommit-bot@chromium.org
authored andcommitted
[CFE] Fix incremental serialization bug caused by missing parameter passing
When implemention the incremental serializer, I forgot to pass it on in the incremental kernel generators "IncrementalKernelGenerator.fromComponent" and only did it in "IncrementalKernelGenerator", meaning that when using "IncrementalKernelGenerator.fromComponent" the incremental serializer wasn't used properly, namely nothing got invalidated. Now it gets passed correctly, things get invalidated and everything should be fine. Fixes flutter/flutter#44384. Change-Id: Ic2e7f7330dc6ee62dd8e7bf6684d7bee8ee328bb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124684 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
1 parent a7a54af commit cf2a474

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pkg/front_end/lib/src/api_prototype/incremental_kernel_generator.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ abstract class IncrementalKernelGenerator {
5050
new CompilerContext(
5151
new ProcessedOptions(options: options, inputs: [entryPoint])),
5252
component,
53-
outlineOnly);
53+
outlineOnly,
54+
incrementalSerializer);
5455
}
5556

5657
/// Returns a component whose libraries are the recompiled libraries,

0 commit comments

Comments
 (0)