Remove tests already moved to ImplicitThisReferenceInInitializerTest.

R=brianwilkerson@google.com

Change-Id: Ibaf67be1bea844e10e599aad8b4ebc450e54cac2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/analyzer/test/generated/compile_time_error_code.dart

@@ -1933,79 +1933,6 @@ class B = A with M implements A;
     ]);
   }
 
-  test_implicitThisReferenceInInitializer_field() async {
-    await assertErrorsInCode(r'''
-class A {
-  var v;
-  A() : v = f;
-  var f;
-}
-''', [
-      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 31, 1),
-    ]);
-  }
-
-  test_implicitThisReferenceInInitializer_field2() async {
-    await assertErrorsInCode(r'''
-class A {
-  final x = 0;
-  final y = x;
-}
-''', [
-      error(StrongModeCode.TOP_LEVEL_INSTANCE_GETTER, 37, 1),
-      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 37, 1),
-    ]);
-  }
-
-  test_implicitThisReferenceInInitializer_invocation() async {
-    await assertErrorsInCode(r'''
-class A {
-  var v;
-  A() : v = f();
-  f() {}
-}
-''', [
-      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 31, 1),
-    ]);
-  }
-
-  test_implicitThisReferenceInInitializer_invocationInStatic() async {
-    await assertErrorsInCode(r'''
-class A {
-  static var F = m();
-  int m() => 0;
-}
-''', [
-      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 27, 1),
-    ]);
-  }
-
-  test_implicitThisReferenceInInitializer_redirectingConstructorInvocation() async {
-    await assertErrorsInCode(r'''
-class A {
-  A(p) {}
-  A.named() : this(f);
-  var f;
-}
-''', [
-      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 39, 1),
-    ]);
-  }
-
-  test_implicitThisReferenceInInitializer_superConstructorInvocation() async {
-    await assertErrorsInCode(r'''
-class A {
-  A(p) {}
-}
-class B extends A {
-  B() : super(f);
-  var f;
-}
-''', [
-      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 56, 1),
-    ]);
-  }
-
   test_importInternalLibrary() async {
     // Note, in these error cases we may generate an UNUSED_IMPORT hint, while
     // we could prevent the hint from being generated by testing the import

pkg/analyzer/test/src/diagnostics/implicit_this_reference_in_initializer_test.dart

@@ -15,7 +15,7 @@ main() {
 
 @reflectiveTest
 class ImplicitThisReferenceInInitializerTest extends DriverResolutionTest {
-  test_implicitThisReferenceInInitializer_constructorName() async {
+  test_constructorName() async {
     await assertNoErrorsInCode(r'''
 class A {
   A.named() {}
@@ -27,7 +27,7 @@ class B {
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_field() async {
+  test_field() async {
     await assertErrorsInCode(r'''
 class A {
   var v;
@@ -39,7 +39,7 @@ class A {
     ]);
   }
 
-  test_implicitThisReferenceInInitializer_field2() async {
+  test_field2() async {
     await assertErrorsInCode(r'''
 class A {
   final x = 0;
@@ -51,7 +51,7 @@ class A {
     ]);
   }
 
-  test_implicitThisReferenceInInitializer_invocation() async {
+  test_invocation() async {
     await assertErrorsInCode(r'''
 class A {
   var v;
@@ -63,7 +63,7 @@ class A {
     ]);
   }
 
-  test_implicitThisReferenceInInitializer_invocationInStatic() async {
+  test_invocationInStatic() async {
     await assertErrorsInCode(r'''
 class A {
   static var F = m();
@@ -74,7 +74,29 @@ class A {
     ]);
   }
 
-  test_implicitThisReferenceInInitializer_prefixedIdentifier() async {
+  test_isInInstanceVariableInitializer_restored() async {
+    // If ErrorVerifier._isInInstanceVariableInitializer is not properly
+    // restored on exit from visitVariableDeclaration, the error at (1)
+    // won't be detected.
+    await assertErrorsInCode(r'''
+class Foo {
+  var bar;
+  Map foo = {
+    'bar': () {
+        var _bar;
+    },
+    'bop': _foo // (1)
+  };
+  _foo() {
+  }
+}
+''', [
+      error(HintCode.UNUSED_LOCAL_VARIABLE, 65, 4),
+      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 89, 4),
+    ]);
+  }
+
+  test_prefixedIdentifier() async {
     await assertNoErrorsInCode(r'''
 class A {
   var f;
@@ -86,7 +108,7 @@ class B {
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_qualifiedMethodInvocation() async {
+  test_qualifiedMethodInvocation() async {
     await assertNoErrorsInCode(r'''
 class A {
   f() {}
@@ -98,7 +120,7 @@ class B {
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_qualifiedPropertyAccess() async {
+  test_qualifiedPropertyAccess() async {
     await assertNoErrorsInCode(r'''
 class A {
   var f;
@@ -110,7 +132,7 @@ class B {
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_redirectingConstructorInvocation() async {
+  test_redirectingConstructorInvocation() async {
     await assertErrorsInCode(r'''
 class A {
   A(p) {}
@@ -122,7 +144,7 @@ class A {
     ]);
   }
 
-  test_implicitThisReferenceInInitializer_staticField_thisClass() async {
+  test_staticField_thisClass() async {
     await assertNoErrorsInCode(r'''
 class A {
   var v;
@@ -132,7 +154,7 @@ class A {
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_staticGetter() async {
+  test_staticGetter() async {
     await assertNoErrorsInCode(r'''
 class A {
   var v;
@@ -142,7 +164,7 @@ class A {
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_staticMethod() async {
+  test_staticMethod() async {
     await assertNoErrorsInCode(r'''
 class A {
   var v;
@@ -152,7 +174,7 @@ class A {
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_superConstructorInvocation() async {
+  test_superConstructorInvocation() async {
     await assertErrorsInCode(r'''
 class A {
   A(p) {}
@@ -166,7 +188,7 @@ class B extends A {
     ]);
   }
 
-  test_implicitThisReferenceInInitializer_topLevelField() async {
+  test_topLevelField() async {
     await assertNoErrorsInCode(r'''
 class A {
   var v;
@@ -176,7 +198,7 @@ var f = 42;
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_topLevelFunction() async {
+  test_topLevelFunction() async {
     await assertNoErrorsInCode(r'''
 class A {
   var v;
@@ -186,7 +208,7 @@ f() => 42;
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_topLevelGetter() async {
+  test_topLevelGetter() async {
     await assertNoErrorsInCode(r'''
 class A {
   var v;
@@ -196,34 +218,12 @@ get f => 42;
 ''');
   }
 
-  test_implicitThisReferenceInInitializer_typeParameter() async {
+  test_typeParameter() async {
     await assertNoErrorsInCode(r'''
 class A<T> {
   var v;
   A(p) : v = (p is T);
 }
 ''');
   }
-
-  test_isInInstanceVariableInitializer_restored() async {
-    // If ErrorVerifier._isInInstanceVariableInitializer is not properly
-    // restored on exit from visitVariableDeclaration, the error at (1)
-    // won't be detected.
-    await assertErrorsInCode(r'''
-class Foo {
-  var bar;
-  Map foo = {
-    'bar': () {
-        var _bar;
-    },
-    'bop': _foo // (1)
-  };
-  _foo() {
-  }
-}
-''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 65, 4),
-      error(CompileTimeErrorCode.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER, 89, 4),
-    ]);
-  }
 }