-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Analyzer: Report on return types of Future.catchError function"
This reverts commit d5ee021. Reason for revert: Breaks google3: b/178222419 Original change's description: > Analyzer: Report on return types of Future.catchError function > > The type of the `onError` parameter of Future<T>.catchError is just Function, > but the function can either have signature `FutureOr<T> Function(dynamic)` or > `FutureOr<T> Function(dynamic, StackTrace)`. This change adds checks for return > statements in a function literal passed to `onError`, and the return type of a > function-typed expression passed to `onError`. > > We still need to check parameter types. > > #35825 > > Change-Id: I3a1d1c444e298c5816fcd1d4bc537f7b87fa3da1 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176221 > Commit-Queue: Samuel Rawlins <srawlins@google.com> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> TBR=scheglov@google.com,brianwilkerson@google.com,srawlins@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8ebbaac0a4b44293576809baa2dc2c3fdcf35379 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180822 Commit-Queue: David Morgan <davidmorgan@google.com> Reviewed-by: David Morgan <davidmorgan@google.com>
- Loading branch information
1 parent
341213b
commit ba01596
Showing
12 changed files
with
9 additions
and
486 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.