[cfe] Use valid static types and file offsets in collections transformation

Closes #39566

Change-Id: I589d0dd568b3ea939bb1238b1c61fca6867e737e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127320
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>

Author: johnniwinther

pkg/compiler/lib/src/ir/static_type_base.dart

@@ -133,19 +133,17 @@ abstract class StaticTypeBase extends ir.Visitor<ir.DartType> {
 
   @override
   ir.DartType visitListLiteral(ir.ListLiteral node) {
-    return typeEnvironment.literalListType(
-        node.typeArgument, ir.Nullability.legacy);
+    return typeEnvironment.listType(node.typeArgument, ir.Nullability.legacy);
   }
 
   @override
   ir.DartType visitSetLiteral(ir.SetLiteral node) {
-    return typeEnvironment.literalSetType(
-        node.typeArgument, ir.Nullability.legacy);
+    return typeEnvironment.setType(node.typeArgument, ir.Nullability.legacy);
   }
 
   @override
   ir.DartType visitMapLiteral(ir.MapLiteral node) {
-    return typeEnvironment.literalMapType(
+    return typeEnvironment.mapType(
         node.keyType, node.valueType, ir.Nullability.legacy);
   }
 

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -5253,7 +5253,8 @@ class BodyBuilder extends ScopeListener<JumpTarget>
                 context: context),
             type: const BottomType())
           ..fileOffset = offset,
-        expression);
+        expression)
+      ..fileOffset = offset;
   }
 
   Expression buildFallThroughError(int charOffset) {

pkg/front_end/lib/src/fasta/kernel/collections.dart

@@ -29,7 +29,7 @@ import 'package:kernel/visitor.dart'
         Visitor;
 
 import '../messages.dart'
-    show templateExpectedAfterButGot, templateExpectedButGot;
+    show noLength, templateExpectedAfterButGot, templateExpectedButGot;
 
 import '../problems.dart' show getFileUri, unsupported;
 
@@ -566,7 +566,8 @@ MapEntry convertToMapEntry(Expression element, InferenceHelper helper,
         templateExpectedAfterButGot.withArguments(':'),
         element.fileOffset,
         // TODO(danrubel): what is the length of the expression?
-        1,
+        noLength,
       ),
-      new NullLiteral());
+      new NullLiteral()..fileOffset = element.fileOffset)
+    ..fileOffset = element.fileOffset;
 }