Skip to content

Commit 6c36630

Browse files
committed
Update to latest package:yaml
Closes #38958 Tweak an analyzer test that fails after the update. There is a change in package:yaml where map keys are now iterated in the order they are defined in the file rather than an arbitrary order based on hash codes. It is not clear to me whether this is safe or if it indicates a deeper bug in the analyzer. Change-Id: Ie02f1bc4277999f991583f9019e67ef70c33a895 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122029 Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
1 parent f6eb26d commit 6c36630

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ vars = {
148148
"web_components_rev": "8f57dac273412a7172c8ade6f361b407e2e4ed02",
149149
"web_socket_channel_tag": "1.0.9",
150150
"WebCore_rev": "fb11e887f77919450e497344da570d780e078bc8",
151-
"yaml_tag": "2.1.15",
151+
"yaml_tag": "2.2.0",
152152
"zlib_rev": "c44fb7248079cc3d5563b14b3f758aee60d6b415",
153153
"crashpad_rev": "bf327d8ceb6a669607b0dbab5a83a275d03f99ed",
154154
"minichromium_rev": "8d641e30a8b12088649606b912c2bc4947419ccc",

pkg/analyzer/test/embedder_tests.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ abstract class EmbedderRelatedTest {
2525
..newFolder('/home/.pub-cache/fox/lib')
2626
..newFile('/home/.pub-cache/fox/lib/_embedder.yaml', r'''
2727
embedded_libs:
28+
"dart:deep": "deep/directory/file.dart"
2829
"dart:core" : "core.dart"
2930
"dart:fox": "slippy.dart"
3031
"dart:bear": "grizzly.dart"
3132
"dart:relative": "../relative.dart"
32-
"dart:deep": "deep/directory/file.dart"
3333
"fart:loudly": "nomatter.dart"
3434
''');
3535
}

pkg/analyzer/test/src/lint/config_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,9 @@ linter:
122122
(RuleConfig rc1, RuleConfig rc2) => rc1.name.compareTo(rc2.name));
123123
expect(ruleConfigs, hasLength(2));
124124
expect(ruleConfigs[0].name, 'camel_case_types');
125-
expect(config.ruleConfigs[0].args['enabled'], isFalse);
125+
expect(ruleConfigs[0].args['enabled'], isTrue);
126126
expect(ruleConfigs[1].name, 'unnecessary_getters');
127-
expect(config.ruleConfigs[1].args['enabled'], isTrue);
127+
expect(ruleConfigs[1].args['enabled'], isFalse);
128128
});
129129
});
130130
});

0 commit comments

Comments
 (0)