Skip to content

Commit 6b19f37

Browse files
karlklosecommit-bot@chromium.org
authored andcommitted
[infra] Change option name in modular test runner to be consistent with test.py
Change-Id: I16baa346daceb8f8c9c807f17ea587f68b227909 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121301 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Karl Klose <karlklose@google.com>
1 parent d0cef92 commit 6b19f37

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

pkg/modular_test/lib/src/runner.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ class Options {
8787
' and `shards - 1`.')
8888
..addOption('output-directory',
8989
help: 'location where to emit the jsonl result and log files')
90-
..addOption('configuration-name',
90+
..addOption('named-configuration',
91+
abbr: 'n',
9192
help: 'configuration name to use for emitting jsonl result files.');
9293
ArgResults argResults = parser.parse(args);
9394
int shards = int.tryParse(argResults['shards']) ?? 1;
@@ -108,7 +109,7 @@ class Options {
108109
..filter = argResults['filter']
109110
..shards = shards
110111
..shard = shard
111-
..configurationName = argResults['configuration-name']
112+
..configurationName = argResults['named-configuration']
112113
..outputDirectory = toUri(argResults['output-directory']);
113114
}
114115
}

tools/bots/test_matrix.json

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1218,8 +1218,7 @@
12181218
"testRunner": true,
12191219
"arguments": [
12201220
"pkg/dev_compiler/test/modular_ddc_suite.dart",
1221-
"--configuration-name",
1222-
"dartdevc-${system}-release",
1221+
"-ndartdevc-${system}-release",
12231222
"--verbose",
12241223
"--use-sdk"
12251224
]
@@ -1230,8 +1229,7 @@
12301229
"testRunner": true,
12311230
"arguments": [
12321231
"pkg/dev_compiler/test/modular_suite.dart",
1233-
"--configuration-name",
1234-
"dartdevk-${system}-release",
1232+
"-ndartdevk-${system}-release",
12351233
"--verbose",
12361234
"--use-sdk"
12371235
]
@@ -1385,8 +1383,7 @@
13851383
"testRunner": true,
13861384
"arguments": [
13871385
"pkg/dev_compiler/test/modular_suite.dart",
1388-
"--configuration-name",
1389-
"dartdevk-${system}-release",
1386+
"-ndartdevk-${system}-release",
13901387
"--verbose",
13911388
"--use-sdk"
13921389
]
@@ -1521,8 +1518,7 @@
15211518
"testRunner": true,
15221519
"arguments": [
15231520
"pkg/compiler/tool/modular_test_suite.dart",
1524-
"--configuration-name",
1525-
"dart2js-${system}-release-d8",
1521+
"-ndart2js-${system}-release-d8",
15261522
"--verbose",
15271523
"--use-sdk"
15281524
]

0 commit comments

Comments
 (0)