Skip to content

Commit 685af75

Browse files
nshahanCommit Queue
authored andcommitted
[ddc] Unskip tests on canary configs
Now that the canary configurations are more reliable we can start running these tests again. They were originally skipped when the async implementation in the new type system was not working correctly. The `web/async_stacktrace_test` has actually been timing out in the stable configs as well. The timeout is consistent and reproducible locally so I'm filing a new issue and skipping it on all DDC configs for now. Fixes: #50666 Issue: #53555 Change-Id: I7306ba66afe595fb213f06c0ad884d376240addc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326721 Reviewed-by: Mark Zhou <markzipan@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
1 parent 42516e3 commit 685af75

File tree

4 files changed

+3
-32
lines changed

4 files changed

+3
-32
lines changed

tests/co19/co19-dartdevc.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,3 @@ LibTest/typed_data/ByteData/setUint64_A02_t01: SkipByDesign # 64-bit int not sup
8787
LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not supported on the web
8888
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
8989
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
90-
91-
[ $builder_tag == canary && $compiler == ddc ]
92-
LibTest/async/StreamController/StreamController.broadcast_Stream_all_A01_t01: Skip # Issue 50666
93-
LibTest/core/Stopwatch/elapsedTicks_A01_t03: Skip # Issue 50666

tests/language/language_dartdevc.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,3 @@ inference_update_2/external_field_test: SkipByDesign # Non-JS-interop external m
1212
number/int64_literal_runtime*_test: Skip # This is testing Dart 2.0 int64 semantics.
1313
superinterface_variance/*: Skip # Issue dart-lang/language#113
1414
vm/*: SkipByDesign # VM only tests.; VM only tests.
15-
16-
[ $builder_tag == canary && $compiler == ddc ]
17-
await/for_test: Skip # Issue 50666
18-
await/future_test: Skip # Issue 50666

tests/lib/lib_dartdevc.status

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -28,27 +28,6 @@ mirrors/*: SkipByDesign # Mirrors not supported on web in Dart 2.0.
2828
typed_data/int64_list_load_store_test: SkipByDesign # ddc does not support Int64List
2929
typed_data/typed_data_hierarchy_int64_test: SkipByDesign # ddc does not support Int64List
3030

31-
[ $builder_tag == canary && $compiler == ddc ]
32-
async/catch_errors11_test: Skip # Issue 50666
33-
async/catch_errors12_test: Skip # Issue 50666
34-
async/catch_errors15_test: Skip # Issue 50666
35-
async/catch_errors17_test: Skip # Issue 50666
36-
async/catch_errors20_test: Skip # Issue 50666
37-
async/catch_errors21_test: Skip # Issue 50666
38-
async/catch_errors23_test: Skip # Issue 50666
39-
async/catch_errors24_test: Skip # Issue 50666
40-
async/catch_errors26_test: Skip # Issue 50666
41-
async/catch_errors27_test: Skip # Issue 50666
42-
async/catch_errors5_test: Skip # Issue 50666
43-
async/catch_errors7_test: Skip # Issue 50666
44-
async/catch_errors8_test: Skip # Issue 50666
45-
async/stream_iterator_test: Skip # Issue 50666
46-
async/stream_periodic5_test: Skip # Issue 50666
47-
async/stream_zones_test: Skip # Issue 50666
48-
convert/streamed_conversion_utf8_decode_test: Skip # Issue 50666
49-
convert/streamed_conversion_utf8_encode_test: Skip # Issue 50666
50-
html/canvasrendering/draw_image_video_element_test: Skip # Issue 50666
51-
5231
[ $compiler == ddc && $runtime == chrome ]
5332
html/js_dispatch_property_test: Skip # Timeout Issue 31030
5433

tests/web/web.status

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ internal/deferred_url_test: SkipByDesign # test specific for the dart2js runtime
1212
[ $compiler != dart2wasm ]
1313
wasm/*: SkipByDesign
1414

15+
[ $compiler == ddc ]
16+
async_stacktrace_test: Skip # Issue 53555
17+
1518
[ $runtime == jsshell ]
1619
deferred/load_in_correct_order_test: SkipByDesign # jsshell preamble does not support this test.
1720

1821
[ $browser ]
1922
native/*: Skip
2023

21-
[ $builder_tag == canary && $compiler == ddc ]
22-
async_stacktrace_test: Skip # Issue 50666
23-
2424
[ $compiler == dart2js && $mode == debug ]
2525
operator_test: Skip
2626
string_interpolation_test: Skip

0 commit comments

Comments
 (0)