[infra] Convert some multi-tests to the new static error framework

This is the result of running the tool from
https://dart-review.googlesource.com/c/sdk/+/124128 on the
language_2 tests that contain only static multi-test annotations.

Some of the results needed manual editing and in these cases I have
also changed the formatting of the tests.

Change-Id: I4ddd16a2c5d8576adccb0a740cb1d4aabbc001b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126161
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>

Author: karlklose

tests/language_2/abstract_exact_selector_runtime_test.dart

@@ -0,0 +1,41 @@
+// TODO(multitest): This was automatically migrated from a multitest and may
+// contain strange or dead code.
+
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Regression test for dart2js that used to duplicate some `Object`
+// methods to handle `noSuchMethod`.
+
+import "package:expect/expect.dart";
+import "compiler_annotations.dart";
+
+
+    class Foo {
+  noSuchMethod(im) => 42;
+}
+
+@DontInline()
+returnFoo() {
+  (() => 42)();
+  return new Foo();
+}
+
+class Bar {
+  operator ==(other) => false;
+}
+
+var a = [false, true, new Object(), new Bar()];
+
+main() {
+  if (a[0]) {
+    // This `==` call will make the compiler create a selector with an
+    // exact `TypeMask` of `Foo`. Since `Foo` is abstract, such a call
+    // cannot happen, but we still used to generate a `==` method on
+    // the `Object` class to handle `noSuchMethod`.
+    print(returnFoo() == 42);
+  } else {
+    Expect.isFalse(a[2] == 42);
+  }
+}

tests/language_2/abstract_exact_selector_test.dart

@@ -8,7 +8,7 @@
 import "package:expect/expect.dart";
 import "compiler_annotations.dart";
 
-abstract //# 01: compile-time error
+abstract
     class Foo {
   noSuchMethod(im) => 42;
 }
@@ -17,6 +17,9 @@ abstract //# 01: compile-time error
 returnFoo() {
   (() => 42)();
   return new Foo();
+  //         ^^^
+  // [analyzer] STATIC_WARNING.INSTANTIATE_ABSTRACT_CLASS
+  // [cfe] The class 'Foo' is abstract and can't be instantiated.
 }
 
 class Bar {

tests/language_2/abstract_factory_constructor_runtime_test.dart

@@ -0,0 +1,34 @@
+// TODO(multitest): This was automatically migrated from a multitest and may
+// contain strange or dead code.
+
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// Dart test program for constructors and initializers.
+
+// Exercises issue 2282, factory constructors in abstract classes should
+// not emit a static type warning
+
+class B extends A1 {
+  B() {}
+  method() {}
+}
+
+abstract class A1 {
+  A1() {}
+  method(); // Abstract.
+  factory A1.make() {
+    return new B();
+  }
+}
+
+class A2 {
+  // Intentionally abstract method.
+
+  A2.make() {}
+}
+
+main() {
+  new A1.make();
+
+}

tests/language_2/abstract_factory_constructor_test.dart

@@ -20,12 +20,17 @@ abstract class A1 {
 }
 
 class A2 {
+//    ^
+// [cfe] The non-abstract class 'A2' is missing implementations for these members:
+
   // Intentionally abstract method.
-  method(); //# 00: compile-time error
+  method();
+//^^^^^^^^^
+// [analyzer] STATIC_WARNING.CONCRETE_CLASS_WITH_ABSTRACT_MEMBER
   A2.make() {}
 }
 
 main() {
   new A1.make();
-  new A2.make(); //# 00: continued
+  new A2.make();
 }

tests/language_2/abstract_getter_test.dart

@@ -7,16 +7,21 @@ import "package:expect/expect.dart";
 // Test to ensure that an abstract getter is not mistaken for a field.
 
 class Foo {
+//    ^
+// [cfe] The non-abstract class 'Foo' is missing implementations for these members:
+
   // Intentionally abstract:
-  get i; //# 01: compile-time error
+  get i;
+//^^^^^^
+// [analyzer] STATIC_WARNING.CONCRETE_CLASS_WITH_ABSTRACT_MEMBER
 }
 
 class Bar {}
 
 checkIt(f) {
-  Expect.throwsNoSuchMethodError(() => f.i = 'hi'); // //# 01: continued
-  Expect.throwsNoSuchMethodError(() => print(f.i)); // //# 01: continued
-  Expect.throwsNoSuchMethodError(() => print(f.i())); // //# 01: continued
+  Expect.throwsNoSuchMethodError(() => f.i = 'hi');
+  Expect.throwsNoSuchMethodError(() => print(f.i));
+  Expect.throwsNoSuchMethodError(() => print(f.i()));
 }
 
 main() {

tests/language_2/abstract_syntax_runtime_test.dart

@@ -0,0 +1,23 @@
+// TODO(multitest): This was automatically migrated from a multitest and may
+// contain strange or dead code.
+
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+main() {
+  var b = new B();
+  Expect.equals(42, b.foo());
+}
+
+class A {
+
+
+}
+
+class B extends A {
+  foo() => 42;
+  bar() => 87;
+}

tests/language_2/abstract_syntax_test.dart

@@ -10,8 +10,15 @@ main() {
 }
 
 class A {
-  foo(); // //# 00: compile-time error
-  static bar(); // //# 01: syntax error
+//    ^
+// [cfe] The non-abstract class 'A' is missing implementations for these members:
+  foo();
+//^^^^^^
+// [analyzer] STATIC_WARNING.CONCRETE_CLASS_WITH_ABSTRACT_MEMBER
+  static bar();
+  //          ^
+  // [analyzer] SYNTACTIC_ERROR.MISSING_FUNCTION_BODY
+  // [cfe] Expected a function body or '=>'.
 }
 
 class B extends A {

tests/language_2/argument_assignability_function_typed_runtime_1_test.dart

@@ -0,0 +1,40 @@
+// TODO(multitest): This was automatically migrated from a multitest and may
+// contain strange or dead code.
+
+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+void f(num callback(num x)) {}
+
+Object intToObject(int x) => null;
+Object numToObject(num x) => null;
+Object objectToObject(Object x) => null;
+int intToInt(int x) => null;
+int numToInt(num x) => null;
+int objectToInt(Object x) => null;
+num intToNum(int x) => null;
+num numToNum(num x) => null;
+num objectToNum(Object x) => null;
+
+main() {
+  // Unrelated types (not assignable)
+
+
+
+  // Assignable but fails at runtime.
+  var intToObject2 = intToObject;
+  Expect.throwsTypeError(() => f(intToObject2));
+  var intToNum2 = intToNum;
+
+  var numToObject2 = numToObject;
+
+
+  // Ok
+
+
+
+
+}

tests/language_2/argument_assignability_function_typed_runtime_2_test.dart

@@ -0,0 +1,40 @@
+// TODO(multitest): This was automatically migrated from a multitest and may
+// contain strange or dead code.
+
+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+void f(num callback(num x)) {}
+
+Object intToObject(int x) => null;
+Object numToObject(num x) => null;
+Object objectToObject(Object x) => null;
+int intToInt(int x) => null;
+int numToInt(num x) => null;
+int objectToInt(Object x) => null;
+num intToNum(int x) => null;
+num numToNum(num x) => null;
+num objectToNum(Object x) => null;
+
+main() {
+  // Unrelated types (not assignable)
+
+
+
+  // Assignable but fails at runtime.
+  var intToObject2 = intToObject;
+
+  var intToNum2 = intToNum;
+  Expect.throwsTypeError(() => f(intToNum2));
+  var numToObject2 = numToObject;
+
+
+  // Ok
+
+
+
+
+}

tests/language_2/argument_assignability_function_typed_runtime_3_test.dart

@@ -0,0 +1,40 @@
+// TODO(multitest): This was automatically migrated from a multitest and may
+// contain strange or dead code.
+
+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+void f(num callback(num x)) {}
+
+Object intToObject(int x) => null;
+Object numToObject(num x) => null;
+Object objectToObject(Object x) => null;
+int intToInt(int x) => null;
+int numToInt(num x) => null;
+int objectToInt(Object x) => null;
+num intToNum(int x) => null;
+num numToNum(num x) => null;
+num objectToNum(Object x) => null;
+
+main() {
+  // Unrelated types (not assignable)
+
+
+
+  // Assignable but fails at runtime.
+  var intToObject2 = intToObject;
+
+  var intToNum2 = intToNum;
+
+  var numToObject2 = numToObject;
+  Expect.throwsTypeError(() => f(numToObject2));
+
+  // Ok
+
+
+
+
+}