Skip to content

Commit 5aa86eb

Browse files
mkustermanncommit-bot@chromium.org
authored andcommitted
[vm/concurrency] Run all isolate related tests with/without enabling isolate groups
Issue #36097 Change-Id: I0b7eca744bc49ab5ba09da3ce2a9286b1ed3c70f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126340 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
1 parent 96e7a4f commit 5aa86eb

File tree

120 files changed

+366
-2
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

120 files changed

+366
-2
lines changed

runtime/tests/vm/dart/issue_31959_31960_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
7+
58
import 'dart:async';
69
import 'dart:isolate';
710
import 'dart:math';

runtime/tests/vm/dart/spawn_infinite_loop_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
7+
58
import 'dart:isolate';
69

710
// This test ensures that the VM can kill the spawned isolate during VM

runtime/tests/vm/dart/transferable_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
7+
58
// Test that validates that transferables are faster than regular typed data.
69

710
import 'dart:async';

runtime/tests/vm/dart/transferable_throws_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
7+
58
// Test that ensures correct exceptions are thrown when misusing
69
// [TransferableTypedData].
710

tests/ffi/function_callbacks_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
4+
5+
// VMOptions=--enable-testing-pragmas --enable-isolate-groups
6+
// VMOptions=--enable-testing-pragmas --no-enable-isolate-groups
47
//
58
// Dart test program for testing dart:ffi function pointers with callbacks.
69
//

tests/ffi/snapshot_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
4+
5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
47
//
58
// Checks that the VM throws an appropriate exception when FFI objects are
69
// passed between isolates.

tests/language_2/issue23244_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
7+
58
// Regression test case for http://dartbug.com/23244
69
import 'dart:async';
710
import 'dart:isolate';

tests/language_2/vm/optimized_guarded_field_isolates_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
4+
5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
47
// VMOptions=--optimization_counter_threshold=100 --no-background_compilation
58

69
// Test field type tracking and field list-length tracking in the presence of

tests/lib_2/isolate/bool_from_environment_default_value_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
7+
58
import "dart:isolate";
69

710
import "package:expect/expect.dart";

tests/lib_2/isolate/capability_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// VMOptions=--enable-isolate-groups
6+
// VMOptions=--no-enable-isolate-groups
7+
58
import "dart:isolate";
69
import "package:expect/expect.dart";
710
import "package:async_helper/async_helper.dart";

0 commit comments

Comments
 (0)