Skip to content

Commit 38f78c0

Browse files
bkonyicommit-bot@chromium.org
authored andcommitted
[ dart:developer ] Updated parentId argument for timeline events to use base64 to be consistent with async ID formatting
Change-Id: I96314f5712b722da5188c0a447a12c9c5fe6064b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120322 Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
1 parent 69b612b commit 38f78c0

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,10 @@ var tests = <VMTest>[
127127
eventsContains(dartEvents, 'i', 'ISYNC', {'fruit': 'banana'}), isTrue);
128128
expect(eventsContains(dartEvents, 'X', 'apple'), isTrue);
129129
expect(
130-
eventsContains(dartEvents, 'b', 'TASK1',
131-
{'task1-start-key': 'task1-start-value', 'parentId': 42}),
130+
eventsContains(dartEvents, 'b', 'TASK1', {
131+
'task1-start-key': 'task1-start-value',
132+
'parentId': 42.toRadixString(16)
133+
}),
132134
isTrue);
133135
expect(
134136
eventsContains(dartEvents, 'e', 'TASK1',

sdk/lib/developer/timeline.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class TimelineTask {
209209
_stack.add(block);
210210
block._start({
211211
if (arguments != null) ...arguments,
212-
if (_parent != null) 'parentId': _parent._taskId,
212+
if (_parent != null) 'parentId': _parent._taskId.toRadixString(16),
213213
});
214214
}
215215

sdk_nnbd/lib/developer/timeline.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class TimelineTask {
211211
_stack.add(block);
212212
block._start({
213213
if (arguments != null) ...arguments,
214-
if (_parent != null) 'parentId': _parent._taskId,
214+
if (_parent != null) 'parentId': _parent._taskId.toRadixString(16),
215215
});
216216
}
217217

0 commit comments

Comments
 (0)