[analyzer] Add [SilentException] where previously not reported to users.

New errors *not* changed to silent exceptions:

https://dart-review.googlesource.com/c/sdk/+/123328/9/pkg/analyzer/lib/src/dart/sdk/sdk.dart
https://dart-review.googlesource.com/c/sdk/+/123328/9/pkg/analysis_server/lib/src/analysis_server_abstract.dart

These seem worth keeping.

Change-Id: I534b07f6cf50c5b251867b647ed6df96a9134c56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>

Author: MichaelRFairhurst

pkg/analysis_server/lib/src/analysis_server.dart

@@ -884,8 +884,9 @@ class ServerContextManagerCallbacks extends ContextManagerCallbacks {
       if (result.contextKey != null) {
         message += ' context: ${result.contextKey}';
       }
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.wrapInMessage(message, result.exception));
+          new SilentException.wrapInMessage(message, result.exception));
     });
     analysisServer.driverMap[folder] = analysisDriver;
     return analysisDriver;

pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart

@@ -625,8 +625,9 @@ class LspServerContextManagerCallbacks extends ContextManagerCallbacks {
       if (result.contextKey != null) {
         message += ' context: ${result.contextKey}';
       }
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.wrapInMessage(message, result.exception));
+          new SilentException.wrapInMessage(message, result.exception));
     });
     analysisServer.driverMap[folder] = analysisDriver;
     return analysisDriver;

pkg/analysis_server/test/context_manager_test.dart

@@ -2511,8 +2511,8 @@ class TestContextManagerCallbacks extends ContextManagerCallbacks {
     driverMap[path] = currentDriver;
     currentDriver.exceptions.listen((ExceptionResult result) {
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.wrapInMessage(
-              'Analysis failed: ${result.path}', result.exception));
+          new CaughtException.withMessage('Analysis failed: ${result.path}',
+              result.exception.exception, result.exception.stackTrace));
     });
     return currentDriver;
   }

pkg/analyzer/lib/exception/exception.dart

@@ -68,12 +68,6 @@ class CaughtException implements Exception {
   CaughtException.withMessage(this.message, this.exception, stackTrace)
       : this.stackTrace = stackTrace ?? StackTrace.current;
 
-  /**
-   * Create a [CaughtException] to wrap a prior one, adding a [message].
-   */
-  CaughtException.wrapInMessage(String message, CaughtException exception)
-      : this.withMessage(message, exception, null);
-
   @override
   String toString() {
     StringBuffer buffer = new StringBuffer();
@@ -108,3 +102,20 @@ class CaughtException implements Exception {
     }
   }
 }
+
+/**
+ * A form of [CaughtException] that should be silent to users.
+ *
+ * This is still considered an exceptional situation and will be sent to crash
+ * reporting.
+ */
+class SilentException extends CaughtException {
+  SilentException(String message, exception, stackTrace)
+      : super.withMessage(message, exception, stackTrace);
+
+  /**
+   * Create a [SilentException] to wrap a [CaughtException], adding a [message].
+   */
+  SilentException.wrapInMessage(String message, CaughtException exception)
+      : this(message, exception, null);
+}

pkg/analyzer/lib/src/context/source.dart

@@ -110,8 +110,9 @@ class SourceFactoryImpl implements SourceFactory {
         return _internalResolveUri(null, uri);
       }
     } catch (exception, stackTrace) {
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.withMessage(
+          new SilentException(
               "Could not resolve URI: $absoluteUri", exception, stackTrace));
     }
     return null;
@@ -123,8 +124,9 @@ class SourceFactoryImpl implements SourceFactory {
       try {
         return _internalResolveUri(null, absoluteUri);
       } on AnalysisException catch (exception, stackTrace) {
+        // TODO(39284): should this exception be silent?
         AnalysisEngine.instance.instrumentationService.logException(
-            new CaughtException.withMessage(
+            new SilentException(
                 "Could not resolve URI: $absoluteUri", exception, stackTrace));
       }
     }
@@ -144,8 +146,9 @@ class SourceFactoryImpl implements SourceFactory {
     } catch (exception, stackTrace) {
       String containingFullName =
           containingSource != null ? containingSource.fullName : '<null>';
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService
-          .logException(new CaughtException.withMessage(
+          .logException(new SilentException(
               "Could not resolve URI ($containedUri) "
               "relative to source ($containingFullName)",
               exception,

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -648,8 +648,9 @@ class AssignmentExpressionImpl extends ExpressionImpl
       } else {
         message = "The right-hand size is null";
       }
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException(new AnalysisException(message), null),
+          new SilentException(message, new AnalysisException(message), null),
           StackTrace.current);
     }
     _leftHandSide = _becomeParentOf(leftHandSide);

pkg/analyzer/lib/src/dart/ast/utilities.dart

@@ -2475,9 +2475,9 @@ class ExceptionHandlingDelegatingAstVisitor<T> extends DelegatingAstVisitor<T> {
       buffer.write(currentNode.runtimeType);
       currentNode = currentNode.parent;
     }
+    // TODO(39284): should this exception be silent?
     AnalysisEngine.instance.instrumentationService.logException(
-        new CaughtException.withMessage(
-            buffer.toString(), exception, stackTrace));
+        new SilentException(buffer.toString(), exception, stackTrace));
   }
 }
 
@@ -2531,8 +2531,9 @@ class NodeLocator extends UnifyingAstVisitor<void> {
     try {
       node.accept(this);
     } catch (exception, stackTrace) {
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.withMessage(
+          new SilentException(
               "Unable to locate element at offset ($_startOffset - $_endOffset)",
               exception,
               stackTrace));
@@ -2571,8 +2572,9 @@ class NodeLocator extends UnifyingAstVisitor<void> {
     } catch (exception, stackTrace) {
       // Ignore the exception and proceed in order to visit the rest of the
       // structure.
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.withMessage(
+          new SilentException(
               "Exception caught while traversing an AST structure.",
               exception,
               stackTrace));
@@ -2631,8 +2633,9 @@ class NodeLocator2 extends UnifyingAstVisitor<void> {
     try {
       node.accept(this);
     } catch (exception, stackTrace) {
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.withMessage(
+          new SilentException(
               "Unable to locate element at offset ($_startOffset - $_endOffset)",
               exception,
               stackTrace));
@@ -2671,8 +2674,9 @@ class NodeLocator2 extends UnifyingAstVisitor<void> {
     } catch (exception, stackTrace) {
       // Ignore the exception and proceed in order to visit the rest of the
       // structure.
+      // TODO(39284): should this exception be silent?
       AnalysisEngine.instance.instrumentationService.logException(
-          new CaughtException.withMessage(
+          new SilentException(
               "Exception caught while traversing an AST structure.",
               exception,
               stackTrace));

pkg/analyzer/lib/src/dart/sdk/sdk.dart

@@ -635,9 +635,9 @@ class FolderBasedDartSdk extends AbstractDartSdk {
     if (resourceProvider is MemoryResourceProvider) {
       (resourceProvider as MemoryResourceProvider).writeOn(buffer);
     }
+    // TODO(39284): should this exception be silent?
     AnalysisEngine.instance.instrumentationService.logException(
-        new CaughtException.withMessage(
-            buffer.toString(), lastException, lastStackTrace));
+        new SilentException(buffer.toString(), lastException, lastStackTrace));
     return new LibraryMap();
   }
 

pkg/analyzer/lib/src/generated/source_io.dart

@@ -339,13 +339,15 @@ class PackageUriResolver extends UriResolver {
       pkgDir = pkgDir.getCanonicalFile();
     } catch (exception, stackTrace) {
       if (!exception.toString().contains("Required key not available")) {
+        // TODO(39284): should this exception be silent?
         AnalysisEngine.instance.instrumentationService.logException(
-            new CaughtException.withMessage(
+            new SilentException(
                 "Canonical failed: $pkgDir", exception, stackTrace));
       } else if (_CanLogRequiredKeyIoException) {
         _CanLogRequiredKeyIoException = false;
+        // TODO(39284): should this exception be silent?
         AnalysisEngine.instance.instrumentationService.logException(
-            new CaughtException.withMessage(
+            new SilentException(
                 "Canonical failed: $pkgDir", exception, stackTrace));
       }
     }