Migrating DDC dart:developer patch files.

Change-Id: I99fb8004433ac0b518c6da23dfb7d73d2a30e769
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124421
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>

Author: Markzipan

sdk_nnbd/lib/_internal/js_dev_runtime/patch/developer_patch.dart

@@ -13,15 +13,15 @@ import 'dart:isolate';
 
 @patch
 @ForceInline()
-bool debugger({bool when = true, String message}) {
+bool debugger({bool when = true, String? message}) {
   if (when) {
     JS('', 'debugger');
   }
   return when;
 }
 
 @patch
-Object inspect(Object object) {
+Object? inspect(Object? object) {
   // Note: this log level does not show up by default in Chrome.
   // This is used for communication with the debugger service.
   JS('', 'console.debug("dart.developer.inspect", #)', object);
@@ -30,13 +30,13 @@ Object inspect(Object object) {
 
 @patch
 void log(String message,
-    {DateTime time,
-    int sequenceNumber,
+    {DateTime? time,
+    int? sequenceNumber,
     int level = 0,
     String name = '',
-    Zone zone,
-    Object error,
-    StackTrace stackTrace}) {
+    Zone? zone,
+    Object? error,
+    StackTrace? stackTrace}) {
   Object items =
       JS('!', '{ message: #, name: #, level: # }', message, name, level);
   if (time != null) JS('', '#.time = #', items, time);
@@ -50,10 +50,10 @@ void log(String message,
   JS('', 'console.debug("dart.developer.log", #)', items);
 }
 
-final _extensions = Map<String, ServiceExtensionHandler>();
+final _extensions = <String, ServiceExtensionHandler>{};
 
 @patch
-ServiceExtensionHandler _lookupExtension(String method) {
+ServiceExtensionHandler? _lookupExtension(String method) {
   return _extensions[method];
 }
 
@@ -79,7 +79,7 @@ _invokeExtension(String methodName, String encodedJson) {
   return JS('', 'new #.Promise(#)', dart.global_,
       (Function(Object) resolve, Function(Object) reject) async {
     try {
-      var method = _lookupExtension(methodName);
+      var method = _lookupExtension(methodName)!;
       var parameters = (json.decode(encodedJson) as Map).cast<String, String>();
       var result = await method(methodName, parameters);
       resolve(result._toString());
@@ -164,7 +164,7 @@ void _webServerControl(SendPort sendPort, bool enable) {
 }
 
 @patch
-String _getIsolateIDFromSendPort(SendPort sendPort) {
+String? _getIsolateIDFromSendPort(SendPort sendPort) {
   return null;
 }
 
@@ -178,7 +178,7 @@ class UserTag {
 }
 
 class _FakeUserTag implements UserTag {
-  static Map _instances = {};
+  static final _instances = <String, _FakeUserTag>{};
 
   _FakeUserTag.real(this.label);
 
@@ -193,10 +193,7 @@ class _FakeUserTag implements UserTag {
       throw UnsupportedError(
           'UserTag instance limit (${UserTag.MAX_USER_TAGS}) reached.');
     }
-    // Create a new instance and add it to the instance map.
-    var instance = _FakeUserTag.real(label);
-    _instances[label] = instance;
-    return instance;
+    return _instances[label] = _FakeUserTag.real(label);
   }
 
   final String label;

sdk_nnbd/lib/developer/developer.dart

@@ -39,7 +39,7 @@ external bool debugger({bool when = true, String? message});
 /// Send a reference to [object] to any attached debuggers.
 ///
 /// Debuggers may open an inspector on the object. Returns the argument.
-external Object inspect(Object? object);
+external Object? inspect(Object? object);
 
 /// Emit a log event.
 ///

sdk_nnbd/lib/developer/extension.dart

@@ -158,5 +158,5 @@ external void _postEvent(String eventKind, String eventData);
 // these into Dart code unless you can ensure that the operations will can be
 // done atomically. Native code lives in vm/isolate.cc-
 // LookupServiceExtensionHandler and RegisterServiceExtensionHandler.
-external ServiceExtensionHandler _lookupExtension(String method);
+external ServiceExtensionHandler? _lookupExtension(String method);
 external _registerExtension(String method, ServiceExtensionHandler handler);

sdk_nnbd/lib/developer/service.dart

@@ -19,7 +19,7 @@ class ServiceProtocolInfo {
 
   /// The Uri to access the service. If the web server is not running, this
   /// will be null.
-  final Uri serverUri;
+  final Uri? serverUri;
 
   ServiceProtocolInfo(this.serverUri);
 
@@ -77,7 +77,7 @@ class Service {
   ///
   /// Returns null if the running Dart environment does not support the service
   /// protocol.
-  static String getIsolateID(Isolate isolate) {
+  static String? getIsolateID(Isolate isolate) {
     // TODO: When NNBD is complete, delete the following line.
     ArgumentError.checkNotNull(isolate, 'isolate');
     return _getIsolateIDFromSendPort(isolate.controlPort);
@@ -97,4 +97,4 @@ external int _getServiceMajorVersion();
 external int _getServiceMinorVersion();
 
 /// Returns the service id for the isolate that owns [sendPort].
-external String _getIsolateIDFromSendPort(SendPort sendPort);
+external String? _getIsolateIDFromSendPort(SendPort sendPort);