Skip to content

Commit 1994c5c

Browse files
stereotype441commit-bot@chromium.org
authored andcommitted
Improve error reporting in ID tests
Change-Id: I3a1da7cef955cdef62d4fea3a98f5949309695be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124240 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
1 parent e93bf30 commit 1994c5c

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

pkg/analyzer/test/util/id_testing_helper.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import 'package:analyzer/dart/analysis/features.dart';
1313
import 'package:analyzer/dart/analysis/utilities.dart';
1414
import 'package:analyzer/dart/ast/ast.dart' hide Annotation;
1515
import 'package:analyzer/diagnostic/diagnostic.dart';
16+
import 'package:analyzer/error/error.dart';
1617
import 'package:analyzer/file_system/file_system.dart';
1718
import 'package:analyzer/file_system/memory_file_system.dart';
1819
import 'package:analyzer/src/dart/analysis/byte_store.dart';
@@ -141,7 +142,12 @@ Future<bool> runTestForConfig<T>(
141142
var errors =
142143
result.errors.where((e) => e.severity == Severity.error).toList();
143144
if (errors.isNotEmpty) {
144-
onFailure('Errors found:\n ${errors.join('\n ')}');
145+
String _formatError(AnalysisError e) {
146+
var locationInfo = result.unit.lineInfo.getLocation(e.offset);
147+
return '$locationInfo: ${e.message}';
148+
}
149+
150+
onFailure('Errors found:\n ${errors.map(_formatError).join('\n ')}');
145151
return true;
146152
}
147153
Map<Uri, Map<Id, ActualData<T>>> actualMaps = <Uri, Map<Id, ActualData<T>>>{};

0 commit comments

Comments
 (0)