Skip to content

Commit 6d3bd57

Browse files
authored
Upgrade CI SDKs (#1439)
1 parent 1c5c1a7 commit 6d3bd57

29 files changed

+171
-152
lines changed

.github/workflows/test-package.yml

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
strategy:
2222
fail-fast: false
2323
matrix:
24-
sdk: [3.6.0]
24+
sdk: [3.7.0]
2525
steps:
2626
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
2727
- uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
@@ -49,19 +49,18 @@ jobs:
4949
# TODO(sigurdm): our end2end test creates longer filenames than we can
5050
# handle on windows. See https://github.com/dart-lang/sdk/issues/42416
5151
os: [ubuntu-latest, macos-latest]
52-
sdk: [3.6.0]
53-
flutter: [3.27.0]
52+
sdk: [3.7.0]
53+
flutter: [3.29.0]
5454
steps:
5555
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
5656
- uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
5757
with:
5858
sdk: ${{ matrix.sdk }}
59-
- name: Setup Flutter
60-
run: |
61-
cd $HOME
62-
git clone https://github.com/flutter/flutter.git --depth 1 -b ${{ matrix.flutter }} _flutter
63-
echo "$HOME/_flutter/bin" >> $GITHUB_PATH
64-
cd $GITHUB_WORKSPACE
59+
- name: Setup Flutter SDK
60+
uses: flutter-actions/setup-flutter@v4
61+
with:
62+
channel: stable
63+
version: ${{ matrix.flutter }}
6564
- name: Check Flutter
6665
run: flutter --version --machine
6766
- id: install
@@ -84,11 +83,10 @@ jobs:
8483
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
8584
- uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94
8685
with:
87-
sdk: '3.7.0-164.0.dev' # TODO: switch back to rolling 'dev' channel after it gets updated.
88-
- uses: subosito/flutter-action@f2c4f6686ca8e8d6e6d0f28410eeef506ed66aff
86+
channel: beta
87+
- uses: flutter-actions/setup-flutter@v4
8988
with:
90-
# flutter-version: '3.4.0-34.1.pre'
91-
channel: 'master' # TODO: switch back to rolling 'dev' channel after it gets updated.
89+
channel: beta
9290
- name: Check Flutter
9391
run: flutter --version --machine
9492
- id: install

test/end2end_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ void main() {
205205
verifyPackage('onepub', '1.1.0');
206206

207207
// multi-level symlink
208-
verifyPackage('audio_service', '0.18.15', skipDartdoc: true);
208+
verifyPackage('audio_service', '0.18.17', skipDartdoc: true);
209209

210210
// downgrade failure
211211
verifyPackage('gg', '1.0.12', skipDartdoc: true);

test/goldens/end2end/__timestamp.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2024-11-22T17:22:40.363341Z
1+
2025-02-14T10:50:43.910836Z

test/goldens/end2end/audio_service-0.18.15.json renamed to test/goldens/end2end/audio_service-0.18.17.json

Lines changed: 13 additions & 10 deletions
Large diffs are not rendered by default.

test/goldens/end2end/audio_service-0.18.15.json_report.md renamed to test/goldens/end2end/audio_service-0.18.17.json_report.md

Lines changed: 22 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -84,18 +84,9 @@ This package is not compatible with runtime `wasm`, and will not be rewarded ful
8484

8585
See https://dart.dev/web/wasm for details.
8686

87-
### [x] 0/0 points: Swift Package Manager support
87+
### [*] 0/0 points: Swift Package Manager support
8888

89-
<details>
90-
<summary>
91-
Package does not support the Swift Package Manager on macOS
92-
</summary>
93-
94-
It does not contain `macos/audio_service/Package.swift`.
95-
96-
</details>
97-
98-
This package for iOS or macOS does not support the Swift Package Manager. It will not receive full points in a future version of the scoring model.
89+
This iOS or macOS plugin supports the Swift Package Manager. It will be rewarded additional points in a future version of the scoring model.
9990

10091
See https://docs.flutter.dev/to/spm for details.
10192

@@ -111,51 +102,51 @@ See https://docs.flutter.dev/to/spm for details.
111102

112103
|Package|Constraint|Compatible|Latest|
113104
|:-|:-|:-|:-|
114-
|[`audio_service_platform_interface`]|`^0.1.1`|0.1.1|0.1.1|
115-
|[`audio_service_web`]|`^0.1.3`|0.1.3|0.1.3|
116-
|[`audio_session`]|`^0.1.20`|0.1.21|0.1.21|
105+
|[`audio_service_platform_interface`]|`^0.1.3`|0.1.3|0.1.3|
106+
|[`audio_service_web`]|`^0.1.4`|0.1.4|0.1.4|
107+
|[`audio_session`]|`^0.1.25`|0.1.25|0.1.25|
117108
|[`clock`]|`^1.1.0`|1.1.2|1.1.2|
118109
|[`flutter`]|`flutter`|0.0.0|0.0.0|
119110
|[`flutter_cache_manager`]|`^3.3.1`|3.4.1|3.4.1|
120111
|[`flutter_web_plugins`]|`flutter`|0.0.0|0.0.0|
121-
|[`js`]|`>=0.6.3 <0.8.0`|0.7.1|0.7.1|
112+
|[`js`]|`>=0.6.3 <0.8.0`|0.7.2|0.7.2|
122113
|[`rxdart`]|`>=0.26.0 <0.29.0`|0.28.0|0.28.0|
123114

124115
<details><summary>Transitive dependencies</summary>
125116

126117
|Package|Constraint|Compatible|Latest|
127118
|:-|:-|:-|:-|
128-
|[`async`]|-|2.12.0|2.12.0|
129-
|[`characters`]|-|1.3.0|1.3.1|
130-
|[`collection`]|-|1.19.0|1.19.1|
119+
|[`async`]|-|2.13.0|2.13.0|
120+
|[`characters`]|-|1.4.0|1.4.0|
121+
|[`collection`]|-|1.19.1|1.19.1|
131122
|[`crypto`]|-|3.0.6|3.0.6|
132123
|[`ffi`]|-|2.1.3|2.1.3|
133124
|[`file`]|-|7.0.1|7.0.1|
134125
|[`fixnum`]|-|1.1.1|1.1.1|
135-
|[`http`]|-|1.2.2|1.2.2|
136-
|[`http_parser`]|-|4.1.1|4.1.1|
126+
|[`http`]|-|1.3.0|1.3.0|
127+
|[`http_parser`]|-|4.1.2|4.1.2|
137128
|[`material_color_utilities`]|-|0.11.1|0.12.0|
138-
|[`meta`]|-|1.15.0|1.16.0|
129+
|[`meta`]|-|1.16.0|1.16.0|
139130
|[`path`]|-|1.9.1|1.9.1|
140131
|[`path_provider`]|-|2.1.5|2.1.5|
141-
|[`path_provider_android`]|-|2.2.12|2.2.12|
142-
|[`path_provider_foundation`]|-|2.4.0|2.4.0|
132+
|[`path_provider_android`]|-|2.2.15|2.2.15|
133+
|[`path_provider_foundation`]|-|2.4.1|2.4.1|
143134
|[`path_provider_linux`]|-|2.2.1|2.2.1|
144135
|[`path_provider_platform_interface`]|-|2.1.2|2.1.2|
145136
|[`path_provider_windows`]|-|2.3.0|2.3.0|
146137
|[`platform`]|-|3.1.6|3.1.6|
147138
|[`plugin_platform_interface`]|-|2.1.8|2.1.8|
148139
|[`sky_engine`]|-|0.0.0|0.0.0|
149-
|[`source_span`]|-|1.10.0|1.10.0|
140+
|[`source_span`]|-|1.10.1|1.10.1|
150141
|[`sprintf`]|-|7.0.0|7.0.0|
151-
|[`sqflite`]|-|2.4.1|2.4.1|
152-
|[`sqflite_android`]|-|2.4.0|2.4.0|
153-
|[`sqflite_common`]|-|2.5.4+6|2.5.4+6|
154-
|[`sqflite_darwin`]|-|2.4.1|2.4.1|
142+
|[`sqflite`]|-|2.4.2|2.4.2|
143+
|[`sqflite_android`]|-|2.4.1|2.4.1|
144+
|[`sqflite_common`]|-|2.5.5|2.5.5|
145+
|[`sqflite_darwin`]|-|2.4.2|2.4.2|
155146
|[`sqflite_platform_interface`]|-|2.4.0|2.4.0|
156-
|[`string_scanner`]|-|1.4.0|1.4.0|
157-
|[`synchronized`]|-|3.3.0+3|3.3.0+3|
158-
|[`term_glyph`]|-|1.2.1|1.2.1|
147+
|[`string_scanner`]|-|1.4.1|1.4.1|
148+
|[`synchronized`]|-|3.3.1|3.3.1|
149+
|[`term_glyph`]|-|1.2.2|1.2.2|
159150
|[`typed_data`]|-|1.4.0|1.4.0|
160151
|[`uuid`]|-|4.5.1|4.5.1|
161152
|[`vector_math`]|-|2.1.4|2.1.4|

test/goldens/end2end/bulma_min-0.7.4.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"grantedPoints": 0,
7575
"maxPoints": 40,
7676
"status": "failed",
77-
"summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}. Cannot run `dart pub outdated`.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n ╷\n8 │ sdk: '>=1.0.0 <3.0.0'\n │ ^^^^^^^^^^^^^^^^\n ╵\n```\n\n</details>\n\n### [x] 0/10 points: Package supports latest stable Dart and Flutter SDKs\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n ╷\n8 │ sdk: '>=1.0.0 <3.0.0'\n │ ^^^^^^^^^^^^^^^^\n ╵\n```\n\nTry widening the upper boundary of the constraint.\n</details>\n\n### [x] 0/20 points: Compatible with dependency constraint lower bounds\n\n`dart pub downgrade` failed with:\n\n```\nOUT:\nResolving dependencies...\nERR:\nThe lower bound of \"sdk: '>=1.0.0 <3.0.0'\" must be 2.12.0'\nor higher to enable null safety.\n\nThe current Dart SDK (3.6.0) only supports null safety.\n\nFor details, see https://dart.dev/null-safety\n```\n\nRun `dart pub downgrade` and then `dart analyze` to reproduce the above problem.\n\nYou may run `dart pub upgrade --tighten` to update your dependency constraints, see [dart.dev/go/downgrade-testing](https://dart.dev/go/downgrade-testing) for details.\n"
77+
"summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}. Cannot run `dart pub outdated`.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n ╷\n8 │ sdk: '>=1.0.0 <3.0.0'\n │ ^^^^^^^^^^^^^^^^\n ╵\n```\n\n</details>\n\n### [x] 0/10 points: Package supports latest stable Dart and Flutter SDKs\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n ╷\n8 │ sdk: '>=1.0.0 <3.0.0'\n │ ^^^^^^^^^^^^^^^^\n ╵\n```\n\nTry widening the upper boundary of the constraint.\n</details>\n\n### [x] 0/20 points: Compatible with dependency constraint lower bounds\n\n`dart pub downgrade` failed with:\n\n```\nOUT:\nResolving dependencies...\nERR:\nThe lower bound of \"sdk: '>=1.0.0 <3.0.0'\" must be 2.12.0'\nor higher to enable null safety.\n\nThe current Dart SDK (3.7.0) only supports null safety.\n\nFor details, see https://dart.dev/null-safety\n```\n\nRun `dart pub downgrade` and then `dart analyze` to reproduce the above problem.\n\nYou may run `dart pub upgrade --tighten` to update your dependency constraints, see [dart.dev/go/downgrade-testing](https://dart.dev/go/downgrade-testing) for details.\n"
7878
}
7979
]
8080
},

test/goldens/end2end/bulma_min-0.7.4.json_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ ERR:
105105
The lower bound of "sdk: '>=1.0.0 <3.0.0'" must be 2.12.0'
106106
or higher to enable null safety.
107107
108-
The current Dart SDK (3.6.0) only supports null safety.
108+
The current Dart SDK (3.7.0) only supports null safety.
109109
110110
For details, see https://dart.dev/null-safety
111111
```

test/goldens/end2end/dnd-2.0.1.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"grantedPoints": 30,
8080
"maxPoints": 50,
8181
"status": "failed",
82-
"summary": "### [x] 30/50 points: code has no errors, warnings, lints, or formatting issues\n\nFound 9 issues. Showing the first 2:\n\n<details>\n<summary>\nWARNING: Unnecessary type check; the result is always 'true'.\n</summary>\n\n`lib/src/draggable_manager.dart:183:9`\n\n```\n\n183 │ if (target is Element &&\r\n │ ^^^^^^^^^^^^^^^^^\n\n```\n\nTo reproduce make sure you are using the [lints_core](https://pub.dev/packages/lints) and run `dart analyze lib/src/draggable_manager.dart`\n</details>\n\n<details>\n<summary>\nINFO: The part-of directive uses a library name.\n</summary>\n\n`lib/src/draggable.dart:1:1`\n\n```\n\n1part of dnd;\r\n │ ^^^^^^^^^^^^\n\n```\n\nTo reproduce make sure you are using the [lints_core](https://pub.dev/packages/lints) and run `dart analyze lib/src/draggable.dart`\n</details>\n"
82+
"summary": "### [x] 30/50 points: code has no errors, warnings, lints, or formatting issues\n\nFound 11 issues. Showing the first 2:\n\n<details>\n<summary>\nWARNING: Unnecessary type check; the result is always 'true'.\n</summary>\n\n`lib/src/draggable_manager.dart:183:9`\n\n```\n\n183 │ if (target is Element &&\r\n │ ^^^^^^^^^^^^^^^^^\n\n```\n\nTo reproduce make sure you are using the [lints_core](https://pub.dev/packages/lints) and run `dart analyze lib/src/draggable_manager.dart`\n</details>\n\n<details>\n<summary>\nINFO: 'dart:html' is deprecated and shouldn't be used. Use package:web and dart:js_interop instead.\n</summary>\n\n`lib/dnd.dart:3:1`\n\n```\n\n3import 'dart:html';\r\n │ ^^^^^^^^^^^^^^^^^^^\n\n```\n\nTo reproduce make sure you are using the [lints_core](https://pub.dev/packages/lints) and run `dart analyze lib/dnd.dart`\n</details>\n"
8383
},
8484
{
8585
"id": "dependency",

test/goldens/end2end/dnd-2.0.1.json_report.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ See https://dart.dev/web/wasm for details.
102102

103103
### [x] 30/50 points: code has no errors, warnings, lints, or formatting issues
104104

105-
Found 9 issues. Showing the first 2:
105+
Found 11 issues. Showing the first 2:
106106

107107
<details>
108108
<summary>
@@ -123,19 +123,19 @@ To reproduce make sure you are using the [lints_core](https://pub.dev/packages/l
123123

124124
<details>
125125
<summary>
126-
INFO: The part-of directive uses a library name.
126+
INFO: 'dart:html' is deprecated and shouldn't be used. Use package:web and dart:js_interop instead.
127127
</summary>
128128

129-
`lib/src/draggable.dart:1:1`
129+
`lib/dnd.dart:3:1`
130130

131131
```
132132
133-
1part of dnd;
134-
│ ^^^^^^^^^^^^
133+
3import 'dart:html';
134+
│ ^^^^^^^^^^^^^^^^^^^
135135
136136
```
137137

138-
To reproduce make sure you are using the [lints_core](https://pub.dev/packages/lints) and run `dart analyze lib/src/draggable.dart`
138+
To reproduce make sure you are using the [lints_core](https://pub.dev/packages/lints) and run `dart analyze lib/dnd.dart`
139139
</details>
140140

141141

0 commit comments

Comments
 (0)