Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native_assets_cli] Provide an easier way to re(run) builds #544

Open
dcharkes opened this issue Nov 16, 2023 · 3 comments
Open

[native_assets_cli] Provide an easier way to re(run) builds #544

dcharkes opened this issue Nov 16, 2023 · 3 comments
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute) P3 A lower priority bug or feature request package:native_assets_cli
Milestone
Native Assets v1.x

Comments

@dcharkes
Copy link
Collaborator

Currently the only way to rerun a native assets build build is to invoke: dart path/to/build.dart --config=.dart_tool/native_assets_builder/<some-hash>/config.yaml. This command is printed when a native build fails if -v was passed. Maybe we could provide a better way to run builds.

Possibly: dart run native_assets_cli:build --package=my_package --os=.. --arch=... by adding a bin script to package:native_assets_cli.

@mosuem Did you have any other ideas?
@dcharkes dcharkes added P3 A lower priority bug or feature request package:native_assets_cli labels Nov 16, 2023
@dcharkes dcharkes changed the title [native_assets_cli] Provide a way to re(run) builds [native_assets_cli] Provide an easier way to re(run) builds Nov 16, 2023
@mosuem
Copy link
Member

mosuem commented Nov 16, 2023

dart run native_assets_cli:build should not have any required args, os, arch etc. could have sensible defaults such as the users system.

@dcharkes
Copy link
Collaborator Author

And I guess --package should just default to the current root package as well.

And --link-mode to dynamic library.

And this should live in package:native_assets_cli instead of native_assets_builder, because users wont depend on the latter.

@dcharkes dcharkes added the good first issue A good starting issue for contributors (issues with this label will appear in /contribute) label Nov 16, 2023
@dcharkes
Copy link
Collaborator Author

When we implement this feature, we should either wire it up to dart-lang/sdk#52992, or close that issue as wontfix.

parlough pushed a commit to parlough/native that referenced this issue Apr 8, 2024
@dependabot
[ffigen] Bump subosito/flutter-action from 2.8.0 to 2.10.0 (dart-lang…
0727f8a 
…#544)

Bumps [subosito/flutter-action](https://github.com/subosito/flutter-action) from 2.8.0 to 2.10.0.
- [Release notes](https://github.com/subosito/flutter-action/releases)
- [Commits](subosito/flutter-action@dbf1fa0...48cafc2)

---
updated-dependencies:
- dependency-name: subosito/flutter-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dcharkes dcharkes added this to the Native Assets v1.x milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute) P3 A lower priority bug or feature request package:native_assets_cli
Projects
None yet
Milestone
Native Assets v1.x
Development

No branches or pull requests
2 participants
@dcharkes @mosuem