Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Fix leaker health check #1857

Open
liamappelbe opened this issue Jan 3, 2025 · 2 comments
Open

[ffigen] Fix leaker health check #1857

liamappelbe opened this issue Jan 3, 2025 · 2 comments
Labels
package:ffigen type-infra A repository infrastructure change or enhancement

Comments

@liamappelbe
Copy link
Contributor

A lot of internal classes are being leaked to the public API, causing spurious breaking change reports:

  "breakingChanges": {
    "label": "BREAKING CHANGES",
    "children": [
      {
        "label": "Class ImportedType",
        "children": [
          {
            "label": "Constructor ImportedType",
            "children": [
              {
                "changeDescription": "Kind of parameter \"defaultValue\" changed. not named -> named",
                "changeCode": "CE07",
                "isBreaking": true,
                "type": "major"
              }
            ]
          }
        ]
      }
    ]
  },
@liamappelbe liamappelbe added type-infra A repository infrastructure change or enhancement package:ffigen labels Jan 3, 2025
@dcharkes
Copy link
Collaborator

dcharkes commented Jan 3, 2025

A lot of internal classes are being leaked to the public API

Shouldn't we fix that instead? Is it not fixable? Why not? How do we have to change the code to do so?

(Edit: We should probably have the FFIgen major version bump on (a) breaking changes to FFIgen output, (b) breaking changes to the yaml config, and (c) breaking changes to the public Dart API.)

@liamappelbe liamappelbe added this to the ffigen 17.0.0 (2025 Q1) milestone Jan 5, 2025
@liamappelbe
Copy link
Contributor Author

Shouldn't we fix that instead? Is it not fixable? Why not? How do we have to change the code to do so?

You mean instead of #1858? I will fix it (that's what this bug is tracking), but I wanted to undo the unnecessary version bump first. I haven't investigated the leaks yet, but there's a lot of them and I don't know how much of a refactor it will be. I'll fix it in the next milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ffigen type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants