-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_assets_cli] data assets #154
Labels
Milestone
Comments
I also found |
HosseinYousefi
pushed a commit
that referenced
this issue
Nov 16, 2023
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@8cbef1d...9ba913c) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
HosseinYousefi
pushed a commit
that referenced
this issue
Nov 16, 2023
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@8cbef1d...9ba913c) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Mar 7, 2024
Closed
This was referenced Apr 4, 2024
Package rename is tracked in: |
dcharkes
changed the title
[native_assets_cli] data assets (and should the package be renamed?)
[native_assets_cli] data assets
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Initially, we had the idea that the input and output for
build.dart
would be unstructured JSON/YAML, and that there would be multiple views on top of these JSONs. In this approach,package:native_assets_cli
would be one such view. And we would introduce other views for other types of assets (icons, localization) ...However, after some discussions with @mosuem, we realized that some of the things in the JSON would be better off shared:
BuildOutput
: the dependencies (used for caching -- whether build.dart should be reinvoked). This would also be required for resource shaking in localization.BuildConfig
the targetOS would likely be used for deciding what icons to bundle.If we add a concept of "data assets" to the native assets CLI, then we should reconsider the package name
package:native_assets_cli
to be something likepackage:build_script
instead. (Suggestion taken from @gaaclarke)Dart SDK tracking issue:
Flutter tracking issue:
hook/build.dart
Data assets support flutter/flutter#146264The text was updated successfully, but these errors were encountered: