Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] data assets #154

Open
dcharkes opened this issue Oct 7, 2023 · 2 comments
Open

[native_assets_cli] data assets #154

dcharkes opened this issue Oct 7, 2023 · 2 comments
Labels
P2 A bug or feature request we're likely to work on package:native_assets_cli

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Oct 7, 2023

Initially, we had the idea that the input and output for build.dart would be unstructured JSON/YAML, and that there would be multiple views on top of these JSONs. In this approach, package:native_assets_cli would be one such view. And we would introduce other views for other types of assets (icons, localization) ...

However, after some discussions with @mosuem, we realized that some of the things in the JSON would be better off shared:

  • In the BuildOutput: the dependencies (used for caching -- whether build.dart should be reinvoked). This would also be required for resource shaking in localization.
  • In the BuildConfig the targetOS would likely be used for deciding what icons to bundle.

If we add a concept of "data assets" to the native assets CLI, then we should reconsider the package name package:native_assets_cli to be something like package:build_script instead. (Suggestion taken from @gaaclarke)

For some reason the name "native assets" made it seem like it was only for linking in libraries. IMO "build scripts" is a better name.

Dart SDK tracking issue:

Flutter tracking issue:

@gaaclarke
Copy link

I also found native_assets_cli confusing because the user of the package never actually gets a command-line interface. I thought maybe that was some command-line tool that would setup the environment so that native_assets would work.

HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/coverallsapp/github-action/releases)
- [Commits](coverallsapp/github-action@8cbef1d...9ba913c)

---
updated-dependencies:
- dependency-name: coverallsapp/github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
HosseinYousefi pushed a commit that referenced this issue Nov 16, 2023
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/coverallsapp/github-action/releases)
- [Commits](coverallsapp/github-action@8cbef1d...9ba913c)

---
updated-dependencies:
- dependency-name: coverallsapp/github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dcharkes
Copy link
Collaborator Author

dcharkes commented Apr 4, 2024

Package rename is tracked in:

@dcharkes dcharkes changed the title [native_assets_cli] data assets (and should the package be renamed?) [native_assets_cli] data assets Apr 4, 2024
@dcharkes dcharkes added the P2 A bug or feature request we're likely to work on label Apr 4, 2024
@dcharkes dcharkes added this to the Native Assets v1.x milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on package:native_assets_cli
Projects
None yet
Development

No branches or pull requests

2 participants