Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_builder] When build output changes linker has to re-run #1412

Closed
mkustermann opened this issue Aug 9, 2024 · 1 comment · Fixed by #1515
Closed

[native_assets_builder] When build output changes linker has to re-run #1412

mkustermann opened this issue Aug 9, 2024 · 1 comment · Fixed by #1515
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:native_assets_builder

Comments

@mkustermann
Copy link
Member

Assuming I have a correct build with two data assets with (id1, a.txt) and (id2, b.txt).
I then change the hook/build.dart to use (id1, a.txt) and (id2, a.txt) (same ids but now also same file uri).

Then I observe the hook/build.dart to be re-run, which will result in a different build output.
But the linker step is not re-run, despite the build output changing, instead it prints

Skipping link for ... in ..... Last build on 2024-08-09 14:06:27.000. Last dependencies change on 2024-08-09 13:43:27.000. Last hook change on 2024-08-09 13:35:20.000.

=> Can it be that linker isn't re-run when the build outputs to the linker change?

/cc @dcharkes

@dcharkes dcharkes added package:native_assets_builder P1 A high priority bug; for example, a single project is unusable or has many test failures labels Aug 9, 2024
@dcharkes
Copy link
Collaborator

dcharkes commented Aug 9, 2024

=> Can it be that linker isn't re-run when the build outputs to the linker change?

Probably, and apparently this is not covered by a test case.

Edit: Yep, no test coverage: #827 pkgs/native_assets_builder/test/build_runner/link_test.dart (only non caching tests)

@dcharkes dcharkes added this to the native assets v1.0 milestone Aug 30, 2024
@dcharkes dcharkes changed the title When build output changes linker has to re-run [native_assets_builder] When build output changes linker has to re-run Aug 30, 2024
@dcharkes dcharkes self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:native_assets_builder
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants