Skip to content

Commit beccf58

Browse files
authored
Fix flutter health wf (#1787)
* Fix flutter health wf * change paths * use branch * Ignore swiftgen * Ignore ffigen * disable jnigen * Dont ignore anymore * ignore swiftgen * Fix paths * use package from path * Don't check jnigen * Add changelog * Dont check swift2objc * Use main channel * Rev versions according to breaking change policy * Rev version even more * Run on all branches
1 parent 2251646 commit beccf58

File tree

9 files changed

+23
-35
lines changed

9 files changed

+23
-35
lines changed

.github/workflows/health.yaml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,23 @@
11
name: Health
22
on:
33
pull_request:
4-
branches: [ main ]
54
# Remove paths after https://github.com/bmw-tech/dart_apitool/issues/177 is addressed.
65
paths:
7-
- "pkgs/ffi/**"
8-
- "pkgs/native_assets_builder/**"
9-
- "pkgs/native_assets_cli/**"
10-
- "pkgs/native_toolchain_c/**"
6+
- ".github/workflows/health.yaml"
7+
- "pkgs/**"
118
types: [opened, synchronize, reopened, labeled, unlabeled]
129
jobs:
1310
health:
1411
uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
1512
with:
1613
coverage_web: false
1714
# TODO(https://github.com/dart-lang/native/issues/1242): Add coverage back.
18-
checks: "version,changelog,license,do-not-submit,breaking,leaking"
19-
use-flutter: true
20-
sdk: master
15+
checks: "changelog,license,do-not-submit,breaking,leaking"
16+
flutter_packages: "pkgs/ffigen,pkgs/jni,pkgs/jnigen,pkgs/objective_c"
17+
ignore_license: "**.g.dart"
18+
ignore_coverage: "**.mock.dart,**.g.dart"
19+
ignore_packages: "pkgs/swiftgen,pkgs/jnigen,pkgs/swift2objc"
20+
sdk: dev
21+
channel: master
2122
permissions:
2223
pull-requests: write

.github/workflows/health_flutter.yaml

Lines changed: 0 additions & 21 deletions
This file was deleted.

pkgs/ffigen/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## 16.0.1-wip
1+
## 17.0.0-wip
22

33
- Ensure that required symbols are available to FFI even when the final binary
44
is linked with `-dead_strip`.

pkgs/ffigen/example/shared_bindings/generate.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
2+
// for details. All rights reserved. Use of this source code is governed by a
3+
// BSD-style license that can be found in the LICENSE file.
4+
15
import 'dart:io';
26

37
import 'package:cli_util/cli_util.dart';

pkgs/ffigen/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# BSD-style license that can be found in the LICENSE file.
44

55
name: ffigen
6-
version: 16.0.1-wip
6+
version: 17.0.0-wip
77
description: >
88
Generator for FFI bindings, using LibClang to parse C, Objective-C, and Swift
99
files.

pkgs/jnigen/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
- Fixed a potential name collision when generating in multi-file mode.
88
- Added the ability to add user-defined visitors to config. Currently only
99
capable of excluding classes, methods, and fields.
10+
- Add dependency override for `package:jni` instead of the path dependency.
1011

1112
## 0.12.2
1213

pkgs/jnigen/pubspec.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ dependencies:
3232
dev_dependencies:
3333
build_runner: ^2.4.12
3434
dart_flutter_team_lints: ^3.2.0
35-
jni:
36-
path: ../jni
35+
jni: ^0.12.2
3736
json_serializable: ^6.8.0
3837
test: ^1.25.8
38+
39+
dependency_overrides:
40+
jni:
41+
path: ../jni

pkgs/objective_c/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## 4.0.1-wip
1+
## 4.1.0-wip
22

33
- Reduces the chances of duplicate symbols by adding a `DOBJC_` prefix.
44
- Ensure that required symbols are available to FFI even when the final binary

pkgs/objective_c/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
name: objective_c
66
description: 'A library to access Objective C from Flutter that acts as a support library for package:ffigen.'
7-
version: 4.0.1-wip
7+
version: 4.1.0-wip
88
repository: https://github.com/dart-lang/native/tree/main/pkgs/objective_c
99
issue_tracker: https://github.com/dart-lang/native/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Aobjective_c
1010

0 commit comments

Comments
 (0)