[native_assets_builder] Take packageLayout for build and dryRun (#127)

dart-lang · Sep 12, 2023 · 7f30f4b · 7f30f4b
1 parent a7cd31e
commit 7f30f4b
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 12 deletions.
diff --git a/pkgs/native_assets_builder/CHANGELOG.md b/pkgs/native_assets_builder/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.2.2
+
+- Take a `PackageLayout` argument for `build` and `dryRun`
+  [flutter#134427](https://github.com/flutter/flutter/issues/134427).
+
 ## 0.2.1
 
 - Provide a `PackageLayout` constructor for already parsed `PackageConfig`

diff --git a/pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart b/pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart
@@ -42,9 +42,9 @@ class NativeAssetsBuildRunner {
     IOSSdk? targetIOSSdk,
     int? targetAndroidNdkApi,
     required bool includeParentEnvironment,
+    PackageLayout? packageLayout,
   }) async {
-    final packageLayout =
-        await PackageLayout.fromRootPackageRoot(workingDirectory);
+    packageLayout ??= await PackageLayout.fromRootPackageRoot(workingDirectory);
     final packagesWithNativeAssets =
         await packageLayout.packagesWithNativeAssets;
     final planner = await NativeAssetsBuildPlanner.fromRootPackageRoot(
@@ -118,9 +118,9 @@ class NativeAssetsBuildRunner {
     required OS targetOs,
     required Uri workingDirectory,
     required bool includeParentEnvironment,
+    PackageLayout? packageLayout,
   }) async {
-    final packageLayout =
-        await PackageLayout.fromRootPackageRoot(workingDirectory);
+    packageLayout ??= await PackageLayout.fromRootPackageRoot(workingDirectory);
     final packagesWithNativeAssets =
         await packageLayout.packagesWithNativeAssets;
     final planner = await NativeAssetsBuildPlanner.fromRootPackageRoot(

diff --git a/pkgs/native_assets_builder/pubspec.yaml b/pkgs/native_assets_builder/pubspec.yaml
@@ -1,7 +1,7 @@
 name: native_assets_builder
 description: >-
   This package is the backend that invokes top-level `build.dart` scripts.
-version: 0.2.1
+version: 0.2.2
 repository: https://github.com/dart-lang/native/tree/main/pkgs/native_assets_builder
 
 environment:

diff --git a/pkgs/native_assets_builder/test/build_runner/build_runner_test.dart b/pkgs/native_assets_builder/test/build_runner/build_runner_test.dart
@@ -4,6 +4,7 @@
 
 import 'dart:io';
 
+import 'package:native_assets_builder/native_assets_builder.dart';
 import 'package:test/test.dart';
 
 import '../helpers.dart';
@@ -36,15 +37,25 @@ void main() async {
       }
 
       // Trigger a build, should not invoke anything.
-      {
+      for (final passPackageLayout in [true, false]) {
+        PackageLayout? packageLayout;
+        if (passPackageLayout) {
+          packageLayout = await PackageLayout.fromRootPackageRoot(packageUri);
+        }
         final logMessages = <String>[];
-        final result = await build(packageUri, logger, dartExecutable,
-            capturedLogs: logMessages);
+        final result = await build(
+          packageUri,
+          logger,
+          dartExecutable,
+          capturedLogs: logMessages,
+          packageLayout: packageLayout,
+        );
         expect(
-            false,
-            logMessages
-                .join('\n')
-                .contains('native_add${Platform.pathSeparator}build.dart'));
+          false,
+          logMessages
+              .join('\n')
+              .contains('native_add${Platform.pathSeparator}build.dart'),
+        );
         expect(result.assets.length, 1);
       }
     });

diff --git a/pkgs/native_assets_builder/test/build_runner/helpers.dart b/pkgs/native_assets_builder/test/build_runner/helpers.dart
@@ -34,6 +34,7 @@ Future<BuildResult> build(
   CCompilerConfig? cCompilerConfig,
   bool includeParentEnvironment = true,
   List<String>? capturedLogs,
+  PackageLayout? packageLayout,
 }) async {
   StreamSubscription<LogRecord>? subscription;
   if (capturedLogs != null) {
@@ -51,6 +52,7 @@ Future<BuildResult> build(
     workingDirectory: packageUri,
     cCompilerConfig: cCompilerConfig,
     includeParentEnvironment: includeParentEnvironment,
+    packageLayout: packageLayout,
   );
   if (result.success) {
     await expectAssetsExist(result.assets);
@@ -71,6 +73,7 @@ Future<DryRunResult> dryRun(
   CCompilerConfig? cCompilerConfig,
   bool includeParentEnvironment = true,
   List<String>? capturedLogs,
+  PackageLayout? packageLayout,
 }) async {
   StreamSubscription<LogRecord>? subscription;
   if (capturedLogs != null) {
@@ -86,6 +89,7 @@ Future<DryRunResult> dryRun(
     targetOs: Target.current.os,
     workingDirectory: packageUri,
     includeParentEnvironment: includeParentEnvironment,
+    packageLayout: packageLayout,
   );
 
   if (subscription != null) {