Skip to content

Commit 7c51e74

Browse files
committed
[native_toolchain_c] Fix MSVC x86 toolchain resolution
1 parent 07e1de5 commit 7c51e74

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

pkgs/native_toolchain_c/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.2.3
2+
3+
- Fix MSVC tool resolution inside (x86) folder
4+
([#123](https://github.com/dart-lang/native/issues/123)).
5+
16
## 0.2.2
27

38
- Generate position independent code for libraries by default and add

pkgs/native_toolchain_c/lib/src/native_toolchain/msvc.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import 'dart:io';
66

7+
import 'package:glob/glob.dart';
78
import 'package:logging/logging.dart';
89
import 'package:native_assets_cli/native_assets_cli.dart';
910

@@ -71,7 +72,7 @@ Tool vcvars(ToolInstance toolInstance) {
7172
defaultResolver: InstallLocationResolver(
7273
toolName: fileName,
7374
paths: [
74-
batchScript.toFilePath().replaceAll('\\', '/'),
75+
Glob.quote(batchScript.toFilePath()),
7576
],
7677
),
7778
);

pkgs/native_toolchain_c/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: native_toolchain_c
22
description: >-
33
A library to invoke the native C compiler installed on the host machine.
4-
version: 0.2.2
4+
version: 0.2.3
55
repository: https://github.com/dart-lang/native/tree/main/pkgs/native_toolchain_c
66

77
topics:

0 commit comments

Comments
 (0)