add super initializer example #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Jan 24, 2022
lib/src/rules/type_init_formals.dart
Outdated
| @@ -16,8 +16,8 @@ From the [style guide](https://dart.dev/guides/language/effective-dart/style/): | |||
|
|
|||
| **DON'T** type annotate initializing formals. | |||
|
|
|||
| If a constructor parameter is using `this.x` to initialize a field, then the | |||
| type of the parameter is understood to be the same type as the field. | |||
| If a constructor parameter is using `this.x` or `super.x` to initialize a field, | |||
There was a problem hiding this comment.
Kind of a nit, but super.x doesn't initialize a field, so this might be confusing.
There was a problem hiding this comment.
Ah, let's get it right.
How about:
If a constructor parameter is using `this.x` to initialize a field or `super.x` to forward to a super constructor,
There was a problem hiding this comment.
That sounds good for the first part. The "same type as the field" on the next line will also need to be updated. Once you do that it might be clearer if you just split it into two sentences, but I don't know for sure because I haven't tried writing it.
There was a problem hiding this comment.
I see your point. I gave it a shot in two sentences. PTAL.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
* add super initializer example * tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #3131
/cc @bwilkerson