Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gh documentation pages docs to Jekyll #949

Closed
pq opened this issue Mar 28, 2018 · 20 comments
Closed

Migrate gh documentation pages docs to Jekyll #949

pq opened this issue Mar 28, 2018 · 20 comments
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P2 A bug or feature request we're likely to work on type-documentation A request to add or improve documentation

Comments

@pq
Copy link
Member

pq commented Mar 28, 2018

It's not clear when this will auto-migrate but when it does it will break our docs on https://dart-lang.github.io/linter/.

image

@pq pq added Priority-High type-documentation A request to add or improve documentation labels Mar 28, 2018
@pq pq added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label Jun 21, 2018
@pq
Copy link
Member Author

pq commented Jul 20, 2018

We might also consider an alternative to GH Pages, such as https://readthedocs.org/.

Thoughts from folks w/ relevant experience welcome!

@zoechi
Copy link

zoechi commented Jul 20, 2018

@chalin ?

@chalin
Copy link
Contributor

chalin commented Jul 20, 2018

Thanks for the ping @zoechi!

Why not host the docs on https://www.dartlang.org? /cc @kwalrath @kevmoo

Just curious, are the individual pages created by hand or auto-generated? If created by hand, they would be must easier to read and maintain in markdown format.

@pq
Copy link
Member Author

pq commented Jul 20, 2018

Thanks for chiming in!

Just curious, are the individual pages created by hand or auto-generated?

They're generated by a script. I run it manually for releases and update the gh-pages branch.

@kwalrath
Copy link
Contributor

At one point, we migrated a lot of tools docs off of www.dartlang.org, since in-repo docs were more likely to be kept up to date. If we could keep the source in individual repos yet display them on www.dartlang.org, that would be great.

@chalin
Copy link
Contributor

chalin commented Jul 20, 2018

If we could keep the source in individual repos yet display them on www.dartlang.org, that would be great.

Yes we can do that using submodules (which is what we are doing for the Angular engineering notes of site-webdev).

@chalin
Copy link
Contributor

chalin commented Jul 20, 2018

@kwalrath - shall we pursue this option?
@pq - I see that this is marked as High priority. Is there a time limit, and if so, what is it?

@pq
Copy link
Member Author

pq commented Jul 20, 2018

@chalin : I honestly don't know. That sort of scary threat still shows up in settings but is not specific about when it will happen.

@kwalrath : can you point me to any examples of tools that have their docs displayed on dartlang?

One thing to keep in mind is that the linter is on a very different release cadence from the SDK. This has a few consequences:

  1. docs are getting (re)generated roughly weekly if not more frequently
  2. there's an unsolved issue of seeing what linter docs correspond to the specific linter shipped with an SDK

The second issue has been around forever and hasn't bothered anyone that I'm aware of but it's worth mentioning if linter docs are going to get more promoted.

@kwalrath
Copy link
Contributor

The angular notes are under https://webdev.dartlang.org/angular/note. (They're extracted from https://github.com/dart-lang/angular/tree/master/doc, which we should probably say on that page, along with version info...)

@chalin
Copy link
Contributor

chalin commented Jul 20, 2018

there's an unsolved issue of seeing what linter docs correspond to the specific linter shipped with an SDK

Well, this could be resolved by hosting the docs on pub. Let me explain: pub now hosts API docs. Each individual lint's "doc" page is rather simple, so the lint's documentation could be written as API docs over the lint rule's class.

@pq
Copy link
Member Author

pq commented Jul 20, 2018

Thanks @kwalrath!

Regarding versioning another wrinkle is that we generally work from master and only publish docs when we cut a release branch. We might rethink if there's an opportunity to have docs pulled more dynamically. (Anyway, that'd be a good conversation to have.)

As for hosting on pub @chalin, that's another interesting idea. I don't see these quite as API docs but maybe that'd work. Are there any examples of folks hosting anything unusual on pub?

Also note we do have a few pages: an index, a page w/ default options plus pages for each lint (and would likely want the flexibility to add more).

https://github.com/dart-lang/linter/tree/gh-pages

How would that look on pub?

@chalin
Copy link
Contributor

chalin commented Jul 20, 2018

Regarding versioning another wrinkle is that we generally work from master and only publish docs when we cut a release branch.

If you place linter docs under pub/documentation, then that works out.

Are there any examples of folks hosting anything unusual on pub?

I'm not aware of anything unusual, but API docs can make use of any markdown. E.g., see the API docs landing page for the test package: https://pub.dartlang.org/documentation/test/latest

Also note we do have a few pages: an index, a page w/ default options plus pages for each lint (and would likely want the flexibility to add more).

The index page could be part of the linter API doc landing page. For the options, I'm not sure.

I could prototype an addition of these pages to dartlang.org, but it might take a while before I can do that.

@chalin
Copy link
Contributor

chalin commented Jul 20, 2018

Of course, another option is to leave the docs where they are and just embrace the migration to Jekyll :).

@pq
Copy link
Member Author

pq commented Jul 20, 2018

Thanks for the context @chalin!

Looking at https://www.dartlang.org/tools/pub/pubspec#documentation, I see:

If you specify the documentation: field with a blank value, documentation is created automatically for you, and is linked to from pub.dartlang.com.

I don't see this explained anywhere. Is it documented somewhere?

Of course, another option is to leave the docs where they are and just embrace the migration to Jekyll

😄

This was what I initially thought we'd do but I'm happy to be exploring the options!

@chalin
Copy link
Contributor

chalin commented Jul 20, 2018

pub.dartlang.com

That's a typo, which I'll fix now (.com -> .org).

I don't see this explained anywhere. Is it documented somewhere?

Which part? By "documentation is created automatically", I believe that they are referring to API docs. And I think that the API docs are created even if the documentation field is present: e.g., see the https://pub.dartlang.org/packages/angular page:

screen shot 2018-07-20 at 17 23 29

cc @kevmoo

@pq
Copy link
Member Author

pq commented Jul 20, 2018

I believe that they are referring to API docs.

Ah, OK. Not relevant here then. Thanks!

@chalin
Copy link
Contributor

chalin commented Aug 10, 2018

Btw, looking at analytics, I see that folks are looking for lints on dartlang.org :). I'm going to add a redirect rule for now.

@chalin
Copy link
Contributor

chalin commented Jan 4, 2019

Just curious if this is still an issue.

@pq
Copy link
Member Author

pq commented Jan 4, 2019

Yep. I think it is.

@pq pq removed the Priority-High label Nov 14, 2019
@pq pq removed their assignment Nov 14, 2019
@srawlins srawlins added the P2 A bug or feature request we're likely to work on label Sep 22, 2022
@parlough
Copy link
Member

I’m going to close this as the docs now live at https://dart.dev/lints and future work is being tracked on https://github.com/dart-lang/site-www. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P2 A bug or feature request we're likely to work on type-documentation A request to add or improve documentation
Projects
None yet
Development

No branches or pull requests

6 participants