Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of unrelated might be wrong #4878

Open
bwilkerson opened this issue Feb 12, 2024 · 0 comments
Open

Definition of unrelated might be wrong #4878

bwilkerson opened this issue Feb 12, 2024 · 0 comments
Labels
P2 A bug or feature request we're likely to work on set-core Affects a rule in the core Dart rule set type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@bwilkerson
Copy link
Member

The method typesAreUnrelated currently considers a non-nullable type, such as String to be potentially related to the type Null. That seems wrong to me.

We should consider changing the method so that it returns true in such cases. (Though I haven't done any work to see what the implications of such a change would be.)
@pq pq added set-core Affects a rule in the core Dart rule set P2 A bug or feature request we're likely to work on labels Feb 14, 2024
@srawlins srawlins added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on set-core Affects a rule in the core Dart rule set type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @bwilkerson