False positive: avoid_types_on_closure_parameters on closure assigned to a variable.

[hamsbrar]

void main() {
  var _fn = (String name) => name.toUpperCase();
  //           ^ Unnecessary type annotation on a function expression parameter. Try removing the type annotation.
  _fn('a');

And if I remove the type hint:

void main() {
  var _fn = (name) => name.toUpperCase();
  //           ^ The type of name can't be inferred; a type must be explicitly provided.

> dart --version
Dart SDK version: 3.0.6 (stable) (Tue Jul 11 18:49:07 2023 +0000) on "linux_x64"

Actual example:

class GenerateUserRoleActionTemplateFor {
  static createPostWatchQuotaLifetime(bool self, TypePostWatch type) => _createPostWatchQuotaLifetime(self, type);
  // ...
}

// top-level
final _createPostWatchQuotaLifetime = (bool self, TypePostWatch type) =>
    //                                 ~~~~       ~~~~~~~~~~~~~
    __unlimitedCheck +
    '''
        \$userId = \$userModel->getId();

        \$countLifetime = ( new Query( TypeTable::POST_WATCH, true ) )
            ->${self ? 'where' : 'whereNot'}( TypeTablePostWatch::POST_USER_ID, \$userId )
            ->where( TypeTablePostWatch::WATCHER_USER_ID, \$userId )
            ->where( TypeTablePostWatch::TYPE, TypePostWatch::${TypedString.fromCamelCase(type.name).snakeCase.upperCase.toString()} )
            ->count();

        return CoreNumber::from( \$this->\$\$settingCamelCase  ) > \$countLifetime;
''';

[hamsbrar]

Further investigation shows that it's because of using the lint avoid_types_on_closure_parameters and strict-inference in conjunction. Both VSCodium and VSCode shows the same warning with following analysis options:

analyzer:
  language:
    strict-inference: true

linter:
  rules:
    - avoid_types_on_closure_parameters

[lrhn]

Seems like a lint issue. Moving to linter repo.

[srawlins]

Looks like a duplicate of #1099