Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use package test. #302

Closed
pq opened this issue Sep 5, 2016 · 1 comment
Closed

Update tests to use package test. #302

pq opened this issue Sep 5, 2016 · 1 comment
Assignees
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@pq
Copy link
Member

pq commented Sep 5, 2016

Looks like mockito has become unittest unfriendly:

ERROR: pubspec | visiting | smoke
  Test failed: Caught Bad state: expect() may only be called within a test.
  package:test/src/frontend/expect.dart 49:5           expect
  package:mockito/src/mock.dart 458:5                  VerificationResult.called
  test/pub_test.dart 118:46                            defineTests.<fn>.<fn>.<fn>
  package:unittest/src/internal_test_case.dart 120:37  InternalTestCase.run.<fn>
  dart:async/zone.dart 1158                            _rootRunUnary
  dart:async/zone.dart 1037                            _CustomZone.runUnary
  dart:async/future_impl.dart 131                      _FutureListener.handleValue
  dart:async/future_impl.dart 637                      _Future._propagateToListeners.handleValueCallback
  dart:async/future_impl.dart 667                      _Future._propagateToListeners
  dart:async/future_impl.dart 477                      _Future._completeWithValue
  dart:async/future_impl.dart 528                      _Future._asyncComplete.<fn>
  dart:async/zone.dart 1150                            _rootRun
  dart:async/zone.dart 1026                            _CustomZone.run
  dart:async/zone.dart 924                             _CustomZone.runGuarded
  dart:async/zone.dart 951                             _CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                _microtaskLoop
  dart:async/schedule_microtask.dart 50                _startMicrotaskLoop
  dart:isolate-patch/timer_impl.dart 394               _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414               _Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148            _RawReceivePortImpl._handleMessage

forcing our hand to move to test. :(

@pq pq added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Sep 5, 2016
@pq
Copy link
Member Author

pq commented Sep 5, 2016

Fix out for review: https://codereview.chromium.org/2310833003/

@pq pq self-assigned this Sep 5, 2016
@pq pq closed this as completed in a564865 Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

1 participant