Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment_references BAD example has no comment #1879

Closed
srawlins opened this issue Dec 8, 2019 · 1 comment · Fixed by #1884
Closed

comment_references BAD example has no comment #1879

srawlins opened this issue Dec 8, 2019 · 1 comment · Fixed by #1884
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-documentation A request to add or improve documentation

Comments

@srawlins
Copy link
Member

srawlins commented Dec 8, 2019

The BAD example of comment_references doesn't have... a comment:

http://dart-lang.github.io/linter/lints/comment_references.html
@pq
Copy link
Member

pq commented Dec 8, 2019

Oh my 😬.

Good catch!

@pq pq added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-documentation A request to add or improve documentation labels Dec 8, 2019
This was referenced Dec 10, 2019
Open
Merged
@pq pq closed this as completed in #1884 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-documentation A request to add or improve documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update BAD sample dart-lang/linter
2 participants
@pq @srawlins