-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type_annotate_public_apis reports issues over local non-API functions #1108
Comments
Agreed!
…On Fri, Aug 3, 2018 at 2:02 PM Patrice Chalin ***@***.***> wrote:
Consider the local good() function declared in this test:
test('foo', () {
good() { ... }
expect(good, ...);
});
The type_annotate_public_apis lint causes this issue to be reported:
lint • Type annotate public APIs at test/effective_dart_test.dart:28:7 • type_annotate_public_apis
Being a local function, good() should not be considered in this lint.
cc @munificent <https://github.com/munificent> @kevmoo
<https://github.com/kevmoo>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1108>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCiszTrBYaxgbPyB3ILdYGYMbHHXo3ks5uNLpNgaJpZM4VunEv>
.
|
+1. Good catch! |
Ouch, also methods of private classes. class _C {
m() {} // BAD LINT
} |
Can you add a comment here once this is released publicly? |
I can't promise that. I wish there was a bot for such things. |
@chalin, @srawlins: I'm curious if you have any thoughts on how we could do better at documenting and publicizing releases. I'm very open to a bot actually if we could decide what exactly it should do. One thing that occurs to me right away is that the published lint docs reflect HEAD but there's no easy way to see what is defined in a particular SDK. I don't want to clutter the docs w/ badges but maybe something could be done? For example, what if we added an SDK badge w/ the number of the minimum supporting SDK? |
❤️ ❤️ ❤️ |
+10, love that idea. Would be very simple to implement with a String API on each rule. |
Consider the local
good()
function declared in this test:The
type_annotate_public_apis
lint causes this issue to be reported:Being a local function,
good()
should not be considered in this lint.cc @munificent @kevmoo
The text was updated successfully, but these errors were encountered: