From d5efd6618a1f8ad9aa40693b9f008f0140467777 Mon Sep 17 00:00:00 2001
From: Phil Quitslund <pq@users.noreply.github.com>
Date: Fri, 11 Feb 2022 09:54:31 -0800
Subject: [PATCH] add `_test` suffix to rule tests (#3228)

---
 test/rules/all.dart                           | 83 ++++++++++---------
 ...ides.dart => annotate_overrides_test.dart} |  0
 ...> avoid_annotating_with_dynamic_test.dart} |  0
 ....dart => avoid_final_parameters_test.dart} |  0
 ...ction_literals_in_foreach_calls_test.dart} |  0
 ...null.dart => avoid_init_to_null_test.dart} |  0
 ...avoid_redundant_argument_values_test.dart} |  0
 ...void_renaming_method_parameters_test.dart} |  0
 ...is.dart => avoid_returning_this_test.dart} |  0
 ...avoid_shadowing_type_parameters_test.dart} |  0
 ... avoid_types_as_parameter_names_test.dart} |  0
 ...d_unused_constructor_parameters_test.dart} |  0
 ... conditional_uri_does_not_exist_test.dart} |  0
 ....dart => deprecated_consistency_test.dart} |  0
 .../{file_names.dart => file_names_test.dart} |  0
 ..._equals.dart => hash_and_equals_test.dart} |  0
 ...iteral_only_boolean_expressions_test.dart} |  0
 ...espace_between_adjacent_strings_test.dart} |  0
 ...> non_constant_identifier_names_test.dart} |  0
 ..._closures.dart => null_closures_test.dart} |  0
 ...rt => omit_local_variable_types_test.dart} |  0
 ...ields.dart => overridden_fields_test.dart} |  0
 ...er_asserts_in_initializer_lists_test.dart} |  0
 ...t => prefer_collection_literals_test.dart} |  0
 ...onst_constructors_in_immutables_test.dart} |  0
 ...rt => prefer_const_constructors_test.dart} |  0
 ...t_literals_to_create_immutables_test.dart} |  0
 ...ontains.dart => prefer_contains_test.dart} |  0
 ...prefer_equal_for_default_values_test.dart} |  0
 ...lds.dart => prefer_final_fields_test.dart} |  0
 ...dart => prefer_final_parameters_test.dart} |  0
 ...r_generic_function_type_aliases_test.dart} |  0
 ...rt => prefer_spread_collections_test.dart} |  0
 ...es_last.dart => super_goes_last_test.dart} |  0
 ...en_type_of_initializing_formals_test.dart} |  0
 ...rmals.dart => type_init_formals_test.dart} |  0
 ...tures.dart => unawaited_futures_test.dart} |  0
 ... => unnecessary_getters_setters_test.dart} |  0
 ...dart => unnecessary_null_checks_test.dart} |  0
 ...s.dart => unnecessary_overrides_test.dart} |  0
 ... use_is_even_rather_than_modulo_test.dart} |  0
 ...void_checks.dart => void_checks_test.dart} |  0
 42 files changed, 44 insertions(+), 39 deletions(-)
 rename test/rules/{annotate_overrides.dart => annotate_overrides_test.dart} (100%)
 rename test/rules/{avoid_annotating_with_dynamic.dart => avoid_annotating_with_dynamic_test.dart} (100%)
 rename test/rules/{avoid_final_parameters.dart => avoid_final_parameters_test.dart} (100%)
 rename test/rules/{avoid_function_literals_in_foreach_calls.dart => avoid_function_literals_in_foreach_calls_test.dart} (100%)
 rename test/rules/{avoid_init_to_null.dart => avoid_init_to_null_test.dart} (100%)
 rename test/rules/{avoid_redundant_argument_values.dart => avoid_redundant_argument_values_test.dart} (100%)
 rename test/rules/{avoid_renaming_method_parameters.dart => avoid_renaming_method_parameters_test.dart} (100%)
 rename test/rules/{avoid_returning_this.dart => avoid_returning_this_test.dart} (100%)
 rename test/rules/{avoid_shadowing_type_parameters.dart => avoid_shadowing_type_parameters_test.dart} (100%)
 rename test/rules/{avoid_types_as_parameter_names.dart => avoid_types_as_parameter_names_test.dart} (100%)
 rename test/rules/{avoid_unused_constructor_parameters.dart => avoid_unused_constructor_parameters_test.dart} (100%)
 rename test/rules/{conditional_uri_does_not_exist.dart => conditional_uri_does_not_exist_test.dart} (100%)
 rename test/rules/{deprecated_consistency.dart => deprecated_consistency_test.dart} (100%)
 rename test/rules/{file_names.dart => file_names_test.dart} (100%)
 rename test/rules/{hash_and_equals.dart => hash_and_equals_test.dart} (100%)
 rename test/rules/{literal_only_boolean_expressions.dart => literal_only_boolean_expressions_test.dart} (100%)
 rename test/rules/{missing_whitespace_between_adjacent_strings.dart => missing_whitespace_between_adjacent_strings_test.dart} (100%)
 rename test/rules/{non_constant_identifier_names.dart => non_constant_identifier_names_test.dart} (100%)
 rename test/rules/{null_closures.dart => null_closures_test.dart} (100%)
 rename test/rules/{omit_local_variable_types.dart => omit_local_variable_types_test.dart} (100%)
 rename test/rules/{overridden_fields.dart => overridden_fields_test.dart} (100%)
 rename test/rules/{prefer_asserts_in_initializer_lists.dart => prefer_asserts_in_initializer_lists_test.dart} (100%)
 rename test/rules/{prefer_collection_literals.dart => prefer_collection_literals_test.dart} (100%)
 rename test/rules/{prefer_const_constructors_in_immutables.dart => prefer_const_constructors_in_immutables_test.dart} (100%)
 rename test/rules/{prefer_const_constructors.dart => prefer_const_constructors_test.dart} (100%)
 rename test/rules/{prefer_const_literals_to_create_immutables.dart => prefer_const_literals_to_create_immutables_test.dart} (100%)
 rename test/rules/{prefer_contains.dart => prefer_contains_test.dart} (100%)
 rename test/rules/{prefer_equal_for_default_values.dart => prefer_equal_for_default_values_test.dart} (100%)
 rename test/rules/{prefer_final_fields.dart => prefer_final_fields_test.dart} (100%)
 rename test/rules/{prefer_final_parameters.dart => prefer_final_parameters_test.dart} (100%)
 rename test/rules/{prefer_generic_function_type_aliases.dart => prefer_generic_function_type_aliases_test.dart} (100%)
 rename test/rules/{prefer_spread_collections.dart => prefer_spread_collections_test.dart} (100%)
 rename test/rules/{super_goes_last.dart => super_goes_last_test.dart} (100%)
 rename test/rules/{tighten_type_of_initializing_formals.dart => tighten_type_of_initializing_formals_test.dart} (100%)
 rename test/rules/{type_init_formals.dart => type_init_formals_test.dart} (100%)
 rename test/rules/{unawaited_futures.dart => unawaited_futures_test.dart} (100%)
 rename test/rules/{unnecessary_getters_setters.dart => unnecessary_getters_setters_test.dart} (100%)
 rename test/rules/{unnecessary_null_checks.dart => unnecessary_null_checks_test.dart} (100%)
 rename test/rules/{unnecessary_overrides.dart => unnecessary_overrides_test.dart} (100%)
 rename test/rules/{use_is_even_rather_than_modulo.dart => use_is_even_rather_than_modulo_test.dart} (100%)
 rename test/rules/{void_checks.dart => void_checks_test.dart} (100%)

diff --git a/test/rules/all.dart b/test/rules/all.dart
index b36296be4..09671a55a 100644
--- a/test/rules/all.dart
+++ b/test/rules/all.dart
@@ -2,58 +2,63 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'annotate_overrides.dart' as annotate_overrides;
-import 'avoid_annotating_with_dynamic.dart' as avoid_annotating_with_dynamic;
-import 'avoid_function_literals_in_foreach_calls.dart'
+import 'annotate_overrides_test.dart' as annotate_overrides;
+import 'avoid_annotating_with_dynamic_test.dart'
+    as avoid_annotating_with_dynamic;
+import 'avoid_function_literals_in_foreach_calls_test.dart'
     as avoid_function_literals_in_foreach_calls;
-import 'avoid_init_to_null.dart' as avoid_init_to_null;
-import 'avoid_redundant_argument_values.dart'
+import 'avoid_init_to_null_test.dart' as avoid_init_to_null;
+import 'avoid_redundant_argument_values_test.dart'
     as avoid_redundant_argument_values;
-import 'avoid_renaming_method_parameters.dart'
+import 'avoid_renaming_method_parameters_test.dart'
     as avoid_renaming_method_parameters;
-import 'avoid_returning_this.dart' as avoid_returning_this;
-import 'avoid_shadowing_type_parameters.dart'
+import 'avoid_returning_this_test.dart' as avoid_returning_this;
+import 'avoid_shadowing_type_parameters_test.dart'
     as avoid_shadowing_type_parameters;
-import 'avoid_types_as_parameter_names.dart' as avoid_types_as_parameter_names;
-import 'avoid_unused_constructor_parameters.dart'
+import 'avoid_types_as_parameter_names_test.dart'
+    as avoid_types_as_parameter_names;
+import 'avoid_unused_constructor_parameters_test.dart'
     as avoid_unused_constructor_parameters;
-import 'conditional_uri_does_not_exist.dart' as conditional_uri_does_not_exist;
-import 'deprecated_consistency.dart' as deprecated_consistency;
-import 'file_names.dart' as file_names;
-import 'hash_and_equals.dart' as hash_and_equals;
-import 'literal_only_boolean_expressions.dart'
+import 'conditional_uri_does_not_exist_test.dart'
+    as conditional_uri_does_not_exist;
+import 'deprecated_consistency_test.dart' as deprecated_consistency;
+import 'file_names_test.dart' as file_names;
+import 'hash_and_equals_test.dart' as hash_and_equals;
+import 'literal_only_boolean_expressions_test.dart'
     as literal_only_boolean_expressions;
-import 'missing_whitespace_between_adjacent_strings.dart'
+import 'missing_whitespace_between_adjacent_strings_test.dart'
     as missing_whitespace_between_adjacent_strings;
-import 'non_constant_identifier_names.dart' as non_constant_identifier_names;
-import 'null_closures.dart' as null_closures;
-import 'omit_local_variable_types.dart' as omit_local_variable_types;
-import 'overridden_fields.dart' as overridden_fields;
-import 'prefer_asserts_in_initializer_lists.dart'
+import 'non_constant_identifier_names_test.dart'
+    as non_constant_identifier_names;
+import 'null_closures_test.dart' as null_closures;
+import 'omit_local_variable_types_test.dart' as omit_local_variable_types;
+import 'overridden_fields_test.dart' as overridden_fields;
+import 'prefer_asserts_in_initializer_lists_test.dart'
     as prefer_asserts_in_initializer_lists;
-import 'prefer_collection_literals.dart' as prefer_collection_literals;
-import 'prefer_const_constructors.dart' as prefer_const_constructors;
-import 'prefer_const_constructors_in_immutables.dart'
+import 'prefer_collection_literals_test.dart' as prefer_collection_literals;
+import 'prefer_const_constructors_in_immutables_test.dart'
     as prefer_const_constructors_in_immutables;
-import 'prefer_const_literals_to_create_immutables.dart'
+import 'prefer_const_constructors_test.dart' as prefer_const_constructors;
+import 'prefer_const_literals_to_create_immutables_test.dart'
     as prefer_const_literals_to_create_immutables;
-import 'prefer_contains.dart' as prefer_contains;
-import 'prefer_equal_for_default_values.dart'
+import 'prefer_contains_test.dart' as prefer_contains;
+import 'prefer_equal_for_default_values_test.dart'
     as prefer_equal_for_default_values;
-import 'prefer_final_fields.dart' as prefer_final_fields;
-import 'prefer_generic_function_type_aliases.dart'
+import 'prefer_final_fields_test.dart' as prefer_final_fields;
+import 'prefer_generic_function_type_aliases_test.dart'
     as prefer_generic_function_type_aliases;
-import 'prefer_spread_collections.dart' as prefer_spread_collections;
-import 'super_goes_last.dart' as super_goes_last;
-import 'tighten_type_of_initializing_formals.dart'
+import 'prefer_spread_collections_test.dart' as prefer_spread_collections;
+import 'super_goes_last_test.dart' as super_goes_last;
+import 'tighten_type_of_initializing_formals_test.dart'
     as tighten_type_of_initializing_formals;
-import 'type_init_formals.dart' as type_init_formals;
-import 'unawaited_futures.dart' as unawaited_futures;
-import 'unnecessary_getters_setters.dart' as unnecessary_getters_setters;
-import 'unnecessary_null_checks.dart' as unnecessary_null_checks;
-import 'unnecessary_overrides.dart' as unnecessary_overrides;
-import 'use_is_even_rather_than_modulo.dart' as use_is_even_rather_than_modulo;
-import 'void_checks.dart' as void_checks;
+import 'type_init_formals_test.dart' as type_init_formals;
+import 'unawaited_futures_test.dart' as unawaited_futures;
+import 'unnecessary_getters_setters_test.dart' as unnecessary_getters_setters;
+import 'unnecessary_null_checks_test.dart' as unnecessary_null_checks;
+import 'unnecessary_overrides_test.dart' as unnecessary_overrides;
+import 'use_is_even_rather_than_modulo_test.dart'
+    as use_is_even_rather_than_modulo;
+import 'void_checks_test.dart' as void_checks;
 
 void main() {
   annotate_overrides.main();
diff --git a/test/rules/annotate_overrides.dart b/test/rules/annotate_overrides_test.dart
similarity index 100%
rename from test/rules/annotate_overrides.dart
rename to test/rules/annotate_overrides_test.dart
diff --git a/test/rules/avoid_annotating_with_dynamic.dart b/test/rules/avoid_annotating_with_dynamic_test.dart
similarity index 100%
rename from test/rules/avoid_annotating_with_dynamic.dart
rename to test/rules/avoid_annotating_with_dynamic_test.dart
diff --git a/test/rules/avoid_final_parameters.dart b/test/rules/avoid_final_parameters_test.dart
similarity index 100%
rename from test/rules/avoid_final_parameters.dart
rename to test/rules/avoid_final_parameters_test.dart
diff --git a/test/rules/avoid_function_literals_in_foreach_calls.dart b/test/rules/avoid_function_literals_in_foreach_calls_test.dart
similarity index 100%
rename from test/rules/avoid_function_literals_in_foreach_calls.dart
rename to test/rules/avoid_function_literals_in_foreach_calls_test.dart
diff --git a/test/rules/avoid_init_to_null.dart b/test/rules/avoid_init_to_null_test.dart
similarity index 100%
rename from test/rules/avoid_init_to_null.dart
rename to test/rules/avoid_init_to_null_test.dart
diff --git a/test/rules/avoid_redundant_argument_values.dart b/test/rules/avoid_redundant_argument_values_test.dart
similarity index 100%
rename from test/rules/avoid_redundant_argument_values.dart
rename to test/rules/avoid_redundant_argument_values_test.dart
diff --git a/test/rules/avoid_renaming_method_parameters.dart b/test/rules/avoid_renaming_method_parameters_test.dart
similarity index 100%
rename from test/rules/avoid_renaming_method_parameters.dart
rename to test/rules/avoid_renaming_method_parameters_test.dart
diff --git a/test/rules/avoid_returning_this.dart b/test/rules/avoid_returning_this_test.dart
similarity index 100%
rename from test/rules/avoid_returning_this.dart
rename to test/rules/avoid_returning_this_test.dart
diff --git a/test/rules/avoid_shadowing_type_parameters.dart b/test/rules/avoid_shadowing_type_parameters_test.dart
similarity index 100%
rename from test/rules/avoid_shadowing_type_parameters.dart
rename to test/rules/avoid_shadowing_type_parameters_test.dart
diff --git a/test/rules/avoid_types_as_parameter_names.dart b/test/rules/avoid_types_as_parameter_names_test.dart
similarity index 100%
rename from test/rules/avoid_types_as_parameter_names.dart
rename to test/rules/avoid_types_as_parameter_names_test.dart
diff --git a/test/rules/avoid_unused_constructor_parameters.dart b/test/rules/avoid_unused_constructor_parameters_test.dart
similarity index 100%
rename from test/rules/avoid_unused_constructor_parameters.dart
rename to test/rules/avoid_unused_constructor_parameters_test.dart
diff --git a/test/rules/conditional_uri_does_not_exist.dart b/test/rules/conditional_uri_does_not_exist_test.dart
similarity index 100%
rename from test/rules/conditional_uri_does_not_exist.dart
rename to test/rules/conditional_uri_does_not_exist_test.dart
diff --git a/test/rules/deprecated_consistency.dart b/test/rules/deprecated_consistency_test.dart
similarity index 100%
rename from test/rules/deprecated_consistency.dart
rename to test/rules/deprecated_consistency_test.dart
diff --git a/test/rules/file_names.dart b/test/rules/file_names_test.dart
similarity index 100%
rename from test/rules/file_names.dart
rename to test/rules/file_names_test.dart
diff --git a/test/rules/hash_and_equals.dart b/test/rules/hash_and_equals_test.dart
similarity index 100%
rename from test/rules/hash_and_equals.dart
rename to test/rules/hash_and_equals_test.dart
diff --git a/test/rules/literal_only_boolean_expressions.dart b/test/rules/literal_only_boolean_expressions_test.dart
similarity index 100%
rename from test/rules/literal_only_boolean_expressions.dart
rename to test/rules/literal_only_boolean_expressions_test.dart
diff --git a/test/rules/missing_whitespace_between_adjacent_strings.dart b/test/rules/missing_whitespace_between_adjacent_strings_test.dart
similarity index 100%
rename from test/rules/missing_whitespace_between_adjacent_strings.dart
rename to test/rules/missing_whitespace_between_adjacent_strings_test.dart
diff --git a/test/rules/non_constant_identifier_names.dart b/test/rules/non_constant_identifier_names_test.dart
similarity index 100%
rename from test/rules/non_constant_identifier_names.dart
rename to test/rules/non_constant_identifier_names_test.dart
diff --git a/test/rules/null_closures.dart b/test/rules/null_closures_test.dart
similarity index 100%
rename from test/rules/null_closures.dart
rename to test/rules/null_closures_test.dart
diff --git a/test/rules/omit_local_variable_types.dart b/test/rules/omit_local_variable_types_test.dart
similarity index 100%
rename from test/rules/omit_local_variable_types.dart
rename to test/rules/omit_local_variable_types_test.dart
diff --git a/test/rules/overridden_fields.dart b/test/rules/overridden_fields_test.dart
similarity index 100%
rename from test/rules/overridden_fields.dart
rename to test/rules/overridden_fields_test.dart
diff --git a/test/rules/prefer_asserts_in_initializer_lists.dart b/test/rules/prefer_asserts_in_initializer_lists_test.dart
similarity index 100%
rename from test/rules/prefer_asserts_in_initializer_lists.dart
rename to test/rules/prefer_asserts_in_initializer_lists_test.dart
diff --git a/test/rules/prefer_collection_literals.dart b/test/rules/prefer_collection_literals_test.dart
similarity index 100%
rename from test/rules/prefer_collection_literals.dart
rename to test/rules/prefer_collection_literals_test.dart
diff --git a/test/rules/prefer_const_constructors_in_immutables.dart b/test/rules/prefer_const_constructors_in_immutables_test.dart
similarity index 100%
rename from test/rules/prefer_const_constructors_in_immutables.dart
rename to test/rules/prefer_const_constructors_in_immutables_test.dart
diff --git a/test/rules/prefer_const_constructors.dart b/test/rules/prefer_const_constructors_test.dart
similarity index 100%
rename from test/rules/prefer_const_constructors.dart
rename to test/rules/prefer_const_constructors_test.dart
diff --git a/test/rules/prefer_const_literals_to_create_immutables.dart b/test/rules/prefer_const_literals_to_create_immutables_test.dart
similarity index 100%
rename from test/rules/prefer_const_literals_to_create_immutables.dart
rename to test/rules/prefer_const_literals_to_create_immutables_test.dart
diff --git a/test/rules/prefer_contains.dart b/test/rules/prefer_contains_test.dart
similarity index 100%
rename from test/rules/prefer_contains.dart
rename to test/rules/prefer_contains_test.dart
diff --git a/test/rules/prefer_equal_for_default_values.dart b/test/rules/prefer_equal_for_default_values_test.dart
similarity index 100%
rename from test/rules/prefer_equal_for_default_values.dart
rename to test/rules/prefer_equal_for_default_values_test.dart
diff --git a/test/rules/prefer_final_fields.dart b/test/rules/prefer_final_fields_test.dart
similarity index 100%
rename from test/rules/prefer_final_fields.dart
rename to test/rules/prefer_final_fields_test.dart
diff --git a/test/rules/prefer_final_parameters.dart b/test/rules/prefer_final_parameters_test.dart
similarity index 100%
rename from test/rules/prefer_final_parameters.dart
rename to test/rules/prefer_final_parameters_test.dart
diff --git a/test/rules/prefer_generic_function_type_aliases.dart b/test/rules/prefer_generic_function_type_aliases_test.dart
similarity index 100%
rename from test/rules/prefer_generic_function_type_aliases.dart
rename to test/rules/prefer_generic_function_type_aliases_test.dart
diff --git a/test/rules/prefer_spread_collections.dart b/test/rules/prefer_spread_collections_test.dart
similarity index 100%
rename from test/rules/prefer_spread_collections.dart
rename to test/rules/prefer_spread_collections_test.dart
diff --git a/test/rules/super_goes_last.dart b/test/rules/super_goes_last_test.dart
similarity index 100%
rename from test/rules/super_goes_last.dart
rename to test/rules/super_goes_last_test.dart
diff --git a/test/rules/tighten_type_of_initializing_formals.dart b/test/rules/tighten_type_of_initializing_formals_test.dart
similarity index 100%
rename from test/rules/tighten_type_of_initializing_formals.dart
rename to test/rules/tighten_type_of_initializing_formals_test.dart
diff --git a/test/rules/type_init_formals.dart b/test/rules/type_init_formals_test.dart
similarity index 100%
rename from test/rules/type_init_formals.dart
rename to test/rules/type_init_formals_test.dart
diff --git a/test/rules/unawaited_futures.dart b/test/rules/unawaited_futures_test.dart
similarity index 100%
rename from test/rules/unawaited_futures.dart
rename to test/rules/unawaited_futures_test.dart
diff --git a/test/rules/unnecessary_getters_setters.dart b/test/rules/unnecessary_getters_setters_test.dart
similarity index 100%
rename from test/rules/unnecessary_getters_setters.dart
rename to test/rules/unnecessary_getters_setters_test.dart
diff --git a/test/rules/unnecessary_null_checks.dart b/test/rules/unnecessary_null_checks_test.dart
similarity index 100%
rename from test/rules/unnecessary_null_checks.dart
rename to test/rules/unnecessary_null_checks_test.dart
diff --git a/test/rules/unnecessary_overrides.dart b/test/rules/unnecessary_overrides_test.dart
similarity index 100%
rename from test/rules/unnecessary_overrides.dart
rename to test/rules/unnecessary_overrides_test.dart
diff --git a/test/rules/use_is_even_rather_than_modulo.dart b/test/rules/use_is_even_rather_than_modulo_test.dart
similarity index 100%
rename from test/rules/use_is_even_rather_than_modulo.dart
rename to test/rules/use_is_even_rather_than_modulo_test.dart
diff --git a/test/rules/void_checks.dart b/test/rules/void_checks_test.dart
similarity index 100%
rename from test/rules/void_checks.dart
rename to test/rules/void_checks_test.dart