Skip to content

Upgrade to new native_assets #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Upgrade to new native_assets #964

wants to merge 10 commits into from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Apr 25, 2025

Update to newest version of native assets, now provided through the hooks and code_assets libraries.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Apr 25, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl4x Non-Breaking 0.11.3 0.11.4 0.11.4 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/intl4x/hook/build.dart 💔 Not covered
pkgs/intl4x/hook/link.dart 💔 Not covered
pkgs/intl4x/lib/src/display_names/display_names_impl.dart 💚 100 %
pkgs/intl4x/lib/src/hook_helpers/build_options.dart 💔 Not covered
pkgs/intl4x/lib/src/hook_helpers/hashes.dart 💔 Not covered
pkgs/intl4x/tool/regenerate_hashes.dart 💔 Not covered
pkgs/intl4x/tool/write_option_file.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem force-pushed the moreFixes branch 2 times, most recently from 8f7772b to 0699271 Compare May 23, 2025 13:35
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:intl 0.20.3-wip WIP (no publish necessary)
package:intl4x 0.11.4 ready to publish intl4x-v0.11.4
package:intl_translation 0.20.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem marked this pull request as ready for review May 23, 2025 14:04
@mosuem mosuem requested a review from robertbastian as a code owner May 23, 2025 14:04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have two build_libs files?

Copy link
Member Author

@mosuem mosuem May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if I use the one in lib/src/ to build native assets it will want to build native assets to run... not the nicest solution, more of a temporary stopgap. So I have one for building on CI, one for build hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants