-
Notifications
You must be signed in to change notification settings - Fork 47
Upgrade to new native_assets #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
File | Coverage |
---|---|
pkgs/intl4x/hook/build.dart | 💔 Not covered |
pkgs/intl4x/hook/link.dart | 💔 Not covered |
pkgs/intl4x/lib/src/display_names/display_names_impl.dart | 💚 100 % |
pkgs/intl4x/lib/src/hook_helpers/build_options.dart | 💔 Not covered |
pkgs/intl4x/lib/src/hook_helpers/hashes.dart | 💔 Not covered |
pkgs/intl4x/tool/regenerate_hashes.dart | 💔 Not covered |
pkgs/intl4x/tool/write_option_file.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
8f7772b
to
0699271
Compare
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have two build_libs files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if I use the one in lib/src/
to build native assets it will want to build native assets to run... not the nicest solution, more of a temporary stopgap. So I have one for building on CI, one for build hooks.
Update to newest version of native assets, now provided through the
hooks
andcode_assets
libraries.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.