Skip to content

[cronet_http] Migrate gradle files to use declarative syntax #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

brianquinlan
Copy link
Collaborator

See https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
cronet_http Non-Breaking 1.3.2 1.3.3-wip 1.4.0
Got "1.3.3-wip" expected >= "1.4.0" (non-breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_parser/test/example_test.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart

@brianquinlan brianquinlan changed the title Migrade Gradle to declarative symtax [cronet_http] Migrate gradle files to use declarative syntax Mar 19, 2025
@brianquinlan brianquinlan merged commit 1b6e28d into dart-lang:master Mar 20, 2025
33 of 34 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 20, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/c41b86b..d400676):
  d4006762  2025-03-18  Sam Rawlins  Remove some usages of analyzer private types and APIs (dart-lang/dartdoc#4020)

ecosystem (https://github.com/dart-lang/ecosystem/compare/5b8e6b8..2317263):
  2317263  2025-03-20  Brian Wilkerson  Update prompts.dart for the area changes (dart-lang/ecosystem#348)

http (https://github.com/dart-lang/http/compare/9129a96..1b6e28d):
  1b6e28d  2025-03-19  Brian Quinlan  [cronet_http] Migrate gradle files to use declarative syntax (dart-lang/http#1732)

Change-Id: Iffe1027fd6fbb2aba00056429f27e5fb0f04e855
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants