Document that runWithClient should not be used with Flutter

[brianquinlan]

I opted not to examine the possibility of using Zone.registerCallback because I think that it would be awkward to use in practice.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[natebosch]

Does package:http_client_image_provider work with package:provider?

[brianquinlan]

Yep, we even have an usage example in the demo app:

http/pkgs/flutter_http_example/lib/main.dart

Line 141 in bf96551

image: HttpImage(

The name HttpImage used by package:http_client_image_provider seems a bit unfortunate to me. I wonder if proposing to rename it to HttpClientImageProvider upstream would be worth it?

[natebosch]

I don't have an opinion on renaming - but this doc change LGTM given that usage in the example.

[ueman]

Maintainer of package:http_image_provider here: I don't mind the proposed name change. It should be pretty straightforward to change anyway. Just rename it, create an alias for the old name and mark the alias as deprecated.

[brianquinlan]

I started working on a package:http_image_provider PR yesterday but then I thought that the naming confusion is probably mostly caused by the fact that the Image widget calls its ImageProvider argument image.

So you have:

Image(image: HttpImage(...))  // Looks like we are nesting an images.

I guess that:

Image(image: HttpImageProvider(...)) // Slightly better?

is slightly better but really, the image parameter should be called something like provider so it reads like:

Image(provider: ...) // Now I actually understand that we are provider the data here.

it is probably still worth doing though and maybe I'll file a flutter issue as well