[cronet_http] Enables CI for cronet_http_embedded

[AlexV525]

Particially address #1047.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[AlexV525]

@brianquinlan

[brianquinlan]

This is technically excellent work but I'm stuff not sure that cronet_http_embedded belongs in the same repo as cronet_http.

Let me talk to my team about it.

[brianquinlan]

All of these types of upgrades should be done in a separate PR, no?

[AlexV525]

I'm planning to reorg workflows and examples for the repo in further separate PRs. These are necessary for the current setup. 1.6.10 is already outdated for the latest Flutter.

[brianquinlan]

OK, feel free to set these to any reasonable values.

[brianquinlan]

Why did you change this to macos? I think that there is more linux machine availability.

[AlexV525]

There are unknown timeouts when running on the Ubuntu runner. https://github.com/dart-lang/http/actions/runs/7270023551/job/19808487300?pr=1070

[brianquinlan]

OK, feel free to set these to any reasonable values.

[brianquinlan]

If I add these transforms to pkgs/cronet_http/tool/prepare_for_embedded.dart then the tests pass.

void updateImports() async {
  for (var file
      in _packageDirectory.listSync(recursive: true, followLinks: false)) {
    if (file.path.endsWith('.dart')) {
      final sourceFile = file as File;
      final updatedSource = sourceFile.readAsStringSync().replaceAll(
          'package:cronet_http/cronet_http.dart',
          'package:cronet_http_embedded/cronet_http_embedded.dart');
      sourceFile.writeAsStringSync(updatedSource);
    }
  }
}

void updateEntryPoint() async {
  File('${_packageDirectory.path}/lib/cronet_http.dart')
      .renameSync('${_packageDirectory.path}/lib/cronet_http_embedded.dart');
}

But the example application fails when making HTTP requests with:

E/flutter ( 7187): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: ClientException: Cronet exception: org.chromium.net.impl.NetworkExceptionImpl: Exception in CronetUrlRequest: net::ERR_CERT_DATE_INVALID, ErrorCode=11, InternalErrorCode=-201, Retryable=false, uri=https://www.googleapis.com/books/v1/volumes?q=tes&maxResults=40&printType=books

[AlexV525]

But the example application fails when making HTTP requests with:

E/flutter ( 7187): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: ClientException: Cronet exception: org.chromium.net.impl.NetworkExceptionImpl: Exception in CronetUrlRequest: net::ERR_CERT_DATE_INVALID, ErrorCode=11, InternalErrorCode=-201, Retryable=false, uri=https://www.googleapis.com/books/v1/volumes?q=tes&maxResults=40&printType=books

That doesn't seem to be a library issue. I tried flutter.cn and it works fine. Sorry I cannot access googleapis from my location and the library doesn't seem to support a proxy.

[AlexV525]

If I add these transforms to pkgs/cronet_http/tool/prepare_for_embedded.dart then the tests pass.

But the changes are great. I'm going to add it to the current script.

[brianquinlan]

Maybe only trigger on changes to this file? So updating the monorepo spec doesn't trigger a 20 minute presubmit.

[AlexV525]

Yeah sure. Will update these in another PR.

[brianquinlan]

I already updated this.

[brianquinlan]

I must misunderstand how this works - how can the tests work if the package imports inside the tests are not updated?

I mean, isn't the package test code still doing:

import 'package:cronet_http/cronet_http.dart';

But the tests pass so I'm confused ;-)

[AlexV525]

It doesn't change in the latest commit. I guess there are some other problems with the Ubuntu setup.

[brianquinlan]

Hey @AlexV525,

Looks great! My intent is to merge this in the next couple of hours and then do a package:cronet_http_embedded release.

After that I'll increment the version number to 1.0 and do a package:cronet_http release but it will be functionally identical to the last package:cronet_http_embedded release.

We can work on switching publishers for package:cronet_http_embedded in the New Year. A lot of my colleagues are on vacation so I can't do it now.

Thanks so much for all your work on this, and on Dart HTTP in general!