Skip to content

Commit 066ee93

Browse files
committed
Squash post-merge commits
1 parent e9e2cfd commit 066ee93

File tree

5 files changed

+19
-43
lines changed

5 files changed

+19
-43
lines changed

lib/src/dartdoc_options.dart

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,19 +1405,21 @@ class DartdocOptionContext extends DartdocOptionContextBase
14051405
/// Build a DartdocOptionContext from an analyzer element (using its source
14061406
/// location).
14071407
factory DartdocOptionContext.fromElement(DartdocOptionSet optionSet,
1408-
Element element, ResourceProvider resourceProvider) {
1409-
return DartdocOptionContext(optionSet,
1410-
resourceProvider.getFile(element.source.fullName), resourceProvider);
1408+
LibraryElement libraryElement, ResourceProvider resourceProvider) {
1409+
return DartdocOptionContext(
1410+
optionSet,
1411+
resourceProvider.getFile(libraryElement.source.fullName),
1412+
resourceProvider);
14111413
}
14121414

14131415
/// Build a DartdocOptionContext from an existing [DartdocOptionContext] and a
14141416
/// new analyzer [Element].
14151417
factory DartdocOptionContext.fromContextElement(
14161418
DartdocOptionContext optionContext,
1417-
Element element,
1419+
LibraryElement libraryElement,
14181420
ResourceProvider resourceProvider) {
14191421
return DartdocOptionContext.fromElement(
1420-
optionContext.optionSet, element, resourceProvider);
1422+
optionContext.optionSet, libraryElement, resourceProvider);
14211423
}
14221424

14231425
/// Build a DartdocOptionContext from an existing [DartdocOptionContext].

lib/src/model/category.dart

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -181,17 +181,6 @@ class Category extends Nameable
181181
return _documentationFile;
182182
}
183183

184-
@override
185-
void warn(PackageWarning kind,
186-
{String message,
187-
Iterable<Locatable> referredFrom,
188-
Iterable<String> extendedDebug}) {
189-
packageGraph.warnOnElement(this, kind,
190-
message: message,
191-
referredFrom: referredFrom,
192-
extendedDebug: extendedDebug);
193-
}
194-
195184
@override
196185
Iterable<Class> get classes => _classes;
197186

lib/src/model/model_element.dart

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ abstract class ModelElement extends Canonicalization
508508
@override
509509
DartdocOptionContext get config {
510510
_config ??= DartdocOptionContext.fromContextElement(
511-
packageGraph.config, element, packageGraph.resourceProvider);
511+
packageGraph.config, library.element, packageGraph.resourceProvider);
512512
return _config;
513513
}
514514

@@ -1105,17 +1105,6 @@ abstract class ModelElement extends Canonicalization
11051105
return _parameters;
11061106
}
11071107

1108-
@override
1109-
void warn(PackageWarning kind,
1110-
{String message,
1111-
Iterable<Locatable> referredFrom,
1112-
Iterable<String> extendedDebug}) {
1113-
packageGraph.warnOnElement(this, kind,
1114-
message: message,
1115-
referredFrom: referredFrom,
1116-
extendedDebug: extendedDebug);
1117-
}
1118-
11191108
@override
11201109
String computeDocumentationComment() => element.documentationComment;
11211110

lib/src/model/package.dart

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -369,17 +369,6 @@ class Package extends LibraryContainer
369369

370370
String get version => packageMeta.version ?? '0.0.0-unknown';
371371

372-
@override
373-
void warn(PackageWarning kind,
374-
{String message,
375-
Iterable<Locatable> referredFrom,
376-
Iterable<String> extendedDebug}) {
377-
packageGraph.warnOnElement(this, kind,
378-
message: message,
379-
referredFrom: referredFrom,
380-
extendedDebug: extendedDebug);
381-
}
382-
383372
final PackageMeta _packageMeta;
384373

385374
PackageMeta get packageMeta => _packageMeta;

lib/src/warnings.dart

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,15 +258,22 @@ final Map<PackageWarning, PackageWarningDefinition> packageWarningDefinitions =
258258

259259
/// Something that package warnings can be called on. Optionally associated
260260
/// with an analyzer [element].
261-
abstract class Warnable implements Canonicalization {
262-
void warn(PackageWarning warning,
263-
{String message, Iterable<Locatable> referredFrom});
264-
261+
mixin Warnable implements Canonicalization {
265262
Element get element;
266263

267264
Warnable get enclosingElement;
268265

269266
Package get package;
267+
268+
void warn(PackageWarning kind,
269+
{String message,
270+
Iterable<Locatable> referredFrom,
271+
Iterable<String> extendedDebug}) {
272+
packageGraph.warnOnElement(this, kind,
273+
message: message,
274+
referredFrom: referredFrom,
275+
extendedDebug: extendedDebug);
276+
}
270277
}
271278

272279
// The kinds of warnings that can be displayed when documenting a package.

0 commit comments

Comments
 (0)