Ship the "tall-style" experiment. #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does a few things: - Remove the "tall-style" experiment flag and treat it as always enabled. - Use language version instead of the experiment flag to determine which style you get. If the version is 3.7 or higher, you get the tall style. Otherwise, you get the short style. - Clean up the CHANGELOG.md and README.md a bit. I'll probably do some more copy editing on them before this gets published, but I wanted to get things roughly in order.
munificent
commented
Oct 14, 2024
| test('no options search if page width is specified on the CLI', () async { | ||
| await d.dir('foo', [ | ||
| analysisOptionsFile(pageWidth: 20), | ||
| d.file('main.dart', _unformatted), | ||
| ]).create(); | ||
|
|
||
| var process = await runFormatterOnDir([ | ||
| '--language-version=latest', // Error to not have language version. |
There was a problem hiding this comment.
These --language-version=latest lines were no longer necessary as of #1573, but I forgot to clean them up in that PR.
natebosch
approved these changes
Oct 14, 2024
Co-authored-by: Nate Bosch <nbosch@google.com>
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
Remove the "tall-style" experiment flag and treat it as always enabled.
Use language version instead of the experiment flag to determine which style you get. If the version is 3.7 or higher, you get the tall style. Otherwise, you get the short style.
Clean up the CHANGELOG.md and README.md a bit. I'll probably do some more copy editing on them before this gets published, but I wanted to get things roughly in order.
cc @leafpetersen @mit-mit