Add blank lines between more class members

[PiotrRogulski]

What input code did you provide to the formatter?

// All in one line, so that the formatter has to do all the work
class C {const C(); const C.another(); void f(){;} final x = 1; final y = 2; void foo() {;} void bar() {;} final z = 5;}

What output did the formatter produce?

class C {
  const C();
  const C.another();
  void f() {
    ;
  }

  final x = 1;
  final y = 2;
  void foo() {
    ;
  }

  void bar() {
    ;
  }

  final z = 5;
}

What output did you expect or want the formatter to produce?

Describe how you expected the formatter to format the code, ideally by showing what you had in mind as code.

class C {
  const C();
  const C.another();

  void f() {
    ;
  }

  final x = 1;
  final y = 2;

  void foo() {
    ;
  }

  void bar() {
    ;
  }

  final z = 5;
}

Anything else we should know?

This request is somewhat of an extension of #930 – the formatter adds lines only between the methods, and it would be nice if it added blank lines also before the method, if there's something else (like a field or a constructor).

I'd like the formatter to enforce the one-empty-line-rule, not just go along with it only if I add an empty line.

[munificent]

Right. Currently the formatter's rule is that if a member has a non-empty braced body, it forces a blank line after the member, but not before it. I think what you propose here is that if a member has a non-empty braced body, then it forces blank lines both before and after the member.

I'm not opposed to that, but I'm not sure if most users will like it. It's fairly common to see code like:

class C {
  int _someField;
  int get someField {
    // Do stuff...
    return _someField;
  }
}

The proposed change would force that to be:

class C {
  int _someField;

  int get someField {
    // Do stuff...
    return _someField;
  }
}

[PiotrRogulski]

@munificent That would be indeed less than optimal. My proposal was mainly motivated by snippets like this:

class MyWidget extends StatelessWidget {
  const MyWidget({required this.child});
  final Widget child;
  @override
  Widget build(BuildContext context) {
    ...
  }
}

The formatter is currently okay with this, but I'd like it to format it like this:

class MyWidget extends StatelessWidget {
  const MyWidget({required this.child});

  final Widget child;

  @override
  Widget build(BuildContext context) {
    ...
  }
}

(Maybe enforce an empty line before annotations like override?)

[munificent]

What rule do you have in mind that would force a blank line between these:

  const MyWidget({required this.child});

  final Widget child;

[PiotrRogulski]

Something along the lines of "Add an empty line between a constructor and a non-constructor"