prep to publish 6.0.0 of package:lints #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
| File | Coverage |
|---|---|
| pkgs/args/example/arg_parser/example.dart | 💔 Not covered |
| pkgs/args/example/command_runner/draw.dart | 💔 Not covered |
| pkgs/args/lib/args.dart | 💔 Not covered |
| pkgs/args/lib/command_runner.dart | 💚 97 % |
| pkgs/args/lib/src/allow_anything_parser.dart | 💚 75 % |
| pkgs/args/lib/src/arg_parser.dart | 💚 94 % |
| pkgs/args/lib/src/arg_parser_exception.dart | 💚 100 % |
| pkgs/args/lib/src/arg_results.dart | 💚 88 % |
| pkgs/args/lib/src/help_command.dart | 💚 77 % |
| pkgs/args/lib/src/option.dart | 💚 93 % |
| pkgs/args/lib/src/parser.dart | 💚 99 % |
| pkgs/args/lib/src/usage.dart | 💚 99 % |
| pkgs/args/lib/src/usage_exception.dart | 💚 33 % |
| pkgs/args/lib/src/utils.dart | 💚 100 % |
| pkgs/async/lib/async.dart | 💔 Not covered |
| pkgs/async/lib/src/async_cache.dart | 💚 92 % |
| pkgs/async/lib/src/async_memoizer.dart | 💚 100 % |
| pkgs/async/lib/src/byte_collector.dart | 💚 100 % |
| pkgs/async/lib/src/cancelable_operation.dart | 💚 97 % |
| pkgs/async/lib/src/chunked_stream_reader.dart | 💔 0 % ⬇️ NaN % |
| pkgs/async/lib/src/delegate/event_sink.dart | 💔 0 % ⬇️ NaN % |
| pkgs/async/lib/src/delegate/future.dart | 💚 38 % |
| pkgs/async/lib/src/delegate/sink.dart | 💔 0 % ⬇️ NaN % |
| pkgs/async/lib/src/delegate/stream.dart | 💔 0 % ⬇️ NaN % |
| pkgs/async/lib/src/delegate/stream_consumer.dart | 💔 0 % ⬇️ NaN % |
| pkgs/async/lib/src/delegate/stream_sink.dart | 💚 50 % |
| pkgs/async/lib/src/delegate/stream_subscription.dart | 💚 55 % |
| pkgs/async/lib/src/future_group.dart | 💚 100 % |
| pkgs/async/lib/src/lazy_stream.dart | 💚 100 % |
| pkgs/async/lib/src/null_stream_sink.dart | 💚 100 % |
| pkgs/async/lib/src/restartable_timer.dart | 💚 64 % |
| pkgs/async/lib/src/result/capture_sink.dart | 💚 100 % |
| pkgs/async/lib/src/result/capture_transformer.dart | 💚 100 % |
| pkgs/async/lib/src/result/error.dart | 💚 88 % |
| pkgs/async/lib/src/result/future.dart | 💚 100 % |
| pkgs/async/lib/src/result/release_sink.dart | 💚 100 % |
| pkgs/async/lib/src/result/release_transformer.dart | 💚 100 % |
| pkgs/async/lib/src/result/result.dart | 💚 84 % |
| pkgs/async/lib/src/result/value.dart | 💚 80 % |
| pkgs/async/lib/src/single_subscription_transformer.dart | 💚 78 % |
| pkgs/async/lib/src/sink_base.dart | 💚 100 % |
| pkgs/async/lib/src/stream_closer.dart | 💚 100 % |
| pkgs/async/lib/src/stream_completer.dart | 💚 98 % |
| pkgs/async/lib/src/stream_extensions.dart | 💚 100 % |
| pkgs/async/lib/src/stream_group.dart | 💚 93 % |
| pkgs/async/lib/src/stream_queue.dart | 💚 98 % |
| pkgs/async/lib/src/stream_sink_completer.dart | 💚 100 % |
| pkgs/async/lib/src/stream_sink_extensions.dart | 💚 33 % |
| pkgs/async/lib/src/stream_sink_transformer.dart | 💚 40 % |
| pkgs/async/lib/src/stream_sink_transformer/handler_transformer.dart | 💚 71 % |
| pkgs/async/lib/src/stream_sink_transformer/reject_errors.dart | 💚 100 % |
| pkgs/async/lib/src/stream_sink_transformer/stream_transformer_wrapper.dart | 💚 89 % |
| pkgs/async/lib/src/stream_sink_transformer/typed.dart | 💔 0 % ⬇️ NaN % |
| pkgs/async/lib/src/stream_splitter.dart | 💚 98 % |
| pkgs/async/lib/src/stream_subscription_transformer.dart | 💚 100 % |
| pkgs/async/lib/src/stream_zip.dart | 💚 86 % |
| pkgs/async/lib/src/subscription_stream.dart | 💚 100 % |
| pkgs/async/lib/src/typed/stream_subscription.dart | 💚 94 % |
| pkgs/async/lib/src/typed_stream_transformer.dart | 💔 0 % ⬇️ NaN % |
| pkgs/characters/benchmark/benchmark.dart | 💔 Not covered |
| pkgs/characters/example/main.dart | 💔 Not covered |
| pkgs/characters/lib/characters.dart | 💔 Not covered |
| pkgs/characters/lib/src/characters.dart | 💚 100 % |
| pkgs/characters/lib/src/characters_impl.dart | 💚 89 % |
| pkgs/characters/lib/src/extensions.dart | 💔 0 % ⬇️ NaN % |
| pkgs/characters/lib/src/grapheme_clusters/breaks.dart | 💚 97 % |
| pkgs/characters/lib/src/grapheme_clusters/constants.dart | 💔 Not covered |
| pkgs/characters/lib/src/grapheme_clusters/table.dart | 💚 100 % |
| pkgs/characters/tool/benchmark.dart | 💔 Not covered |
| pkgs/characters/tool/bin/generate_tables.dart | 💔 Not covered |
| pkgs/characters/tool/bin/generate_tests.dart | 💔 Not covered |
| pkgs/characters/tool/generate.dart | 💔 Not covered |
| pkgs/characters/tool/src/args.dart | 💔 Not covered |
| pkgs/characters/tool/src/atsp.dart | 💔 Not covered |
| pkgs/characters/tool/src/automaton_builder.dart | 💔 Not covered |
| pkgs/characters/tool/src/data_files.dart | 💔 Not covered |
| pkgs/characters/tool/src/debug_names.dart | 💚 12 % |
| pkgs/characters/tool/src/graph.dart | 💔 Not covered |
| pkgs/characters/tool/src/grapheme_category_loader.dart | 💔 Not covered |
| pkgs/characters/tool/src/indirect_table.dart | 💔 Not covered |
| pkgs/characters/tool/src/list_overlap.dart | 💔 Not covered |
| pkgs/characters/tool/src/shared.dart | 💔 Not covered |
| pkgs/characters/tool/src/string_literal_writer.dart | 💔 Not covered |
| pkgs/characters/tool/src/table_builder.dart | 💔 Not covered |
| pkgs/collection/benchmark/deep_collection_equality.dart | 💔 Not covered |
| pkgs/collection/lib/algorithms.dart | 💔 Not covered |
| pkgs/collection/lib/collection.dart | 💔 Not covered |
| pkgs/collection/lib/equality.dart | 💔 Not covered |
| pkgs/collection/lib/iterable_zip.dart | 💔 Not covered |
| pkgs/collection/lib/priority_queue.dart | 💔 Not covered |
| pkgs/collection/lib/src/algorithms.dart | 💚 99 % |
| pkgs/collection/lib/src/boollist.dart | 💚 100 % |
| pkgs/collection/lib/src/canonicalized_map.dart | 💚 77 % |
| pkgs/collection/lib/src/combined_wrappers/combined_iterable.dart | 💚 100 % |
| pkgs/collection/lib/src/combined_wrappers/combined_iterator.dart | 💚 100 % |
| pkgs/collection/lib/src/combined_wrappers/combined_list.dart | 💚 100 % |
| pkgs/collection/lib/src/combined_wrappers/combined_map.dart | 💚 100 % |
| pkgs/collection/lib/src/comparators.dart | 💚 99 % |
| pkgs/collection/lib/src/empty_unmodifiable_set.dart | 💚 61 % |
| pkgs/collection/lib/src/equality.dart | 💚 89 % |
| pkgs/collection/lib/src/equality_map.dart | 💚 100 % |
| pkgs/collection/lib/src/equality_set.dart | 💚 100 % |
| pkgs/collection/lib/src/functions.dart | 💚 100 % |
| pkgs/collection/lib/src/iterable_extensions.dart | 💚 100 % |
| pkgs/collection/lib/src/iterable_zip.dart | 💚 100 % |
| pkgs/collection/lib/src/list_extensions.dart | 💚 61 % |
| pkgs/collection/lib/src/priority_queue.dart | 💚 98 % |
| pkgs/collection/lib/src/queue_list.dart | 💚 86 % |
| pkgs/collection/lib/src/union_set.dart | 💚 100 % |
| pkgs/collection/lib/src/union_set_controller.dart | 💚 100 % |
| pkgs/collection/lib/src/unmodifiable_wrappers.dart | 💚 75 % |
| pkgs/collection/lib/src/utils.dart | 💚 100 % |
| pkgs/collection/lib/src/wrappers.dart | 💚 78 % |
| pkgs/collection/lib/wrappers.dart | 💔 Not covered |
| pkgs/convert/benchmark/fixed_datetime_formatter_benchmark.dart | 💔 Not covered |
| pkgs/convert/example/example.dart | 💔 Not covered |
| pkgs/convert/lib/convert.dart | 💔 Not covered |
| pkgs/convert/lib/src/accumulator_sink.dart | 💚 100 % |
| pkgs/convert/lib/src/byte_accumulator_sink.dart | 💚 100 % |
| pkgs/convert/lib/src/charcodes.dart | 💔 Not covered |
| pkgs/convert/lib/src/codepage.dart | 💚 72 % |
| pkgs/convert/lib/src/fixed_datetime_formatter.dart | 💚 96 % |
| pkgs/convert/lib/src/hex.dart | 💚 100 % |
| pkgs/convert/lib/src/hex/decoder.dart | 💚 57 % |
| pkgs/convert/lib/src/hex/encoder.dart | 💚 76 % |
| pkgs/convert/lib/src/identity_codec.dart | 💚 100 % |
| pkgs/convert/lib/src/percent.dart | 💚 100 % |
| pkgs/convert/lib/src/percent/decoder.dart | 💚 66 % |
| pkgs/convert/lib/src/percent/encoder.dart | 💚 82 % |
| pkgs/convert/lib/src/string_accumulator_sink.dart | 💚 100 % |
| pkgs/convert/lib/src/utils.dart | 💚 100 % |
| pkgs/crypto/example/example.dart | 💔 Not covered |
| pkgs/crypto/lib/crypto.dart | 💔 Not covered |
| pkgs/crypto/lib/src/digest.dart | 💚 48 % |
| pkgs/crypto/lib/src/digest_sink.dart | 💚 100 % |
| pkgs/crypto/lib/src/hash.dart | 💚 100 % |
| pkgs/crypto/lib/src/hash_sink.dart | 💚 98 % |
| pkgs/crypto/lib/src/hmac.dart | 💚 91 % |
| pkgs/crypto/lib/src/md5.dart | 💚 100 % |
| pkgs/crypto/lib/src/sha1.dart | 💚 100 % |
| pkgs/crypto/lib/src/sha256.dart | 💚 100 % |
| pkgs/crypto/lib/src/sha512.dart | 💚 100 % |
| pkgs/crypto/lib/src/sha512_fastsinks.dart | 💚 100 % |
| pkgs/crypto/lib/src/sha512_slowsinks.dart | 💔 Not covered |
| pkgs/crypto/lib/src/utils.dart | 💚 100 % |
| pkgs/fixnum/lib/fixnum.dart | 💔 Not covered |
| pkgs/fixnum/lib/src/int32.dart | 💚 94 % |
| pkgs/fixnum/lib/src/int64.dart | 💚 98 % |
| pkgs/fixnum/lib/src/intx.dart | 💔 Not covered |
| pkgs/fixnum/lib/src/utilities.dart | 💚 100 % |
| pkgs/lints/tool/gen_docs.dart | 💔 Not covered |
| pkgs/lints/tool/validate_lib.dart | 💔 Not covered |
| pkgs/logging/example/main.dart | 💔 Not covered |
| pkgs/logging/lib/logging.dart | 💔 Not covered |
| pkgs/logging/lib/src/level.dart | 💚 100 % |
| pkgs/logging/lib/src/log_record.dart | 💚 60 % |
| pkgs/logging/lib/src/logger.dart | 💚 98 % |
| pkgs/os_detect/bin/os_detect.dart | 💔 Not covered |
| pkgs/os_detect/example/example.dart | 💔 Not covered |
| pkgs/os_detect/example/tree_shaking.dart | 💔 Not covered |
| pkgs/os_detect/lib/os_detect.dart | 💚 100 % |
| pkgs/os_detect/lib/override.dart | 💔 Not covered |
| pkgs/os_detect/lib/src/os_kind.dart | 💚 100 % |
| pkgs/os_detect/lib/src/os_override.dart | 💚 100 % |
| pkgs/os_detect/lib/src/osid_html.dart | 💔 Not covered |
| pkgs/os_detect/lib/src/osid_io.dart | 💚 40 % |
| pkgs/os_detect/lib/src/osid_unknown.dart | 💔 Not covered |
| pkgs/path/benchmark/benchmark.dart | 💔 Not covered |
| pkgs/path/example/example.dart | 💔 Not covered |
| pkgs/path/lib/path.dart | 💚 49 % |
| pkgs/path/lib/src/characters.dart | 💔 Not covered |
| pkgs/path/lib/src/context.dart | 💚 98 % |
| pkgs/path/lib/src/internal_style.dart | 💚 100 % |
| pkgs/path/lib/src/parsed_path.dart | 💚 100 % |
| pkgs/path/lib/src/path_exception.dart | 💚 33 % |
| pkgs/path/lib/src/path_map.dart | 💚 100 % |
| pkgs/path/lib/src/path_set.dart | 💚 39 % |
| pkgs/path/lib/src/style.dart | 💚 100 % |
| pkgs/path/lib/src/style/posix.dart | 💚 91 % |
| pkgs/path/lib/src/style/url.dart | 💚 95 % |
| pkgs/path/lib/src/style/windows.dart | 💚 96 % |
| pkgs/path/lib/src/utils.dart | 💚 98 % |
| pkgs/platform/example/bin/example.dart | 💔 Not covered |
| pkgs/platform/lib/platform.dart | 💔 Not covered |
| pkgs/platform/lib/src/interface/local_platform.dart | 💚 100 % |
| pkgs/platform/lib/src/interface/platform.dart | 💚 75 % |
| pkgs/platform/lib/src/testing/fake_platform.dart | 💚 99 % |
| pkgs/typed_data/lib/src/typed_buffer.dart | 💚 83 % |
| pkgs/typed_data/lib/src/typed_queue.dart | 💚 51 % |
| pkgs/typed_data/lib/typed_buffers.dart | 💔 Not covered |
| pkgs/typed_data/lib/typed_data.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|---|
| path | InternalStyle |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
cc @lrhn, @natebosch, @kallentu, and @srawlins for thoughts on the min SDK to use for this publish (to let the lints solve into 3.7, or require 3.8 w/ the updated version of |
mosuem
approved these changes
Apr 14, 2025
github-actions
bot
added
the
type-infra
|
Thinking about this a bit, the fix for |
|
And, because we're publishing a preview version of the package (a stable package depending on the next release of the SDK), we're hitting this issue:
We really need to be able to suppress this warning from pub publish. This is dart-lang/pub#3807 or some variant. |
|
dart-lang/ecosystem#357 to work-around the pub validation issue |
natebosch
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been several major SDK releases since we last published so I think we can publish the queued changes. Some notes:
strict_top_level_inferenceto coreunnecessary_underscoresto recommendeddart createandflutter createtemplates - referencing this new version - for Dart 3.8. That's probably ok.strict_top_level_inferencewhich was not in the 3.7 sdk release but will be in the 3.8 one; strict_top_level_inference is triggered for wildcard variables sdk#60136 - 'strict_top_level_inference is triggered for wildcard variables'Given that last fix (which improves the correctness for wildcard variables, but wouldn't have been a showstopper for shipping the lint) we could either keep the required min sdk at 3.7 (the current value), or bump it to 3.8.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.