Skip to content

Add --use-experimental-resolver flag. #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Feb 6, 2025

This makes it easier for me to compare, and for external users to try the new implementation before it's live.

@jakemac53 could you please help me figure out what I need to do with pubspec.yaml here?

It introduces new API in build_resolvers that is needed in build_runner, I tried bumping the dep but that obviously doesn't work because pub get fails on CI. Should I change to a path dependency until everything is released? Is there anything else I need to do / be aware of?

Thanks :)

Copy link

github-actions bot commented Feb 6, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@davidmorgan davidmorgan requested a review from jakemac53 February 6, 2025 10:14
@davidmorgan davidmorgan mentioned this pull request Feb 6, 2025
@jakemac53
Copy link
Contributor

Should I change to a path dependency until everything is released? Is there anything else I need to do / be aware of?

I think you can just change the dependency to be ^2.4.4-wip so it matches the actual version in the pubspec. But then you need to remember to update that to ^2.4.4.

If this is for a package not in the pub workspace, then you will want a dependency override.

Copy link

github-actions bot commented Feb 7, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:build 2.4.2 already published at pub.dev
package:build_config 1.1.2 already published at pub.dev
package:build_daemon 4.0.4 ready to publish build_daemon-v4.0.4
package:build_modules 5.0.11 already published at pub.dev
package:build_resolvers 2.4.4-wip WIP (no publish necessary)
package:build_runner 2.4.15-wip WIP (no publish necessary)
package:build_runner_core 8.0.1-dev ready to publish build_runner_core-v8.0.1-dev
package:build_test 2.2.4-wip WIP (no publish necessary)
package:build_web_compilers 4.1.1 already published at pub.dev
package:scratch_space 1.0.3-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@davidmorgan
Copy link
Contributor Author

@jakemac53 done, PTAL :) thanks.

@davidmorgan davidmorgan requested a review from jensjoha February 10, 2025 08:10
@davidmorgan davidmorgan force-pushed the experimental-resolver-flag branch from ba1bc33 to cedd721 Compare February 10, 2025 13:24
@davidmorgan davidmorgan merged commit 25d5f61 into dart-lang:master Feb 10, 2025
72 checks passed
@davidmorgan davidmorgan deleted the experimental-resolver-flag branch February 10, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants